From nobody Thu Nov 6 08:30:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1497524875288264.67822810761174; Thu, 15 Jun 2017 04:07:55 -0700 (PDT) Received: from localhost ([::1]:53192 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLScz-0004pc-1z for importer@patchew.org; Thu, 15 Jun 2017 07:07:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40768) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dLSOw-0008Bx-9M for qemu-devel@nongnu.org; Thu, 15 Jun 2017 06:53:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dLSOv-0007W7-HW for qemu-devel@nongnu.org; Thu, 15 Jun 2017 06:53:22 -0400 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:35256) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dLSOv-0007Ve-CA for qemu-devel@nongnu.org; Thu, 15 Jun 2017 06:53:21 -0400 Received: by mail-wr0-x242.google.com with SMTP id z45so2761739wrb.2 for ; Thu, 15 Jun 2017 03:53:21 -0700 (PDT) Received: from 640k.lan (94-39-191-51.adsl-ull.clienti.tiscali.it. [94.39.191.51]) by smtp.gmail.com with ESMTPSA id f21sm3258597wra.5.2017.06.15.03.53.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Jun 2017 03:53:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=6itgTMLpSalQ0XmD16+kDiRiX96cxwbgYqx7QT2QAkA=; b=By32fKCOavOKKR1gf5KQHbCrpoOxdJxdQ8xk6HFId6KqKLPvMqtlfiArm/eFPN4xag 8h34I8sa8sj5TC8O5NecJcaT5fakaAXRwtWpXKenzXAN1aCgTP5/OD8Y0qTl5JhDFYBa 0NLB9iC0jr/rWQ2Ong8BR2DbttlUOU/WhDMSZcWioRat5Ebne4vuMmDjIQwWhBWQKZxH csDwaa0bIdH8WLGmzvdAGZtYDtkjzJ/KR5MZORgYY4TBlsEhzL46sEPZocM0knA4Bstt 28v3j5WCGcuisG9uUSDOnmTaKF59JwPwDjhw5s/QoCHIXsg1G/lNVi9xeGEeAtIFGcTW 5RuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=6itgTMLpSalQ0XmD16+kDiRiX96cxwbgYqx7QT2QAkA=; b=lMJjta1PUY1L+3YiZrKDB30+PotpT62FECsn8f6RC+QiT0K3VtbYMBMmQ9OgxikkRB h0j3JgiTBtMdbCvK+yA4kM6VDoABoeUhI+db0AyoiJqrmX66dRWZVh/zXw4cswvyTcCE iF63SAP7fxoBK31pJe7YPyK/+UG6JMcwXyvRkHanapQb0MyAJDOmfCM7XYXDJJy9FGal lLIugfCI45o6eq5Q0D2KlGFyzFTitYQLUIbW2GAsqvTVNjETQXbNevpeKRWl3hQJYl0y ZXXIXpV04PEvhuCDZ6Y9B2xnNP1TTF/IPpwmAHu4B8k08ZwnXUyahPJEwLNSjwq1SxiZ nRxA== X-Gm-Message-State: AKS2vOxvlX5lqveMyZ8in0T1BsOtjFmPAMSop8liRR1bHn85CUwWRNWg YYaPKsfQQzC0RB33h0w= X-Received: by 10.28.111.14 with SMTP id k14mr3185009wmc.94.1497524000141; Thu, 15 Jun 2017 03:53:20 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Thu, 15 Jun 2017 12:52:29 +0200 Message-Id: <1497523981-38449-10-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1497523981-38449-1-git-send-email-pbonzini@redhat.com> References: <1497523981-38449-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::242 Subject: [Qemu-devel] [PULL 09/41] megasas: do not read iovec count more than once from frame X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Avoid TOC-TOU bugs depending on how the compiler behaves. Signed-off-by: Paolo Bonzini --- hw/scsi/megasas.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index 1888118..c353118 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -675,15 +675,16 @@ out: static int megasas_map_dcmd(MegasasState *s, MegasasCmd *cmd) { dma_addr_t iov_pa, iov_size; + int iov_count; =20 cmd->flags =3D le16_to_cpu(cmd->frame->header.flags); - if (!cmd->frame->header.sge_count) { + iov_count =3D cmd->frame->header.sge_count; + if (!iov_count) { trace_megasas_dcmd_zero_sge(cmd->index); cmd->iov_size =3D 0; return 0; - } else if (cmd->frame->header.sge_count > 1) { - trace_megasas_dcmd_invalid_sge(cmd->index, - cmd->frame->header.sge_count); + } else if (iov_count > 1) { + trace_megasas_dcmd_invalid_sge(cmd->index, iov_count); cmd->iov_size =3D 0; return -EINVAL; } --=20 1.8.3.1