From nobody Wed Dec 17 21:58:40 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1497364396219274.8429982763796; Tue, 13 Jun 2017 07:33:16 -0700 (PDT) Received: from localhost ([::1]:43609 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKmsb-00081r-Ix for importer@patchew.org; Tue, 13 Jun 2017 10:33:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dKmTf-0005LJ-FQ for qemu-devel@nongnu.org; Tue, 13 Jun 2017 10:07:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dKmTe-0006kk-74 for qemu-devel@nongnu.org; Tue, 13 Jun 2017 10:07:27 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:37257) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dKmTd-0006cz-V3 for qemu-devel@nongnu.org; Tue, 13 Jun 2017 10:07:26 -0400 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.84_2) (envelope-from ) id 1dKmTO-000123-3f for qemu-devel@nongnu.org; Tue, 13 Jun 2017 15:07:10 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Tue, 13 Jun 2017 15:06:52 +0100 Message-Id: <1497362826-21125-4-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1497362826-21125-1-git-send-email-peter.maydell@linaro.org> References: <1497362826-21125-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PULL 03/17] hw/timer/exynos4210_mct: Cleanup indentation and empty new lines X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 From: Krzysztof Kozlowski Statements under 'case' were in some places wrongly indented bringing confusion and making the code less readable. Remove also few unneeded blank lines. No functional changes. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Peter Maydell --- hw/timer/exynos4210_mct.c | 45 ++++++++++++++++++++-----------------------= -- 1 file changed, 20 insertions(+), 25 deletions(-) diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c index 2404fb7..ea5f99d 100644 --- a/hw/timer/exynos4210_mct.c +++ b/hw/timer/exynos4210_mct.c @@ -1016,9 +1016,9 @@ static uint64_t exynos4210_mct_read(void *opaque, hwa= ddr offset, =20 case G_COMP_L(0): case G_COMP_L(1): case G_COMP_L(2): case G_COMP_L(3): case G_COMP_U(0): case G_COMP_U(1): case G_COMP_U(2): case G_COMP_U(3): - index =3D GET_G_COMP_IDX(offset); - shift =3D 8 * (offset & 0x4); - value =3D UINT32_MAX & (s->g_timer.reg.comp[index] >> shift); + index =3D GET_G_COMP_IDX(offset); + shift =3D 8 * (offset & 0x4); + value =3D UINT32_MAX & (s->g_timer.reg.comp[index] >> shift); break; =20 case G_TCON: @@ -1067,7 +1067,6 @@ static uint64_t exynos4210_mct_read(void *opaque, hwa= ddr offset, lt_i =3D GET_L_TIMER_IDX(offset); =20 value =3D exynos4210_lfrc_get_count(&s->l_timer[lt_i]); - break; =20 case L0_TCON: case L1_TCON: @@ -1153,23 +1152,23 @@ static void exynos4210_mct_write(void *opaque, hwad= dr offset, =20 case G_COMP_L(0): case G_COMP_L(1): case G_COMP_L(2): case G_COMP_L(3): case G_COMP_U(0): case G_COMP_U(1): case G_COMP_U(2): case G_COMP_U(3): - index =3D GET_G_COMP_IDX(offset); - shift =3D 8 * (offset & 0x4); - s->g_timer.reg.comp[index] =3D - (s->g_timer.reg.comp[index] & - (((uint64_t)UINT32_MAX << 32) >> shift)) + - (value << shift); + index =3D GET_G_COMP_IDX(offset); + shift =3D 8 * (offset & 0x4); + s->g_timer.reg.comp[index] =3D + (s->g_timer.reg.comp[index] & + (((uint64_t)UINT32_MAX << 32) >> shift)) + + (value << shift); =20 - DPRINTF("comparator %d write 0x%llx val << %d\n", index, value, shift); + DPRINTF("comparator %d write 0x%llx val << %d\n", index, value, sh= ift); =20 - if (offset & 0x4) { - s->g_timer.reg.wstat |=3D G_WSTAT_COMP_U(index); - } else { - s->g_timer.reg.wstat |=3D G_WSTAT_COMP_L(index); - } + if (offset & 0x4) { + s->g_timer.reg.wstat |=3D G_WSTAT_COMP_U(index); + } else { + s->g_timer.reg.wstat |=3D G_WSTAT_COMP_L(index); + } =20 - exynos4210_gfrc_restart(s); - break; + exynos4210_gfrc_restart(s); + break; =20 case G_TCON: old_val =3D s->g_timer.reg.tcon; @@ -1207,7 +1206,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, break; =20 case G_INT_ENB: - /* Raise IRQ if transition from disabled to enabled and CSTAT pend= ing */ for (i =3D 0; i < MCT_GT_CMP_NUM; i++) { if ((value & G_INT_ENABLE(i)) > (s->g_timer.reg.tcon & @@ -1288,7 +1286,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, break; =20 case L0_TCNTB: case L1_TCNTB: - lt_i =3D GET_L_TIMER_IDX(offset); index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 @@ -1316,7 +1313,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, break; =20 case L0_ICNTB: case L1_ICNTB: - lt_i =3D GET_L_TIMER_IDX(offset); index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 @@ -1353,13 +1349,12 @@ static void exynos4210_mct_write(void *opaque, hwad= dr offset, if (icntb_max[lt_i] < value) { icntb_max[lt_i] =3D value; } -DPRINTF("local timer[%d] ICNTB write %llx; max=3D%x, min=3D%x\n\n", - lt_i, value, icntb_max[lt_i], icntb_min[lt_i]); + DPRINTF("local timer[%d] ICNTB write %llx; max=3D%x, min=3D%x\n\n", + lt_i, value, icntb_max[lt_i], icntb_min[lt_i]); #endif -break; + break; =20 case L0_FRCNTB: case L1_FRCNTB: - lt_i =3D GET_L_TIMER_IDX(offset); index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 --=20 2.7.4