From nobody Thu Dec 18 23:03:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1496806599466595.5603509308361; Tue, 6 Jun 2017 20:36:39 -0700 (PDT) Received: from localhost ([::1]:41092 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIRlu-0006qR-4s for importer@patchew.org; Tue, 06 Jun 2017 23:36:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIRja-0005Qw-Ol for qemu-devel@nongnu.org; Tue, 06 Jun 2017 23:34:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIRjY-0000wc-FJ for qemu-devel@nongnu.org; Tue, 06 Jun 2017 23:34:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33278) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dIRjY-0000wS-91 for qemu-devel@nongnu.org; Tue, 06 Jun 2017 23:34:12 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4EE228553D; Wed, 7 Jun 2017 03:34:11 +0000 (UTC) Received: from jason-ThinkPad-T450s.redhat.com (ovpn-12-37.pek2.redhat.com [10.72.12.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9109862926; Wed, 7 Jun 2017 03:34:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4EE228553D Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jasowang@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 4EE228553D From: Jason Wang To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Wed, 7 Jun 2017 11:34:03 +0800 Message-Id: <1496806444-27910-2-git-send-email-jasowang@redhat.com> In-Reply-To: <1496806444-27910-1-git-send-email-jasowang@redhat.com> References: <1496806444-27910-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 07 Jun 2017 03:34:11 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 1/2] net/rocker: Cleanup the useless return value check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mao Zhongyi , Jason Wang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Mao Zhongyi None of pci_dma_read()'s callers check the return value except rocker. There is no need to check it because it always return 0. So the check work is useless. Remove it entirely. Suggested-by: Markus Armbruster Signed-off-by: Mao Zhongyi Signed-off-by: Jason Wang --- hw/net/rocker/rocker.c | 9 +++------ hw/net/rocker/rocker_desc.c | 4 +--- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/hw/net/rocker/rocker.c b/hw/net/rocker/rocker.c index 6e70fdd..4f0f6d7 100644 --- a/hw/net/rocker/rocker.c +++ b/hw/net/rocker/rocker.c @@ -244,11 +244,9 @@ static int tx_consume(Rocker *r, DescInfo *info) goto err_no_mem; } =20 - if (pci_dma_read(dev, frag_addr, iov[iovcnt].iov_base, - iov[iovcnt].iov_len)) { - err =3D -ROCKER_ENXIO; - goto err_bad_io; - } + pci_dma_read(dev, frag_addr, iov[iovcnt].iov_base, + iov[iovcnt].iov_len); + iovcnt++; } =20 @@ -261,7 +259,6 @@ static int tx_consume(Rocker *r, DescInfo *info) err =3D fp_port_eg(r->fp_port[port], iov, iovcnt); =20 err_too_many_frags: -err_bad_io: err_no_mem: err_bad_attr: for (i =3D 0; i < ROCKER_TX_FRAGS_MAX; i++) { diff --git a/hw/net/rocker/rocker_desc.c b/hw/net/rocker/rocker_desc.c index ac02797..6184c40 100644 --- a/hw/net/rocker/rocker_desc.c +++ b/hw/net/rocker/rocker_desc.c @@ -69,9 +69,7 @@ char *desc_get_buf(DescInfo *info, bool read_only) return NULL; } =20 - if (pci_dma_read(dev, le64_to_cpu(info->desc.buf_addr), info->buf, siz= e)) { - return NULL; - } + pci_dma_read(dev, le64_to_cpu(info->desc.buf_addr), info->buf, size); =20 return info->buf; } --=20 2.7.4 From nobody Thu Dec 18 23:03:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1496806527629474.3999707185345; Tue, 6 Jun 2017 20:35:27 -0700 (PDT) Received: from localhost ([::1]:41090 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIRkk-00064O-61 for importer@patchew.org; Tue, 06 Jun 2017 23:35:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dIRjc-0005R2-59 for qemu-devel@nongnu.org; Tue, 06 Jun 2017 23:34:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dIRja-0000x4-Tj for qemu-devel@nongnu.org; Tue, 06 Jun 2017 23:34:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42188) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dIRja-0000wn-Lo for qemu-devel@nongnu.org; Tue, 06 Jun 2017 23:34:14 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B40B23B70D; Wed, 7 Jun 2017 03:34:13 +0000 (UTC) Received: from jason-ThinkPad-T450s.redhat.com (ovpn-12-37.pek2.redhat.com [10.72.12.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECB0362926; Wed, 7 Jun 2017 03:34:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B40B23B70D Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jasowang@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B40B23B70D From: Jason Wang To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Wed, 7 Jun 2017 11:34:04 +0800 Message-Id: <1496806444-27910-3-git-send-email-jasowang@redhat.com> In-Reply-To: <1496806444-27910-1-git-send-email-jasowang@redhat.com> References: <1496806444-27910-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 07 Jun 2017 03:34:13 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 2/2] Revert "Change net/socket.c to use socket_*() functions" again X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Daniel P. Berrange" This reverts commit 883e4f7624e10b98d16d9adaffb8b1795664d899. This code changed net/socket.c from using socket()+connect(), to using socket_connect(). In theory this is great, but in practice this has completely broken the ability to connect the frontend and backend: $ ./x86_64-softmmu/qemu-system-x86_64 \ -device e1000,id=3De0,netdev=3Dhn0,mac=3DDE:AD:BE:EF:AF:05 \ -netdev socket,id=3Dhn0,connect=3Dlocalhost:1234 qemu-system-x86_64: -device e1000,id=3De0,netdev=3Dhn0,mac=3DDE:AD:BE:EF:= AF:05: Property 'e1000.netdev' can't find value 'hn0' The old code would call net_socket_fd_init() synchronously, while letting the connect() complete in the backgorund. The new code moved net_socket_fd_init() so that it is only called after connect() completes in the background. Thus at the time we initialize the NIC frontend, the backend does not exist. The socket_connect() conversion as done is a bad fit for the current code, since it did not try to change the way it deals with async connection completion. Rather than try to fix this, just revert the socket_connect() conversion entirely. The code is about to be converted to use QIOChannel which will let the problem be solved in a cleaner manner. This revert is more suitable for stable branches in the meantime. Signed-off-by: Daniel P. Berrange Reviewed-by: Stefan Hajnoczi Signed-off-by: Jason Wang --- net/socket.c | 127 ++++++++++++++++++++++++++-----------------------------= ---- 1 file changed, 56 insertions(+), 71 deletions(-) diff --git a/net/socket.c b/net/socket.c index b8c931e..dcae1ae 100644 --- a/net/socket.c +++ b/net/socket.c @@ -489,106 +489,91 @@ static int net_socket_listen_init(NetClientState *pe= er, { NetClientState *nc; NetSocketState *s; - SocketAddress *saddr; - int ret; - Error *local_error =3D NULL; + struct sockaddr_in saddr; + int fd, ret; =20 - saddr =3D socket_parse(host_str, &local_error); - if (saddr =3D=3D NULL) { - error_report_err(local_error); + if (parse_host_port(&saddr, host_str) < 0) + return -1; + + fd =3D qemu_socket(PF_INET, SOCK_STREAM, 0); + if (fd < 0) { + perror("socket"); return -1; } + qemu_set_nonblock(fd); + + socket_set_fast_reuse(fd); =20 - ret =3D socket_listen(saddr, &local_error); + ret =3D bind(fd, (struct sockaddr *)&saddr, sizeof(saddr)); if (ret < 0) { - qapi_free_SocketAddress(saddr); - error_report_err(local_error); + perror("bind"); + closesocket(fd); + return -1; + } + ret =3D listen(fd, 0); + if (ret < 0) { + perror("listen"); + closesocket(fd); return -1; } =20 nc =3D qemu_new_net_client(&net_socket_info, peer, model, name); s =3D DO_UPCAST(NetSocketState, nc, nc); s->fd =3D -1; - s->listen_fd =3D ret; + s->listen_fd =3D fd; s->nc.link_down =3D true; net_socket_rs_init(&s->rs, net_socket_rs_finalize); =20 qemu_set_fd_handler(s->listen_fd, net_socket_accept, NULL, s); - qapi_free_SocketAddress(saddr); return 0; } =20 -typedef struct { - NetClientState *peer; - SocketAddress *saddr; - char *model; - char *name; -} socket_connect_data; - -static void socket_connect_data_free(socket_connect_data *c) -{ - qapi_free_SocketAddress(c->saddr); - g_free(c->model); - g_free(c->name); - g_free(c); -} - -static void net_socket_connected(int fd, Error *err, void *opaque) -{ - socket_connect_data *c =3D opaque; - NetSocketState *s; - char *addr_str =3D NULL; - Error *local_error =3D NULL; - - addr_str =3D socket_address_to_string(c->saddr, &local_error); - if (addr_str =3D=3D NULL) { - error_report_err(local_error); - closesocket(fd); - goto end; - } - - s =3D net_socket_fd_init(c->peer, c->model, c->name, fd, true); - if (!s) { - closesocket(fd); - goto end; - } - - snprintf(s->nc.info_str, sizeof(s->nc.info_str), - "socket: connect to %s", addr_str); - -end: - g_free(addr_str); - socket_connect_data_free(c); -} - static int net_socket_connect_init(NetClientState *peer, const char *model, const char *name, const char *host_str) { - socket_connect_data *c =3D g_new0(socket_connect_data, 1); - int fd =3D -1; - Error *local_error =3D NULL; + NetSocketState *s; + int fd, connected, ret; + struct sockaddr_in saddr; =20 - c->peer =3D peer; - c->model =3D g_strdup(model); - c->name =3D g_strdup(name); - c->saddr =3D socket_parse(host_str, &local_error); - if (c->saddr =3D=3D NULL) { - goto err; - } + if (parse_host_port(&saddr, host_str) < 0) + return -1; =20 - fd =3D socket_connect(c->saddr, net_socket_connected, c, &local_error); + fd =3D qemu_socket(PF_INET, SOCK_STREAM, 0); if (fd < 0) { - goto err; + perror("socket"); + return -1; } + qemu_set_nonblock(fd); =20 + connected =3D 0; + for(;;) { + ret =3D connect(fd, (struct sockaddr *)&saddr, sizeof(saddr)); + if (ret < 0) { + if (errno =3D=3D EINTR || errno =3D=3D EWOULDBLOCK) { + /* continue */ + } else if (errno =3D=3D EINPROGRESS || + errno =3D=3D EALREADY || + errno =3D=3D EINVAL) { + break; + } else { + perror("connect"); + closesocket(fd); + return -1; + } + } else { + connected =3D 1; + break; + } + } + s =3D net_socket_fd_init(peer, model, name, fd, connected); + if (!s) + return -1; + snprintf(s->nc.info_str, sizeof(s->nc.info_str), + "socket: connect to %s:%d", + inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); return 0; - -err: - error_report_err(local_error); - socket_connect_data_free(c); - return -1; } =20 static int net_socket_mcast_init(NetClientState *peer, --=20 2.7.4