Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1495797727-16695-1-git-send-email-zhangchen.fnst@cn.fujitsu.com
Subject: [Qemu-devel] [PATCH V2 0/3] COLO-compare: Make COLO-compare support remote COLO-frame
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/19feea44a3f4010645a1b829b504481f1b574b9a.1495797845.git.maozy.fnst@cn.fujitsu.com -> patchew/19feea44a3f4010645a1b829b504481f1b574b9a.1495797845.git.maozy.fnst@cn.fujitsu.com
Switched to a new branch 'test'
ac41f91 COLO-compare: Add remote initialization and checkpoint notification
a0a428f COLO-compare: Add remote checkpoint notify chardev socket handler frame
e976476 COLO-compare: Add new parameter for communicate with remote colo-frame
=== OUTPUT BEGIN ===
Checking PATCH 1/3: COLO-compare: Add new parameter for communicate with remote colo-frame...
Checking PATCH 2/3: COLO-compare: Add remote checkpoint notify chardev socket handler frame...
WARNING: line over 80 characters
#52: FILE: net/colo-compare.c:607:
+ compare_pri_chr_in, NULL, s, s->worker_context, true);
WARNING: line over 80 characters
#55: FILE: net/colo-compare.c:609:
+ compare_sec_chr_in, NULL, s, s->worker_context, true);
WARNING: line over 80 characters
#57: FILE: net/colo-compare.c:611:
+ compare_notify_chr, NULL, s, s->worker_context, true);
ERROR: g_free(NULL) is safe this check is probably not required
#104: FILE: net/colo-compare.c:875:
+ if (s->notify_dev) {
+ g_free(s->notify_dev);
total: 1 errors, 3 warnings, 86 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/3: COLO-compare: Add remote initialization and checkpoint notification...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org