From nobody Mon Feb 9 01:34:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 149519363528998.2032859646747; Fri, 19 May 2017 04:33:55 -0700 (PDT) Received: from localhost ([::1]:57979 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBgAL-0006cI-BJ for importer@patchew.org; Fri, 19 May 2017 07:33:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dBfyK-0004MI-E5 for qemu-devel@nongnu.org; Fri, 19 May 2017 07:21:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dBfyJ-0000wr-Jg for qemu-devel@nongnu.org; Fri, 19 May 2017 07:21:28 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:32775) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dBfyJ-0000wU-Cu for qemu-devel@nongnu.org; Fri, 19 May 2017 07:21:27 -0400 Received: by mail-wm0-x243.google.com with SMTP id b84so1792395wmh.0 for ; Fri, 19 May 2017 04:21:27 -0700 (PDT) Received: from 640k.lan (94-39-157-43.adsl-ull.clienti.tiscali.it. [94.39.157.43]) by smtp.gmail.com with ESMTPSA id v65sm2640095wmv.5.2017.05.19.04.21.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 May 2017 04:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=TZMqk6n7j+WhSqyyd48UWmTami0aU/3mA9UHgvRN250=; b=Nv6JA5Agm+JMAZTvq5SbcWPwbds3zj/px0JWwjs1dANsNWZONdq/jQuJQ4o5e6lQTu 44T6aFeZ/ES5uUTXBo+LbQDm9X0zB2nJKrD2Z9gCREsoH8esmonJdiIKm1/6GJMW/kcq nyWGhJewSXukD3k/u8E+39sSHOW063RB9zmKjdrpHdKI3pPUm8LzJFeUYGjZuGSnt1rZ WUhwkHGtt/hOMvY69r3n1Fn16R5qeJo4Bp+r6Ky6VPNvdCpQXg6MGqw96EcULnNj/8An JUXit1kVwnp7W0iyBs8qV/GwgPXtfFYomd4wz5iDi1UMx+nuiqPxNI58lgOf6M1Z5Zpw XmBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=TZMqk6n7j+WhSqyyd48UWmTami0aU/3mA9UHgvRN250=; b=DOvpfdtRxhqIfqqqh5ZN0c46WLzOYloEv73rZvBL9mVOKZV6jTzYXVsY+ye2lsT1Dy HuEt5QYa1GsfU4v2if7xWl2eS+F1pUCg0DIBfBlDNroqcQZWEnaZHqNQnBXjB7tArvxW sMJIA3ZfRNmBPATRwHQQo8n9odzgtOHsnTMcdrTqxToYk/eilQ7cGrxPgDZ5fMDR5nU+ m5rdhbiTo9p1W5SbEWtsn8JYOYkQZBzrhCwe20tyjllomjKwE9vZCzj8O21aBNuqXMhK i6dxOhjibT1mK3Ta5cnFOLRgtEoyr+33qvgE2zuSAUz9CagjyTziBIIHwF5Tda1RVE7r Vi2Q== X-Gm-Message-State: AODbwcDeoFIgDdCMiRRk10XjILfDCAt/Nd0iBQxAEa03N73eOo51RTkr hf/+3qliIdRF4YvAwfs= X-Received: by 10.28.220.138 with SMTP id t132mr6639288wmg.140.1495192886209; Fri, 19 May 2017 04:21:26 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 19 May 2017 13:21:01 +0200 Message-Id: <1495192872-27667-10-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1495192872-27667-1-git-send-email-pbonzini@redhat.com> References: <1495192872-27667-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] [PULL 09/20] Check the return value of fcntl in qemu_set_cloexec X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, Stefano Stabellini , groug@kaod.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Stefano Stabellini Assert that the return value is not an error. This issue was found by Coverity. CID: 1374831 Signed-off-by: Stefano Stabellini CC: groug@kaod.org CC: pbonzini@redhat.com CC: Eric Blake Message-Id: <1494356693-13190-2-git-send-email-sstabellini@kernel.org> Signed-off-by: Paolo Bonzini --- util/oslib-posix.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index 4d9189e..16894ad 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -182,7 +182,9 @@ void qemu_set_cloexec(int fd) { int f; f =3D fcntl(fd, F_GETFD); - fcntl(fd, F_SETFD, f | FD_CLOEXEC); + assert(f !=3D -1); + f =3D fcntl(fd, F_SETFD, f | FD_CLOEXEC); + assert(f !=3D -1); } =20 /* --=20 1.8.3.1