From nobody Mon Feb 9 19:54:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1494588882314985.9153286598457; Fri, 12 May 2017 04:34:42 -0700 (PDT) Received: from localhost ([::1]:52993 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d98qH-0004kf-2U for importer@patchew.org; Fri, 12 May 2017 07:34:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d98oM-0003Xk-8d for qemu-devel@nongnu.org; Fri, 12 May 2017 07:32:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d98oJ-0000ty-1q for qemu-devel@nongnu.org; Fri, 12 May 2017 07:32:42 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:19970) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d98oI-0000ix-RU for qemu-devel@nongnu.org; Fri, 12 May 2017 07:32:38 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OPU00JR881ZQU80@mailout3.w1.samsung.com> for qemu-devel@nongnu.org; Fri, 12 May 2017 12:32:23 +0100 (BST) Received: from eusmges2.samsung.com (unknown [203.254.199.241]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20170512113223eucas1p111558ca3ff6df67eb8eb283e612fe787~92IscqFSC2798327983eucas1p1w; Fri, 12 May 2017 11:32:23 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2.samsung.com (EUCPMTA) with SMTP id 4C.9A.04459.74D95195; Fri, 12 May 2017 12:32:23 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20170512113222eucas1p218e8147a2c7d5c7ce9cbaf3d376b1332~92Ir3ytts0445604456eucas1p29; Fri, 12 May 2017 11:32:22 +0000 (GMT) Received: from eusync2.samsung.com ( [203.254.199.212]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id E9.A1.20206.66D95195; Fri, 12 May 2017 12:32:54 +0100 (BST) Received: from aperevalov-ubuntu.rnd.samsung.ru ([106.109.129.199]) by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OPU0053K81CCS30@eusync2.samsung.com>; Fri, 12 May 2017 12:32:22 +0100 (BST) X-AuditID: cbfec7f1-f796e6d00000116b-68-59159d47f6d3 From: Alexey Perevalov To: qemu-devel@nongnu.org Date: Fri, 12 May 2017 14:31:42 +0300 Message-id: <1494588703-9076-9-git-send-email-a.perevalov@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1494588703-9076-1-git-send-email-a.perevalov@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsWy7djP87ruc0UjDRbsZ7OYe/c8i0Xvtnvs Flfaf7JbbNn/jd3ieO8OFgdWjyfXNjN5vN93lc2jb8sqxgDmKC6blNSczLLUIn27BK6MbYuN CybZVSy+fYitgfGaQRcjJ4eEgInEh/657BC2mMSFe+vZuhi5OIQEljJK/NnSwwrhfGaUeDHt KytMx5U985ggEssYJa4vPsAC4XQzSUzoWMjcxcjBwSZgILHvni1Ig4iApMTvrtPMIDazQKzE 2+vX2EBsYYEQibVXVoCtZhFQldg64Q5YnFfATeLcw1fMEMvkJE4emwy2mFPAXeLDmuWMILsk BK6zSayfuYcRZJeEgKzEpgNQ9S4S019+ZYGwhSVeHd8C9ZqMxOXJ3SwQve2MEt07O1khnAmM Emem/4Wqspc4dfMqE8SlfBKTtk1nhljAK9HRJgRheki8XBgIUe0ocWXie2hwzWKUWHikh3kC o8wCRoZVjCKppcW56anFRnrFibnFpXnpesn5uZsYgZF5+t/xjzsY35+wOsQowMGoxMMrUSUS KcSaWFZcmXuIUYKDWUmEd0W8aKQQb0piZVVqUX58UWlOavEhRmkOFiVxXq5T1yKEBNITS1Kz U1MLUotgskwcnFINjHIyRm+11A8mhbc5PnSc61p+9aa1mLroB93ep1u6lLWLV3zz3uBUGtgw T/HTUpbFjNvNZyw4c1+cY1diWPrfNVoC2+d2nulYefMw9+v7kSfXzQgTrJ5Zujq/ge1aF5PI jJnndxqf8xU7ZMWmHrphNqvF3BVfZLdv/cZh9mWRhdHW2zMfmzBtslRiKc5INNRiLipOBAAm e+vJyAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMLMWRmVeSWpSXmKPExsVy+t/xK7ppc0UjDZpuqVrMvXuexaJ32z12 iyvtP9kttuz/xm5xvHcHiwOrx5Nrm5k83u+7yubRt2UVYwBzlJtNRmpiSmqRQmpecn5KZl66 rVJoiJuuhZJCXmJuqq1ShK5vSJCSQlliTimQZ2SABhycA9yDlfTtEtwyti02LphkV7H49iG2 BsZrBl2MnBwSAiYSV/bMY4KwxSQu3FvP1sXIxSEksIRRovPlVFYIp5dJ4u6h/YxdjBwcbAIG Evvu2YI0iAhISvzuOs0MYjMLxEpcmvCCDcQWFgiRWHtlBTuIzSKgKrF1wh2wOK+Am8S5h6+Y IZbJSZw8NpkVxOYUcJf4sGY52HghoJq5/2InMPIuYGRYxSiSWlqcm55bbKRXnJhbXJqXrpec n7uJERig24793LKDsetd8CFGAQ5GJR5eiSqRSCHWxLLiytxDjBIczEoivCviRSOFeFMSK6tS i/Lji0pzUosPMZoC3TSRWUo0OR8YPXkl8YYmhuaWhkbGFhbmRkZK4rxTP1wJFxJITyxJzU5N LUgtgulj4uCUamBMDNfxZry7/M62R25T7qwwXxI+PUH26runPfWmBlyiuYu2rP9cuyHkT9aD 5LhLzPnKy7XiBdyim7kbmC0inh5o3S3Kmi40+cLNHw72c1qefLBQdPt1TODpvZ8PLi1+f1Kj +nzM3F65yeHxWhKqJxaLhN/Le5k4P5Cd4VvbzFU3ePNWfi9u+lKoxFKckWioxVxUnAgApIkR JWYCAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170512113222eucas1p218e8147a2c7d5c7ce9cbaf3d376b1332 X-Msg-Generator: CA X-Sender-IP: 182.198.249.180 X-Local-Sender: =?UTF-8?B?QWxleGV5IFBlcmV2YWxvdhtTUlItVmlydHVhbGl6YXRpb24g?= =?UTF-8?B?TGFiG+yCvOyEseyghOyekBtTZW5pb3IgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?QWxleGV5IFBlcmV2YWxvdhtTUlItVmlydHVhbGl6YXRpb24g?= =?UTF-8?B?TGFiG1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0NJU0hRG0MxMEdEMDFHRDAxMDE1NA==?= CMS-TYPE: 201P X-HopCount: 7 X-CMS-RootMailID: 20170512113222eucas1p218e8147a2c7d5c7ce9cbaf3d376b1332 X-RootMTR: 20170512113222eucas1p218e8147a2c7d5c7ce9cbaf3d376b1332 References: <1494588703-9076-1-git-send-email-a.perevalov@samsung.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 210.118.77.13 Subject: [Qemu-devel] [PATCH V4 8/9] migration: add postcopy total blocktime into query-migrate X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: i.maximets@samsung.com, dgilbert@redhat.com, peterx@redhat.com, a.perevalov@samsung.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Postcopy total blocktime is available on destination side only. But query-migrate was possible only for source. This patch adds ability to call query-migrate on destination. To distinguish src/dst, state of the MigrationState is using, query-migrate prepares MigrationInfo for source machine only in case of migration's state is diffe= rent than MIGRATION_STATUS_NONE. To be able to see postcopy blocktime, need to request postcopy-blocktime capability. The query-migrate command will show following sample result: {"return": "postcopy_vcpu_blocktime": [115, 100], "status": "completed", "postcopy_blocktime": 100 }} postcopy_vcpu_blocktime contains list, where the first item is the first vCPU in QEMU. Signed-off-by: Alexey Perevalov --- include/migration/migration.h | 4 +++ migration/migration.c | 47 ++++++++++++++++++++++++++++-- migration/postcopy-ram.c | 68 +++++++++++++++++++++++++++++++++++++++= ++++ migration/trace-events | 1 + qapi-schema.json | 6 +++- 5 files changed, 122 insertions(+), 4 deletions(-) diff --git a/include/migration/migration.h b/include/migration/migration.h index 3f34920..3e5aee7 100644 --- a/include/migration/migration.h +++ b/include/migration/migration.h @@ -135,6 +135,10 @@ struct MigrationIncomingState { =20 MigrationIncomingState *migration_incoming_get_current(void); void migration_incoming_state_destroy(void); +/* + * Functions to work with blocktime context + */ +void fill_destination_postcopy_migration_info(MigrationInfo *info); =20 struct MigrationState { diff --git a/migration/migration.c b/migration/migration.c index b0af75f..605aab2 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -666,9 +666,15 @@ static void populate_ram_info(MigrationInfo *info, Mig= rationState *s) } } =20 -MigrationInfo *qmp_query_migrate(Error **errp) +/* TODO improve this assumption */ +static bool is_source_migration(void) +{ + MigrationState *ms =3D migrate_get_current(); + return ms->state !=3D MIGRATION_STATUS_NONE; +} + +static void fill_source_migration_info(MigrationInfo *info) { - MigrationInfo *info =3D g_malloc0(sizeof(*info)); MigrationState *s =3D migrate_get_current(); =20 switch (s->state) { @@ -759,10 +765,45 @@ MigrationInfo *qmp_query_migrate(Error **errp) break; } info->status =3D s->state; +} + +static void fill_destination_migration_info(MigrationInfo *info) +{ + MigrationIncomingState *mis =3D migration_incoming_get_current(); =20 - return info; + switch (mis->state) { + case MIGRATION_STATUS_NONE: + break; + case MIGRATION_STATUS_SETUP: + case MIGRATION_STATUS_CANCELLING: + case MIGRATION_STATUS_CANCELLED: + case MIGRATION_STATUS_ACTIVE: + case MIGRATION_STATUS_POSTCOPY_ACTIVE: + case MIGRATION_STATUS_FAILED: + case MIGRATION_STATUS_COLO: + info->has_status =3D true; + break; + case MIGRATION_STATUS_COMPLETED: + info->has_status =3D true; + fill_destination_postcopy_migration_info(info); + break; + } + info->status =3D mis->state; } =20 +MigrationInfo *qmp_query_migrate(Error **errp) +{ + MigrationInfo *info =3D g_malloc0(sizeof(*info)); + + if (is_source_migration()) { + fill_source_migration_info(info); + } else { + fill_destination_migration_info(info); + } + + return info; + } + void qmp_migrate_set_capabilities(MigrationCapabilityStatusList *params, Error **errp) { diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index db95747..ced4b5a 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -128,6 +128,71 @@ static struct PostcopyBlocktimeContext *blocktime_cont= ext_new(void) return ctx; } =20 +static int64List *get_vcpu_blocktime_list(PostcopyBlocktimeContext *ctx) +{ + int64List *list =3D NULL, *entry =3D NULL; + int i; + + for (i =3D smp_cpus - 1; i >=3D 0; i--) { + entry =3D g_new0(int64List, 1); + entry->value =3D ctx->vcpu_blocktime[i]; + entry->next =3D list; + list =3D entry; + } + + return list; +} + +/* + * This function just provide calculated blocktime per cpu and trace it. + * Total blocktime is calculated in mark_postcopy_blocktime_end. + * + * + * Assume we have 3 CPU + * + * S1 E1 S1 E1 + * -----***********------------xxx***************------------------------>= CPU1 + * + * S2 E2 + * ------------****************xxx--------------------------------------->= CPU2 + * + * S3 E3 + * ------------------------****xxx********------------------------------->= CPU3 + * + * We have sequence S1,S2,E1,S3,S1,E2,E3,E1 + * S2,E1 - doesn't match condition due to sequence S1,S2,E1 doesn't includ= e CPU3 + * S3,S1,E2 - sequence includes all CPUs, in this case overlap will be S1,= E2 - + * it's a part of total blocktime. + * S1 - here is last_begin + * Legend of the picture is following: + * * - means blocktime per vCPU + * x - means overlapped blocktime (total blocktime) + */ +void fill_destination_postcopy_migration_info(MigrationInfo *info) +{ + MigrationIncomingState *mis =3D migration_incoming_get_current(); + + if (!mis->blocktime_ctx) { + return; + } + + info->has_postcopy_blocktime =3D true; + info->postcopy_blocktime =3D mis->blocktime_ctx->total_blocktime; + info->has_postcopy_vcpu_blocktime =3D true; + info->postcopy_vcpu_blocktime =3D get_vcpu_blocktime_list(mis->blockti= me_ctx); +} + +static uint64_t get_postcopy_total_blocktime(void) +{ + MigrationIncomingState *mis =3D migration_incoming_get_current(); + + if (!mis->blocktime_ctx) { + return 0; + } + + return mis->blocktime_ctx->total_blocktime; +} + /* * Check userfault fd features, to request only supported features in * future. @@ -461,6 +526,9 @@ int postcopy_ram_incoming_cleanup(MigrationIncomingStat= e *mis) } =20 postcopy_state_set(POSTCOPY_INCOMING_END); + /* here should be blocktime receiving back operation */ + trace_postcopy_ram_incoming_cleanup_blocktime( + get_postcopy_total_blocktime()); migrate_send_rp_shut(mis, qemu_file_get_error(mis->from_src_file) !=3D= 0); =20 if (mis->postcopy_tmp_page) { diff --git a/migration/trace-events b/migration/trace-events index 7bdadbb..55a3b6e 100644 --- a/migration/trace-events +++ b/migration/trace-events @@ -195,6 +195,7 @@ postcopy_ram_incoming_cleanup_closeuf(void) "" postcopy_ram_incoming_cleanup_entry(void) "" postcopy_ram_incoming_cleanup_exit(void) "" postcopy_ram_incoming_cleanup_join(void) "" +postcopy_ram_incoming_cleanup_blocktime(uint64_t total) "total blocktime %= " PRIu64 save_xbzrle_page_skipping(void) "" save_xbzrle_page_overflow(void) "" ram_save_iterate_big_wait(uint64_t milliconds, int iterations) "big wait: = %" PRIu64 " milliseconds, %d iterations" diff --git a/qapi-schema.json b/qapi-schema.json index df9f801..92df9bb 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -712,6 +712,8 @@ # @status is 'failed'. Clients should not attempt to parse the # error strings. (Since 2.7) # +# @postcopy_vcpu_blocktime: list of the postcopy blocktime per vCPU (Since= 2.9) +# # Since: 0.14.0 ## { 'struct': 'MigrationInfo', @@ -723,7 +725,9 @@ '*downtime': 'int', '*setup-time': 'int', '*cpu-throttle-percentage': 'int', - '*error-desc': 'str'} } + '*error-desc': 'str', + '*postcopy_blocktime' : 'int64', + '*postcopy_vcpu_blocktime': ['int64']} } =20 ## # @query-migrate: --=20 1.8.3.1