From nobody Fri Apr 19 18:51:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1493719662712997.7116996134054; Tue, 2 May 2017 03:07:42 -0700 (PDT) Received: from localhost ([::1]:57840 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5Uia-00069A-F3 for importer@patchew.org; Tue, 02 May 2017 06:07:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5Uhn-0005mp-1P for qemu-devel@nongnu.org; Tue, 02 May 2017 06:06:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5Uhh-0007jT-Vy for qemu-devel@nongnu.org; Tue, 02 May 2017 06:06:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33562) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d5Uhh-0007ik-QZ for qemu-devel@nongnu.org; Tue, 02 May 2017 06:06:45 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 75C73EA7BC; Tue, 2 May 2017 10:06:44 +0000 (UTC) Received: from thh440s.redhat.com (ovpn-116-104.ams2.redhat.com [10.36.116.104]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7B6FA17171; Tue, 2 May 2017 10:06:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 75C73EA7BC Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=thuth@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 75C73EA7BC From: Thomas Huth To: qemu-devel@nongnu.org Date: Tue, 2 May 2017 12:06:40 +0200 Message-Id: <1493719600-30853-1-git-send-email-thuth@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 02 May 2017 10:06:44 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH] Deprecate '-enable-kvm' and '-enable-hax' in favour of '-accel' X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Vincent Palatin Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The '-enable-...' option do not make too much sense: They do not allow additional parameters, using '-accel xxx' is shorter than '-enable-xxx' and we're also inconsistent here, since there is no '-enable-xen' option available. So let's try to convince the users to use '-accel xxx' instead. Signed-off-by: Thomas Huth --- qemu-options.hx | 5 +++-- vl.c | 4 ++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index c7b1d2d..eb33286 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -3367,7 +3367,8 @@ STEXI @item -enable-kvm @findex -enable-kvm Enable KVM full virtualization support. This option is only available -if KVM support is enabled when compiling. +if KVM support is enabled when compiling. Note: This option is deprecated, +please use @code{-accel kvm} instead. ETEXI =20 DEF("enable-hax", 0, QEMU_OPTION_enable_hax, \ @@ -3378,7 +3379,7 @@ STEXI Enable HAX (Hardware-based Acceleration eXecution) support. This option is only available if HAX support is enabled when compiling. HAX is only applicable to MAC and Windows platform, and thus does not conflict with -KVM. +KVM. Note: This option is deprecated, please use @code{-accel hax} instead. ETEXI =20 DEF("xen-domid", HAS_ARG, QEMU_OPTION_xen_domid, diff --git a/vl.c b/vl.c index d5e88fb..d5ec87e 100644 --- a/vl.c +++ b/vl.c @@ -3690,10 +3690,14 @@ int main(int argc, char **argv, char **envp) } break; case QEMU_OPTION_enable_kvm: + error_report("'-enable-kvm' is depreacted, please use " + "'-accel kvm' instead"); olist =3D qemu_find_opts("machine"); qemu_opts_parse_noisily(olist, "accel=3Dkvm", false); break; case QEMU_OPTION_enable_hax: + error_report("'-enable-hax' is depreacted, please use " + "'-accel hax' instead"); olist =3D qemu_find_opts("machine"); qemu_opts_parse_noisily(olist, "accel=3Dhax", false); break; --=20 1.8.3.1