From nobody Tue Feb 10 06:43:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1492763613449898.115204707315; Fri, 21 Apr 2017 01:33:33 -0700 (PDT) Received: from localhost ([::1]:57866 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1U0R-0002l9-TO for importer@patchew.org; Fri, 21 Apr 2017 04:33:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1TwY-0008UP-Lx for qemu-devel@nongnu.org; Fri, 21 Apr 2017 04:29:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d1TwV-0001Yc-2e for qemu-devel@nongnu.org; Fri, 21 Apr 2017 04:29:30 -0400 Received: from chuckie.co.uk ([82.165.15.123]:50169 helo=s16892447.onlinehome-server.info) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d1TwU-0001YU-Rc for qemu-devel@nongnu.org; Fri, 21 Apr 2017 04:29:27 -0400 Received: from host86-191-119-77.range86-191.btcentralplus.com ([86.191.119.77] helo=kentang.home) by s16892447.onlinehome-server.info with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1d1TwS-0002g4-Hz; Fri, 21 Apr 2017 09:29:25 +0100 From: Mark Cave-Ayland To: qemu-devel@nongnu.org, kraxel@redhat.com Date: Fri, 21 Apr 2017 09:28:42 +0100 Message-Id: <1492763327-12742-9-git-send-email-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1492763327-12742-1-git-send-email-mark.cave-ayland@ilande.co.uk> References: <1492763327-12742-1-git-send-email-mark.cave-ayland@ilande.co.uk> X-SA-Exim-Connect-IP: 86.191.119.77 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk X-SA-Exim-Version: 4.2.1 (built Sun, 08 Jan 2012 02:45:44 +0000) X-SA-Exim-Scanned: Yes (on s16892447.onlinehome-server.info) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 82.165.15.123 Subject: [Qemu-devel] [PATCH v2 08/13] tcx: remove page24 and cpage from tcx24_update_display() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Cave-Ayland Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Since all of the tcx_*_dirty() functions now calculate the 24-bit and cplane offsets themselves from the base address, these variables are no longer needed. Signed-off-by: Mark Cave-Ayland Reviewed-by: Gerd Hoffmann --- hw/display/tcx.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index e9056e0..4f4f03f 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -430,7 +430,7 @@ static void tcx24_update_display(void *opaque) { TCXState *ts =3D opaque; DisplaySurface *surface =3D qemu_console_surface(ts->con); - ram_addr_t page, page_min, page_max, cpage, page24; + ram_addr_t page, page_min, page_max; int y, y_start, dd, ds; uint8_t *d, *s; uint32_t *cptr, *s24; @@ -440,8 +440,6 @@ static void tcx24_update_display(void *opaque) } =20 page =3D 0; - page24 =3D ts->vram24_offset; - cpage =3D ts->cplane_offset; y_start =3D -1; page_min =3D -1; page_max =3D 0; @@ -453,8 +451,7 @@ static void tcx24_update_display(void *opaque) ds =3D 1024; =20 memory_region_sync_dirty_bitmap(&ts->vram_mem); - for (y =3D 0; y < ts->height; page +=3D TARGET_PAGE_SIZE, - page24 +=3D TARGET_PAGE_SIZE, cpage +=3D TARGET_PAGE_SIZE) { + for (y =3D 0; y < ts->height; page +=3D TARGET_PAGE_SIZE) { if (tcx_check_dirty(ts, page, TARGET_PAGE_SIZE)) { if (y_start < 0) y_start =3D y; --=20 1.7.10.4