From nobody Tue Feb 10 13:36:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1491381872288688.1373050843672; Wed, 5 Apr 2017 01:44:32 -0700 (PDT) Received: from localhost ([::1]:39356 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvgYJ-0000cy-8S for importer@patchew.org; Wed, 05 Apr 2017 04:44:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvgWB-0007iI-1X for qemu-devel@nongnu.org; Wed, 05 Apr 2017 04:42:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvgWA-0008T8-4b for qemu-devel@nongnu.org; Wed, 05 Apr 2017 04:42:19 -0400 Received: from chuckie.co.uk ([82.165.15.123]:42865 helo=s16892447.onlinehome-server.info) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cvgW9-0008ST-Tb for qemu-devel@nongnu.org; Wed, 05 Apr 2017 04:42:18 -0400 Received: from host86-184-243-30.range86-184.btcentralplus.com ([86.184.243.30] helo=kentang.home) by s16892447.onlinehome-server.info with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1cvgQ8-0001ob-5N; Wed, 05 Apr 2017 09:36:05 +0100 From: Mark Cave-Ayland To: kraxel@redhat.com, qemu-devel@nongnu.org Date: Wed, 5 Apr 2017 09:35:25 +0100 Message-Id: <1491381329-3995-11-git-send-email-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1491381329-3995-1-git-send-email-mark.cave-ayland@ilande.co.uk> References: <1491381329-3995-1-git-send-email-mark.cave-ayland@ilande.co.uk> X-SA-Exim-Connect-IP: 86.184.243.30 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk X-SA-Exim-Version: 4.2.1 (built Sun, 08 Jan 2012 02:45:44 +0000) X-SA-Exim-Scanned: Yes (on s16892447.onlinehome-server.info) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 82.165.15.123 Subject: [Qemu-devel] [PATCH 10/14] tcx: remove TARGET_PAGE_SIZE from tcx_update_display() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Now that page alignment is handled by the memory API, there is no need to duplicate the code 4 times (4 * 1024 =3D=3D 4096 =3D=3D TARGET_PAGE_SIZE). Signed-off-by: Mark Cave-Ayland --- hw/display/tcx.c | 36 ++++-------------------------------- 1 file changed, 4 insertions(+), 32 deletions(-) diff --git a/hw/display/tcx.c b/hw/display/tcx.c index 4f4f03f..14a17fe 100644 --- a/hw/display/tcx.c +++ b/hw/display/tcx.c @@ -363,8 +363,8 @@ static void tcx_update_display(void *opaque) } =20 memory_region_sync_dirty_bitmap(&ts->vram_mem); - for (y =3D 0; y < ts->height; page +=3D TARGET_PAGE_SIZE) { - if (tcx_check_dirty(ts, page, TARGET_PAGE_SIZE)) { + for (y =3D 0; y < ts->height; y++, page +=3D ds) { + if (tcx_check_dirty(ts, page, ds)) { if (y_start < 0) y_start =3D y; if (page < page_min) @@ -376,33 +376,6 @@ static void tcx_update_display(void *opaque) if (y >=3D ts->cursy && y < ts->cursy + 32 && ts->cursx < ts->= width) { fc(ts, d, y, ts->width); } - d +=3D dd; - s +=3D ds; - y++; - - f(ts, d, s, ts->width); - if (y >=3D ts->cursy && y < ts->cursy + 32 && ts->cursx < ts->= width) { - fc(ts, d, y, ts->width); - } - d +=3D dd; - s +=3D ds; - y++; - - f(ts, d, s, ts->width); - if (y >=3D ts->cursy && y < ts->cursy + 32 && ts->cursx < ts->= width) { - fc(ts, d, y, ts->width); - } - d +=3D dd; - s +=3D ds; - y++; - - f(ts, d, s, ts->width); - if (y >=3D ts->cursy && y < ts->cursy + 32 && ts->cursx < ts->= width) { - fc(ts, d, y, ts->width); - } - d +=3D dd; - s +=3D ds; - y++; } else { if (y_start >=3D 0) { /* flush to display */ @@ -410,10 +383,9 @@ static void tcx_update_display(void *opaque) ts->width, y - y_start); y_start =3D -1; } - d +=3D dd * 4; - s +=3D ds * 4; - y +=3D 4; } + s +=3D ds; + d +=3D dd; } if (y_start >=3D 0) { /* flush to display */ --=20 1.7.10.4