From nobody Mon May 6 17:11:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 14910283705041013.4324131731864; Fri, 31 Mar 2017 23:32:50 -0700 (PDT) Received: from localhost ([::1]:44111 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cuCaf-0006jW-1u for importer@patchew.org; Sat, 01 Apr 2017 02:32:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cu8nS-0002ja-5G for qemu-devel@nongnu.org; Fri, 31 Mar 2017 22:29:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cu8nO-0004W9-Vt for qemu-devel@nongnu.org; Fri, 31 Mar 2017 22:29:46 -0400 Received: from [45.249.212.189] (port=2893 helo=dggrg03-dlp.huawei.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1cu8nO-0004T0-Hl; Fri, 31 Mar 2017 22:29:42 -0400 Received: from 172.30.72.55 (EHLO DGGEML403-HUB.china.huawei.com) ([172.30.72.55]) by dggrg03-dlp.huawei.com (MOS 4.4.6-GA FastPath queued) with ESMTP id AKZ54866; Sat, 01 Apr 2017 10:07:36 +0800 (CST) Received: from huawei.com (10.175.104.147) by DGGEML403-HUB.china.huawei.com (10.3.17.33) with Microsoft SMTP Server id 14.3.301.0; Sat, 1 Apr 2017 10:07:26 +0800 From: yaolujing To: , , Date: Sat, 1 Apr 2017 08:15:09 +0800 Message-ID: <1491005709-29989-1-git-send-email-yaolujing@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.104.147] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.58DF0B68.0071, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 3c44fa2a6f33dec88188c923aa8dad7e X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-Received-From: 45.249.212.189 X-Mailman-Approved-At: Sat, 01 Apr 2017 02:30:38 -0400 Subject: [Qemu-devel] [PATCH] nbd: fix memory leak on socket_connect failed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: xieyingtai@huawei.com, qemu-block@nongnu.org, subo7@huawei.com, zhangshuai13@huawei.com, eric.fangyi@huawei.com, qemu-devel@nongnu.org, yaolujing@huawei.com, wangjie88@huawei.com, sochin.jiang@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: y00357587 When TCP connection fails between nbd server and client, the local var, sioc, memory leak. This patch fixes the memory leak. Signed-off-by: y00357587 Reviewed-by: Eric Blake --- block/nbd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/nbd.c b/block/nbd.c index 35f24be..102285e 100644 --- a/block/nbd.c +++ b/block/nbd.c @@ -313,6 +313,7 @@ static QIOChannelSocket *nbd_establish_connection(Socke= tAddress *saddr, saddr, &local_err); if (local_err) { + object_unref(OBJECT(sioc)); error_propagate(errp, local_err); return NULL; } --=20 1.8.3.1