From nobody Sat May 4 20:39:49 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; dkim=fail spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1490685648031106.18568783833905; Tue, 28 Mar 2017 00:20:48 -0700 (PDT) Received: from localhost ([::1]:50354 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cslQr-0007hV-Q2 for importer@patchew.org; Tue, 28 Mar 2017 03:20:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cslQ5-0007LV-5X for qemu-devel@nongnu.org; Tue, 28 Mar 2017 03:19:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cslQ0-00032m-8A for qemu-devel@nongnu.org; Tue, 28 Mar 2017 03:19:57 -0400 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:35972) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cslQ0-00032Z-25 for qemu-devel@nongnu.org; Tue, 28 Mar 2017 03:19:52 -0400 Received: by mail-pg0-x242.google.com with SMTP id 81so19139703pgh.3 for ; Tue, 28 Mar 2017 00:19:52 -0700 (PDT) Received: from qemu-HP-Pavilion-15-Notebook-PC.domain.name ([49.206.72.28]) by smtp.gmail.com with ESMTPSA id b70sm5160150pfc.100.2017.03.28.00.19.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 28 Mar 2017 00:19:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=R8aJTwqz39v5TP2klaNQ+ulU+l9/lgUlrWrdD4SVPeM=; b=CseejqcaaWVAvegfx+aic6PSS2gkQYBmn9Dgqy1YiHnYOkXURorOh/0mXJPIMpDdBq tNyo/dHTiPTLiLeq3mYaP4YwEMzalpw2JWdLtAetpobz3reRjsRyNrqQmcPVQDx7KW9T Zy/MgywYQ+xR6Xee8WejFr1I/ovVpuwiAutsawxOriCyd5+ljYWRxu3MuefcC78T4dRI O70AxUe0bxT+1/4Fh1R8L/yHD8ZwDwG9XPHM9/3J/roTg8ivYCS3NVzyK9byDamONr+t mGj+dBePIyrTjINWAek7ze/XJuSU/CngNrWKmg5rAfqGVkkw0RCpIVgnV5iQxtJLhkpa gjzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=R8aJTwqz39v5TP2klaNQ+ulU+l9/lgUlrWrdD4SVPeM=; b=J8AkUH8rHuOZT6sq41UYAhMp+K8cVwePW2SbL1/CnHLfpQNnrKDuR7CB7A2+Cw2EKx QQuFzeIwVPjPxGsaNGhj+9OXEb+9UFM/87F8blJQf0bxvy1ktoLdW8oAhOI+yrM7QUQQ iMAv3z6yhbXPjezhZoogBMYj7SRalbQyLHDQAAkpZoDWDxYYFo0mAJ/w/MxbuXqaqdPa V7HQzEiYb92Xnptf+s2qLX2rYX1bM5qNPs9giWDhcAadfwD+NUrUd5P5erc27Q6OzY1d IboRdTcfLlAm8HhfgkmszyYvhT9z/V5EtYdrXAQRjQcMLGKuu3FUmPrVzbCh4D3UAsHm 4HkQ== X-Gm-Message-State: AFeK/H1eD0lnSm65tVF9GlQkdbUZ4EXS8fucsGs/1p3+Z776rlesTuOU7hn2IvbsdXfj7Q== X-Received: by 10.99.158.2 with SMTP id s2mr22622625pgd.15.1490685591041; Tue, 28 Mar 2017 00:19:51 -0700 (PDT) From: Tejaswini To: qemu-devel@nongnu.org Date: Tue, 28 Mar 2017 12:49:43 +0530 Message-Id: <1490685583-16987-1-git-send-email-tejaswinipoluri3@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c05::242 Subject: [Qemu-devel] [PATCH] target-i386: fix "info lapic" segfault on isapc X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, ehabkost@redhat.com, Tejaswini Poluri , stefanha@redhat.com, pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_0 Z_629925259 SPT_0 From: Tejaswini Poluri Start QEMU with "qemu-system-x86_64 -nographic -M isapc -serial none-monitor stdio" and enter "info lapic" at the monitor prompt =E2=87=92 Segmentation fault Signed-off-by: Tejaswini Poluri --- target/i386/helper.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/target/i386/helper.c b/target/i386/helper.c index e2af340..f11cac6 100644 --- a/target/i386/helper.c +++ b/target/i386/helper.c @@ -326,6 +326,10 @@ void x86_cpu_dump_local_apic_state(CPUState *cs, FILE = *f, { X86CPU *cpu =3D X86_CPU(cs); APICCommonState *s =3D APIC_COMMON(cpu->apic_state); + if (!s) { + cpu_fprintf(f, "local apic state not available\n"); + return; + } uint32_t *lvt =3D s->lvt; =20 cpu_fprintf(f, "dumping local APIC state for CPU %-2u\n\n", --=20 2.7.4