From nobody Sun May 5 22:08:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489981062164307.3742393010234; Sun, 19 Mar 2017 20:37:42 -0700 (PDT) Received: from localhost ([::1]:59124 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpo8a-00042O-NY for importer@patchew.org; Sun, 19 Mar 2017 23:37:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpo7s-00041F-2g for qemu-devel@nongnu.org; Sun, 19 Mar 2017 23:36:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpo7r-000641-4p for qemu-devel@nongnu.org; Sun, 19 Mar 2017 23:36:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39328) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cpo7q-00063t-VD for qemu-devel@nongnu.org; Sun, 19 Mar 2017 23:36:55 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F21F24E4F2; Mon, 20 Mar 2017 03:36:54 +0000 (UTC) Received: from jason-ThinkPad-T450s.redhat.com (vpn1-6-119.pek2.redhat.com [10.72.6.119]) by smtp.corp.redhat.com (Postfix) with ESMTP id B25DF7837D; Mon, 20 Mar 2017 03:36:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com F21F24E4F2 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jasowang@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com F21F24E4F2 From: Jason Wang To: mst@redhat.com, peterx@redhat.com, qemu-devel@nongnu.org Date: Mon, 20 Mar 2017 11:36:38 +0800 Message-Id: <1489980999-5965-2-git-send-email-jasowang@redhat.com> In-Reply-To: <1489980999-5965-1-git-send-email-jasowang@redhat.com> References: <1489980999-5965-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 20 Mar 2017 03:36:55 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH fixup 1/2] intel_iommu: use the correct memory region for device IOTLB notification X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Jason Wang , Eduardo Habkost , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We have a specific memory region for DMAR now, so it's wrong to trigger the notifier with the root region. Cc: Michael S. Tsirkin Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Jason Wang Reviewed-by: Peter Xu --- hw/i386/intel_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 9b1ba1b..bc95304 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -1709,7 +1709,7 @@ static bool vtd_process_device_iotlb_desc(IntelIOMMUS= tate *s, entry.iova =3D addr; entry.perm =3D IOMMU_NONE; entry.translated_addr =3D 0; - memory_region_notify_iommu(entry.target_as->root, entry); + memory_region_notify_iommu(&vtd_dev_as->iommu, entry); =20 done: return true; --=20 2.7.4 From nobody Sun May 5 22:08:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489981143795446.85704980182254; Sun, 19 Mar 2017 20:39:03 -0700 (PDT) Received: from localhost ([::1]:59128 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpo9u-00053V-GB for importer@patchew.org; Sun, 19 Mar 2017 23:39:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpo7v-00043p-TX for qemu-devel@nongnu.org; Sun, 19 Mar 2017 23:37:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpo7u-00065i-HO for qemu-devel@nongnu.org; Sun, 19 Mar 2017 23:36:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35878) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cpo7u-00065W-8O for qemu-devel@nongnu.org; Sun, 19 Mar 2017 23:36:58 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3E4F7C054C4C for ; Mon, 20 Mar 2017 03:36:58 +0000 (UTC) Received: from jason-ThinkPad-T450s.redhat.com (vpn1-6-119.pek2.redhat.com [10.72.6.119]) by smtp.corp.redhat.com (Postfix) with ESMTP id CFD6978404; Mon, 20 Mar 2017 03:36:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3E4F7C054C4C Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jasowang@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3E4F7C054C4C From: Jason Wang To: mst@redhat.com, peterx@redhat.com, qemu-devel@nongnu.org Date: Mon, 20 Mar 2017 11:36:39 +0800 Message-Id: <1489980999-5965-3-git-send-email-jasowang@redhat.com> In-Reply-To: <1489980999-5965-1-git-send-email-jasowang@redhat.com> References: <1489980999-5965-1-git-send-email-jasowang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Mon, 20 Mar 2017 03:36:58 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH fixup 2/2] vhost: genearlize iommu memory region X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" We assumes the iommu_ops were attached to the root region of address space. This may not true for all kinds of IOMMU implementation. So fix this by not assume as->root has iommu_ops and: - register a memory listener to dma_as - during region_add, if it's a region of IOMMU, register a specific IOMMU notifier, and store all notifiers in a list - during region_del, compare and delete the IOMMU notifier This is a must for making vhost device IOTLB works for IOMMU other than intel ones. Signed-off-by: Jason Wang Reviewed-by: Peter Xu --- hw/virtio/vhost.c | 93 +++++++++++++++++++++++++++++++++++++------= ---- include/hw/virtio/vhost.h | 10 +++++ 2 files changed, 83 insertions(+), 20 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index ccf8b2e..45f75da 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -425,10 +425,8 @@ static inline void vhost_dev_log_resize(struct vhost_d= ev *dev, uint64_t size) static int vhost_dev_has_iommu(struct vhost_dev *dev) { VirtIODevice *vdev =3D dev->vdev; - AddressSpace *dma_as =3D vdev->dma_as; =20 - return memory_region_is_iommu(dma_as->root) && - virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM); + return virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM); } =20 static void *vhost_memory_map(struct vhost_dev *dev, hwaddr addr, @@ -720,6 +718,69 @@ static void vhost_region_del(MemoryListener *listener, } } =20 +static void vhost_iommu_unmap_notify(IOMMUNotifier *n, IOMMUTLBEntry *iotl= b) +{ + struct vhost_iommu *iommu =3D container_of(n, struct vhost_iommu, n); + struct vhost_dev *hdev =3D iommu->hdev; + + if (hdev->vhost_ops->vhost_invalidate_device_iotlb(hdev, + iotlb->iova, + iotlb->addr_mask + = 1)) { + error_report("Fail to invalidate device iotlb"); + } +} + +static void vhost_iommu_region_add(MemoryListener *listener, + MemoryRegionSection *section) +{ + struct vhost_dev *dev =3D container_of(listener, struct vhost_dev, + iommu_listener); + struct vhost_iommu *iommu; + Int128 llend; + + if (!memory_region_is_iommu(section->mr)) { + return; + } + + llend =3D int128_make64(section->offset_within_address_space); + llend =3D int128_add(llend, section->size); + llend =3D int128_sub(llend, int128_one()); + + iommu =3D g_malloc0(sizeof(*iommu)); + iommu->mr =3D section->mr; + iommu->hdev =3D dev; + iommu_notifier_init(&iommu->n, vhost_iommu_unmap_notify, + IOMMU_NOTIFIER_UNMAP, + section->offset_within_region, + int128_get64(llend)); + memory_region_register_iommu_notifier(section->mr, &iommu->n); + /* TODO: can replay help performance here? */ + QLIST_INSERT_HEAD(&dev->iommu_list, iommu, iommu_next); +} + +static void vhost_iommu_region_del(MemoryListener *listener, + MemoryRegionSection *section) +{ + struct vhost_dev *dev =3D container_of(listener, struct vhost_dev, + iommu_listener); + struct vhost_iommu *iommu; + + if (!memory_region_is_iommu(section->mr)) { + return; + } + + QLIST_FOREACH(iommu, &dev->iommu_list, iommu_next) { + if (iommu->mr =3D=3D section->mr && + iommu->n.start =3D=3D section->offset_within_region) { + memory_region_unregister_iommu_notifier(iommu->mr, + &iommu->n); + QLIST_REMOVE(iommu, iommu_next); + g_free(iommu); + break; + } + } +} + static void vhost_region_nop(MemoryListener *listener, MemoryRegionSection *section) { @@ -1161,17 +1222,6 @@ static void vhost_virtqueue_cleanup(struct vhost_vir= tqueue *vq) event_notifier_cleanup(&vq->masked_notifier); } =20 -static void vhost_iommu_unmap_notify(IOMMUNotifier *n, IOMMUTLBEntry *iotl= b) -{ - struct vhost_dev *hdev =3D container_of(n, struct vhost_dev, n); - - if (hdev->vhost_ops->vhost_invalidate_device_iotlb(hdev, - iotlb->iova, - iotlb->addr_mask + = 1)) { - error_report("Fail to invalidate device iotlb"); - } -} - int vhost_dev_init(struct vhost_dev *hdev, void *opaque, VhostBackendType backend_type, uint32_t busyloop_timeou= t) { @@ -1244,6 +1294,11 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opa= que, .priority =3D 10 }; =20 + hdev->iommu_listener =3D (MemoryListener) { + .region_add =3D vhost_iommu_region_add, + .region_del =3D vhost_iommu_region_del, + }; + iommu_notifier_init(&hdev->n, vhost_iommu_unmap_notify, IOMMU_NOTIFIER_UNMAP, 0, ~0ULL); =20 @@ -1454,9 +1509,8 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODev= ice *vdev) goto fail_features; } =20 - if (vhost_dev_has_iommu(hdev)) { - memory_region_register_iommu_notifier(vdev->dma_as->root, - &hdev->n); + if (true) { + memory_listener_register(&hdev->iommu_listener, vdev->dma_as); } =20 r =3D hdev->vhost_ops->vhost_set_mem_table(hdev, hdev->mem); @@ -1536,10 +1590,9 @@ void vhost_dev_stop(struct vhost_dev *hdev, VirtIODe= vice *vdev) hdev->vq_index + i); } =20 - if (vhost_dev_has_iommu(hdev)) { + if (true) { hdev->vhost_ops->vhost_set_iotlb_callback(hdev, false); - memory_region_unregister_iommu_notifier(vdev->dma_as->root, - &hdev->n); + memory_listener_unregister(&hdev->iommu_listener); } vhost_log_put(hdev, true); hdev->started =3D false; diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h index 52f633e..4d89dcd 100644 --- a/include/hw/virtio/vhost.h +++ b/include/hw/virtio/vhost.h @@ -37,10 +37,19 @@ struct vhost_log { vhost_log_chunk_t *log; }; =20 +struct vhost_dev; +struct vhost_iommu { + struct vhost_dev *hdev; + MemoryRegion *mr; + IOMMUNotifier n; + QLIST_ENTRY(vhost_iommu) iommu_next; +}; + struct vhost_memory; struct vhost_dev { VirtIODevice *vdev; MemoryListener memory_listener; + MemoryListener iommu_listener; struct vhost_memory *mem; int n_mem_sections; MemoryRegionSection *mem_sections; @@ -64,6 +73,7 @@ struct vhost_dev { void *opaque; struct vhost_log *log; QLIST_ENTRY(vhost_dev) entry; + QLIST_HEAD(,vhost_iommu) iommu_list; IOMMUNotifier n; }; =20 --=20 2.7.4