From nobody Thu May 2 08:36:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489662750030298.2835651445532; Thu, 16 Mar 2017 04:12:30 -0700 (PDT) Received: from localhost ([::1]:42598 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coTKV-0007Ej-GZ for importer@patchew.org; Thu, 16 Mar 2017 07:12:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coTK1-0007Ck-LY for qemu-devel@nongnu.org; Thu, 16 Mar 2017 07:11:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1coTJy-0002fb-IN for qemu-devel@nongnu.org; Thu, 16 Mar 2017 07:11:57 -0400 Received: from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:36333) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1coTJy-0002fE-C7 for qemu-devel@nongnu.org; Thu, 16 Mar 2017 07:11:54 -0400 Received: by mail-pf0-x243.google.com with SMTP id r137so1632089pfr.3 for ; Thu, 16 Mar 2017 04:11:54 -0700 (PDT) Received: from localhost.localdomain ([122.173.66.79]) by smtp.googlemail.com with ESMTPSA id h9sm9906694pfd.103.2017.03.16.04.11.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 16 Mar 2017 04:11:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=jze7InruBmvTM1pGtDEv13VVH5NpRQLCEhacPrQOHAw=; b=D7pJRsGmsE/0C8AqbEL6PXESjBv3LGZCOrfL0k/yUk8bsxkHwmKcVzn8GXEbXu00f7 WKe4Al1zdUB0w5AGnrzE/hkljyHOrAdGiITzqssk2AviTT4BGtHXIfIoz3oCuFv74X8o hEN1xlIImTOs7r5u03GS319M0ujbYA0qP18btDzsK2rotDpTUuBtchVl+q+WmQmBLLpI bZbcDDuV7FqFJ6lIo/VunJTjWMxZqqMAjEgDzT8LqvSeyta+yBq7hXqioeDGB7cg3ncd bdJzDOqop252cee/0z0NH0Lv6SbXe/by07K7twOhdC0ytSltIzcUHNSLN4Qjrff/O74Z 0bkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=jze7InruBmvTM1pGtDEv13VVH5NpRQLCEhacPrQOHAw=; b=nXUizaEgzeuP+ANGdxWEwSWvPlWvkPWKBLzajnA20n57JtCZlsNzpO0NVqip+EYvR1 g9ekdU1eepDmwKUyR3iKQXeUZ4HtrJoQoM7wAzLaAnJBW6FH+f54FDUwp2plgTOBPDcc lcYdSZlzxP/CqbXVfVIxMq8om3dU30PhnN0k5Xcrf44Fmb5ZRKSG2Kg4FpN5pfWaUtn0 4UinC8a/IFE2ZCNYukcpd09/t5QazML3yTUu5soLyOBQBdP+pC5dww4oWCyc2QIDwA03 40XRMg/XgRnkUcU186yuEi1M5HAF+zpQxitT0erf8XkvZnuPkkjU1wkAuHf6L7nFcGxE Y32A== X-Gm-Message-State: AFeK/H1DN6lYcwcomuBMIk/V/UExmQH2WZBvJjq3muYyvLmSNqCkaWK78ZXufTsgMXAVjQ== X-Received: by 10.99.184.18 with SMTP id p18mr9559531pge.20.1489662713483; Thu, 16 Mar 2017 04:11:53 -0700 (PDT) From: Anishka0107 To: qemu-devel@nongnu.org Date: Thu, 16 Mar 2017 11:11:33 +0530 Message-Id: <1489642893-4504-1-git-send-email-rimjhim0107@gmail.com> X-Mailer: git-send-email 2.5.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::243 Subject: [Qemu-devel] [PATCH v2] puv3: always compile-check debug printf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anishka0107 , jsnow@redhat.com, stefanha@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" To prevent bitrot of the format string of the debug statement, files w= ith conditional debug statements should ensure that printf is compiled alw= ays, and enclosed within if(0) statements and not in #ifdef. Signed-off-by: Anishka Gupta --- include/hw/unicore32/puv3.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/hw/unicore32/puv3.h b/include/hw/unicore32/puv3.h index e268484..9fdf0a1 100644 --- a/include/hw/unicore32/puv3.h +++ b/include/hw/unicore32/puv3.h @@ -46,8 +46,7 @@ #define DPRINTF(fmt, ...) if (DEBUG_PUV3) { fprintf(stderr, "%s: " fmt , __func__, ## __VA_ARGS__) - } - else { + } else { do {} while (0) } =20 --=20 2.5.0