From nobody Sun May 5 13:55:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489660479976226.0385078036054; Thu, 16 Mar 2017 03:34:39 -0700 (PDT) Received: from localhost ([::1]:42447 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coSju-0005mx-J9 for importer@patchew.org; Thu, 16 Mar 2017 06:34:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1coSDG-0005sk-0n for qemu-devel@nongnu.org; Thu, 16 Mar 2017 06:00:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1coSD9-0000TA-MZ for qemu-devel@nongnu.org; Thu, 16 Mar 2017 06:00:54 -0400 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:34444) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1coSD9-0000Sk-GP for qemu-devel@nongnu.org; Thu, 16 Mar 2017 06:00:47 -0400 Received: by mail-pg0-x244.google.com with SMTP id b5so5527631pgg.1 for ; Thu, 16 Mar 2017 03:00:47 -0700 (PDT) Received: from localhost.localdomain ([122.173.66.79]) by smtp.googlemail.com with ESMTPSA id b195sm9400363pfb.106.2017.03.16.03.00.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 16 Mar 2017 03:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=wzeV/QmRzWL3WASRVBrrOmySIWJyAoiZ8q2ZiKdDtAI=; b=Ljm+8yZQ8cQVlzMjro9OJb8e4W3Hki4cjq8iza5C5KG0hFaWZc1hu3PyvrgAN3V/8Q GMAnXi/PPqVDkJ8NAK7oxQkimQQKaHm93VXWPYZBV55KiEFqTvlPIewIvotS6YXLUgWX 8am0FoLZle+t0jfGlr4nOLW+jdv3PByANf7ysTNrpjd1bGTojOHu3vvszT3XcbP7SSuH 7o6q1vuS2axXHNoq2ykVnQ03tvmymabDdOqXIC84qrJIekSNsG6gZkf7SN6cawogCZqT fjQuTLMweOttb60qODuGLzFMbyGdifxAyRpYEYpOtLoKZWqQozD8OMs154ujnOodERTl 4ACg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wzeV/QmRzWL3WASRVBrrOmySIWJyAoiZ8q2ZiKdDtAI=; b=ucAIFk6BrNNhWYLlfQ4lfiHeUf1CaZauAMU2Lxr2ZWu83ItcJBE48PIdFx0HS1nQkY Xw/1ibd+GRV64NRzzd4iWrEJ+NJe/2vtDQscj3l+F+4iDGl7X+uRvk12huRCB15KrCs8 bugpmoq/mv7IZYnItytmHXLEyaR+59gM0zi0CGqJE9evdm49MBHgy+LJvO7dujmto51s J+HqWsqaMg2bfQw2N0oCLm9RevAADxZJPAyNTY2G9kj2KrC33hhShtgTMH8eyZrS0jdt o56azVh1hbeJHaAnGVuxoJOmh+UCpR4PpcHMCCswgrXm9LB5MuSEfW6ow0ljn/unw1hC 9yaQ== X-Gm-Message-State: AFeK/H2KnhLWNxKvfbSgnEIXxi1ENgsxKrHbnuhYjkvBKZsMXP68k3NM7vQUw/wvihYyzQ== X-Received: by 10.98.97.68 with SMTP id v65mr9151301pfb.124.1489658446132; Thu, 16 Mar 2017 03:00:46 -0700 (PDT) From: Anishka0107 To: jsnow@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org Date: Thu, 16 Mar 2017 10:00:21 +0530 Message-Id: <1489638621-31978-1-git-send-email-rimjhim0107@gmail.com> X-Mailer: git-send-email 2.5.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 X-Mailman-Approved-At: Thu, 16 Mar 2017 06:33:39 -0400 Subject: [Qemu-devel] [PATCH] puv3: always compile-check debug printf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anishka0107 Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" To prevent bitrot of the format string of the debug statement, files wi= th conditional debug statements should ensure that printf is compiled always, and enclosed within if(0) statements and not in #ifdef. Signed-off-by: Anishka Gupta --- include/hw/unicore32/puv3.h | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/include/hw/unicore32/puv3.h b/include/hw/unicore32/puv3.h index 5a4839f..e268484 100644 --- a/include/hw/unicore32/puv3.h +++ b/include/hw/unicore32/puv3.h @@ -41,10 +41,14 @@ #define PUV3_IRQS_OST0 (26) =20 /* All puv3_*.c use DPRINTF for debug. */ -#ifdef DEBUG_PUV3 -#define DPRINTF(fmt, ...) printf("%s: " fmt , __func__, ## __VA_ARGS__) -#else -#define DPRINTF(fmt, ...) do {} while (0) -#endif +#define DEBUG_PUV3 0 + +#define DPRINTF(fmt, ...) + if (DEBUG_PUV3) { + fprintf(stderr, "%s: " fmt , __func__, ## __VA_ARGS__) + } + else { + do {} while (0) + } =20 #endif /* QEMU_HW_PUV3_H */ --=20 2.5.0