[Qemu-devel] [PATCH] dma/rc4030: fix a mixed declarations and code warning

Yongbok Kim posted 1 patch 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1489511503-13334-1-git-send-email-yongbok.kim@imgtec.com
Test checkpatch passed
Test docker passed
hw/dma/rc4030.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH] dma/rc4030: fix a mixed declarations and code warning
Posted by Yongbok Kim 7 years ago
Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>
---
 hw/dma/rc4030.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c
index 8ad97f1..4dbb4fd 100644
--- a/hw/dma/rc4030.c
+++ b/hw/dma/rc4030.c
@@ -99,8 +99,8 @@ typedef struct rc4030State
 
 static void set_next_tick(rc4030State *s)
 {
-    qemu_irq_lower(s->timer_irq);
     uint32_t tm_hz;
+    qemu_irq_lower(s->timer_irq);
 
     tm_hz = 1000 / (s->itr + 1);
 
-- 
2.7.4


Re: [Qemu-devel] [PATCH] dma/rc4030: fix a mixed declarations and code warning
Posted by Hervé Poussineau 7 years ago
Le 14/03/2017 à 18:11, Yongbok Kim a écrit :
> Signed-off-by: Yongbok Kim <yongbok.kim@imgtec.com>

Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>

> ---
>  hw/dma/rc4030.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/dma/rc4030.c b/hw/dma/rc4030.c
> index 8ad97f1..4dbb4fd 100644
> --- a/hw/dma/rc4030.c
> +++ b/hw/dma/rc4030.c
> @@ -99,8 +99,8 @@ typedef struct rc4030State
>
>  static void set_next_tick(rc4030State *s)
>  {
> -    qemu_irq_lower(s->timer_irq);
>      uint32_t tm_hz;
> +    qemu_irq_lower(s->timer_irq);
>
>      tm_hz = 1000 / (s->itr + 1);
>
>