From nobody Mon Feb 9 09:34:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489508415612205.5989536331639; Tue, 14 Mar 2017 09:20:15 -0700 (PDT) Received: from localhost ([::1]:60560 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnpB8-0003qc-8N for importer@patchew.org; Tue, 14 Mar 2017 12:20:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36592) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnp9a-0003PP-V4 for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnp9a-0006Yf-4n for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:30 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:34710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cnp9Z-0006Xw-UJ for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:30 -0400 Received: by mail-wm0-x243.google.com with SMTP id u132so610113wmg.1 for ; Tue, 14 Mar 2017 09:18:29 -0700 (PDT) Received: from 640k.lan (94-39-132-181.adsl-ull.clienti.tiscali.it. [94.39.132.181]) by smtp.gmail.com with ESMTPSA id k195sm408197wmd.7.2017.03.14.09.18.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Mar 2017 09:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=OqJsYwHfAKWTtOiZOBAcJz8fm37T6jBqBKxiVRdNDq8=; b=ZC8XJ/PZxZYrlwYEOwaOvB+Qx+JilgvcvYbx/I79KoAUCOZG4xW8QOD+nJBg7a5Y2L jf7su5PQSHLeqSOTbSIPthvxN3Rr8yYA1Mff9rXjfiz4JVWwaK4rq3x9bJ8yhu4fGEYi 3Vw4DgQCWPy6QxAwhyDMS8CRg5HMxpwDfgsfGDapY/gYHX6I9Sn4SztqFb6wf0qGcZbm WaZtIf1yLz20CekNGTAR3HRiJHq4nv/Ne+Wim4VPbU6J3Cmv1S8hdRoh0E5AeDJ1qqfh JL/+F+PdnD8H1xyejZdv5pG/pSyQD44Fh2KEXygJbmuHk85MhdqSQxG7sv7YcrZqfwxg sRJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=OqJsYwHfAKWTtOiZOBAcJz8fm37T6jBqBKxiVRdNDq8=; b=Km/u15O6CO6glmy+fvI30HZfZca+R+GmoZNK/8iFTYiBVTgvJej3rX0dcBxGKU8aeU y2wnqXBnUC2lURsHVhq2P45Er+U22t6094KzCbJJ5OtXApphLFsjMF713J6mV2oIDQwe NhGuoaja2Wz0lvL3nQIcHj2A6e5Fy42ZrMrDJNkEfYrwznrYpZSqYI0Lo3mzXcSaGso+ MhqTWOfVMQc4XoL03zZ6xl6VtMeD0HoiHG/DB0ELithIQwhdfJ/mkDglk1+v5b/sGd+D c1GbW18TciaIlCXhQX5xon2n18AwOATs3Dm6SIX+cEyZ+3OQjUsZmJfBLq1Pto86Nyqi 0S2g== X-Gm-Message-State: AFeK/H2iwCbxpKQFdsxKkeaTSpmzuyF0oLJniB4n3xO3VfxFTRGTspqRmVr+P1ECvouAcQ== X-Received: by 10.28.7.20 with SMTP id 20mr471449wmh.115.1489508308686; Tue, 14 Mar 2017 09:18:28 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 14 Mar 2017 17:18:06 +0100 Message-Id: <1489508300-48184-5-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1489508300-48184-1-git-send-email-pbonzini@redhat.com> References: <1489508300-48184-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] [PULL 04/18] exec: add cpu_synchronize_state to cpu_memory_rw_debug X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Borntraeger Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Christian Borntraeger I sometimes got "Cannot access memory" when using the x command on the monitor. Turns out that the cpu env did contain stale data (e.g. wrong control register content for page table origin). We must synchronize the state of the CPU before walking the page tables. A similar issues happens for a remote gdb, so lets do the cpu_synchronize_state in cpu_memory_rw_debug. Signed-off-by: Christian Borntraeger Message-Id: <1488896348-13560-1-git-send-email-borntraeger@de.ibm.com> Signed-off-by: Paolo Bonzini --- exec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/exec.c b/exec.c index 68135a9..a22f5a0 100644 --- a/exec.c +++ b/exec.c @@ -43,6 +43,7 @@ #include "exec/ioport.h" #include "sysemu/dma.h" #include "sysemu/numa.h" +#include "sysemu/hw_accel.h" #include "exec/address-spaces.h" #include "sysemu/xen-mapcache.h" #include "trace-root.h" @@ -3309,6 +3310,7 @@ int cpu_memory_rw_debug(CPUState *cpu, target_ulong a= ddr, hwaddr phys_addr; target_ulong page; =20 + cpu_synchronize_state(cpu); while (len > 0) { int asidx; MemTxAttrs attrs; --=20 1.8.3.1