From nobody Mon Feb 9 08:11:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489508560856233.77287505764377; Tue, 14 Mar 2017 09:22:40 -0700 (PDT) Received: from localhost ([::1]:60575 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnpDU-0005zq-DC for importer@patchew.org; Tue, 14 Mar 2017 12:22:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnp9Z-0003OI-Ad for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnp9X-0006We-4i for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:29 -0400 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:35924) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cnp9W-0006WE-Ug for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:27 -0400 Received: by mail-wr0-x242.google.com with SMTP id l37so24466327wrc.3 for ; Tue, 14 Mar 2017 09:18:26 -0700 (PDT) Received: from 640k.lan (94-39-132-181.adsl-ull.clienti.tiscali.it. [94.39.132.181]) by smtp.gmail.com with ESMTPSA id k195sm408197wmd.7.2017.03.14.09.18.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Mar 2017 09:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=74oU2jhPEktc8v0XSQE2NLXxdmKAv7iV4+CMwMrKXVY=; b=gu8MZ12Ax035YZ23F+ZjPigDy0gi/7OkA45abDeiMZ+HfEmgvDTSWkuOpvWNztkUiN /VJGp8uew1Vab5HXU7/pJ1GVPJGfI/RYGFMGbdaKa+qWKd4FBZ6RfhRFWeDPinjzWb5c yhNJsio9goBZN4myS0nEGCrgEFcQqL1XYblcTmqjCE0e8pYnOTwH5lsc7JqpzL0+kCqK IZgiImnsCTagSVfnoOPgVShlt2ZMwFkYhoNLeQVjbCYFdMOfu54xRyGv8wwHtq8NQ34i x0pB5tshOXpRLI6u018FTEU2wOfG+u+DNAIAga07e6D1gBmWMr2xUSwI5HjNRlSyaAv2 3sGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=74oU2jhPEktc8v0XSQE2NLXxdmKAv7iV4+CMwMrKXVY=; b=AWNLX571LKT5WAE77IXkpqwyBpExYM9J39wtWpa5EWLKcEpIO3KszEJ/gVPsuTPvA5 vCN8jkI5RgsbtuWpCuXIUMcfap3bhHWE6XBFu+tSN8tzjsuNWxVMH1/Fuf6PMzH5BPsa wSknfAViv+O2r8eCmklXAkeKRX4O9XIZcNCgG9PwjUJ9uf/4yPrOVP+ZjU1rdK4A3Jgy jukDUqisizXEWJwS1SdnqtobcqJlCzr6pi9L2odZgs32ZKNYWOLv7pGoTY6IWJyAdYLL ihBL8MNS2bWFTgz5v9FfPBA4VynG8bHHdZSlyGfXofpNyH4SPsRhXL3v9CAIU1xXdCfa T/uw== X-Gm-Message-State: AMke39l0Kf3tGHalIo13eTouyM8qErEjH8sVtA3/sS+qKhzlbj6dkyVWel9BrL/iFlhLQA== X-Received: by 10.223.145.227 with SMTP id 90mr35099705wri.156.1489508305634; Tue, 14 Mar 2017 09:18:25 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 14 Mar 2017 17:18:03 +0100 Message-Id: <1489508300-48184-2-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1489508300-48184-1-git-send-email-pbonzini@redhat.com> References: <1489508300-48184-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::242 Subject: [Qemu-devel] [PULL 01/18] memory_region: Fix name comments X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: "Dr. David Alan Gilbert" The 'name' parameter to memory_region_init_* had been marked as debug only, however vmstate_region_ram uses it as a parameter to qemu_ram_set_idstr to set RAMBlock names and these form part of the migration stream. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20170309152708.30635-1-dgilbert@redhat.com> Signed-off-by: Paolo Bonzini --- include/exec/memory.h | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 6911023..e39256a 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -371,7 +371,8 @@ void memory_region_init_io(MemoryRegion *mr, * * @mr: the #MemoryRegion to be initialized. * @owner: the object that tracks the region's reference count - * @name: the name of the region. + * @name: Region name, becomes part of RAMBlock name used in migration str= eam + * must be unique within any device * @size: size of the region. * @errp: pointer to Error*, to store an error if it happens. */ @@ -390,7 +391,8 @@ void memory_region_init_ram(MemoryRegion *mr, * * @mr: the #MemoryRegion to be initialized. * @owner: the object that tracks the region's reference count - * @name: the name of the region. + * @name: Region name, becomes part of RAMBlock name used in migration str= eam + * must be unique within any device * @size: used size of the region. * @max_size: max size of the region. * @resized: callback to notify owner about used size change. @@ -412,7 +414,8 @@ void memory_region_init_resizeable_ram(MemoryRegion *mr, * * @mr: the #MemoryRegion to be initialized. * @owner: the object that tracks the region's reference count - * @name: the name of the region. + * @name: Region name, becomes part of RAMBlock name used in migration str= eam + * must be unique within any device * @size: size of the region. * @share: %true if memory must be mmaped with the MAP_SHARED flag * @path: the path in which to allocate the RAM. @@ -434,7 +437,8 @@ void memory_region_init_ram_from_file(MemoryRegion *mr, * * @mr: the #MemoryRegion to be initialized. * @owner: the object that tracks the region's reference count - * @name: the name of the region. + * @name: Region name, becomes part of RAMBlock name used in migration str= eam + * must be unique within any device * @size: size of the region. * @ptr: memory to be mapped; must contain at least @size bytes. */ @@ -496,7 +500,8 @@ void memory_region_init_alias(MemoryRegion *mr, * * @mr: the #MemoryRegion to be initialized. * @owner: the object that tracks the region's reference count - * @name: the name of the region. + * @name: Region name, becomes part of RAMBlock name used in migration str= eam + * must be unique within any device * @size: size of the region. * @errp: pointer to Error*, to store an error if it happens. */ @@ -513,7 +518,8 @@ void memory_region_init_rom(MemoryRegion *mr, * @mr: the #MemoryRegion to be initialized. * @owner: the object that tracks the region's reference count * @ops: callbacks for write access handling (must not be NULL). - * @name: the name of the region. + * @name: Region name, becomes part of RAMBlock name used in migration str= eam + * must be unique within any device * @size: size of the region. * @errp: pointer to Error*, to store an error if it happens. */ --=20 1.8.3.1