From nobody Mon Feb 9 07:56:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489509087268286.02121370060945; Tue, 14 Mar 2017 09:31:27 -0700 (PDT) Received: from localhost ([::1]:60620 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnpM4-0005vT-3i for importer@patchew.org; Tue, 14 Mar 2017 12:31:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnp9n-0003cj-NS for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnp9m-0006lV-Pv for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:43 -0400 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:33438) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cnp9m-0006kn-Jp for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:42 -0400 Received: by mail-wm0-x241.google.com with SMTP id n11so610589wma.0 for ; Tue, 14 Mar 2017 09:18:42 -0700 (PDT) Received: from 640k.lan (94-39-132-181.adsl-ull.clienti.tiscali.it. [94.39.132.181]) by smtp.gmail.com with ESMTPSA id k195sm408197wmd.7.2017.03.14.09.18.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Mar 2017 09:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JEKQMdVT0a++5lnseDMXMxZhv7AeignVRkDJoaDTQqw=; b=MRuSirhyR7wK7/VJ04WWHJgxJ3nW9DobPtA0AKB1CRv//Z6nvkeFwLQ4jFYa8TZ1Bm 2Pqt/IVmU7I2Mb7SQIL6J7c19tRIh5cdfsx22wlRwqo3i9Gp4zxi0J7tkHLjVlrb+v19 +UCO9t4sh2peXceoEJNOpkXjQKlhCHf+dAcTjkSYaVqq9kliV9VEpYx9LSCSVA07eDKS kCNlXFP7pPTl8IRpNvuuvOO6n2LFEPTsKj3OgUGbEGOnGqnDtSj7Amu5/1DZeUPRcDv/ xnW5hJJSZGfYlCBEFozG7MU9Bl3xeSjpq+QVdjj8ccqKr4ZS3tGRSiv4SdWqp7/9Ql89 ZTcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=JEKQMdVT0a++5lnseDMXMxZhv7AeignVRkDJoaDTQqw=; b=gG/UWVqRANZLUCFV/pKuU89TPoYL4Qy9fzom81J/w+aIS6/Ql6Ol/7To6oLZDWx1q3 fpElkh6mtBKvYDdMNjeQNXwzFJKrh4H4v64uj3YGb2BGyJSEkKIhwFCHsYD0rkelk22r 3mwGoGiLE0q4PIy3E+2o+LlCTDOMp3Wm3h2PPCo7HWiMSn9YoBhZqAvKLeQK4u8o0KXi Xf6aGlqH7rymgxjWKL1udRJqRsrZBpBoM4yvTYWkl8RzuoKkkYnKH2SDsLLl17h1HAW7 c/TZTtW2TLz8aTpSr3Q4xVjTAybAZCn33Pm9EqewxFrQiBuBjGDVf+kRUzX7SNPPSiY1 lqLw== X-Gm-Message-State: AFeK/H1z/dDGtGrkUAVlc1+gjbeqvkQNbnz8U6IL9efXmJDKRtwh2kehohZO8VL19QWupQ== X-Received: by 10.28.88.129 with SMTP id m123mr573644wmb.28.1489508321669; Tue, 14 Mar 2017 09:18:41 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 14 Mar 2017 17:18:20 +0100 Message-Id: <1489508300-48184-19-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1489508300-48184-1-git-send-email-pbonzini@redhat.com> References: <1489508300-48184-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PULL 18/18] nbd/client: fix drop_sync [CVE-2017-2630] X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vladimir Sementsov-Ogievskiy Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 From: Vladimir Sementsov-Ogievskiy Comparison symbol is misused. It may lead to memory corruption. Introduced in commit 7d3123e. Signed-off-by: Vladimir Sementsov-Ogievskiy Message-Id: <20170203154757.36140-6-vsementsov@virtuozzo.com> [eblake: add CVE details, update conditional] Signed-off-by: Eric Blake Reviewed-by: Marc-Andr=C3=83=C2=A9 Lureau Message-Id: <20170307151627.27212-1-eblake@redhat.com> Signed-off-by: Paolo Bonzini --- nbd/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd/client.c b/nbd/client.c index 5c9dee3..3dc2564 100644 --- a/nbd/client.c +++ b/nbd/client.c @@ -94,7 +94,7 @@ static ssize_t drop_sync(QIOChannel *ioc, size_t size) char small[1024]; char *buffer; =20 - buffer =3D sizeof(small) < size ? small : g_malloc(MIN(65536, size)); + buffer =3D sizeof(small) >=3D size ? small : g_malloc(MIN(65536, size)= ); while (size > 0) { ssize_t count =3D read_sync(ioc, buffer, MIN(65536, size)); =20 --=20 1.8.3.1