From nobody Mon Feb 9 09:15:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 148950886087119.723908316209418; Tue, 14 Mar 2017 09:27:40 -0700 (PDT) Received: from localhost ([::1]:60599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnpIQ-0002Kz-LW for importer@patchew.org; Tue, 14 Mar 2017 12:27:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnp9p-0003dL-LZ for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnp9k-0006iH-3Z for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:45 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:36138) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cnp9j-0006hR-SS for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:39 -0400 Received: by mail-wm0-x243.google.com with SMTP id v190so583484wme.3 for ; Tue, 14 Mar 2017 09:18:39 -0700 (PDT) Received: from 640k.lan (94-39-132-181.adsl-ull.clienti.tiscali.it. [94.39.132.181]) by smtp.gmail.com with ESMTPSA id k195sm408197wmd.7.2017.03.14.09.18.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Mar 2017 09:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3IeO20HPyhSdEdk5uN9iXWDpwvGeI78K1uQMrh49nNE=; b=hSqt/kCYs4X8mB0q5xUL1qg4n+/u8jXS1C35w4ejL49JBliEgnxI6jtUhro3HYK2Yl 6f4GeQcfOb4vhgs4vyy/fEXnmEYLoj7au5uH65qo8YZnlit4Sgx7ulwWEOaw6vUmFXPr /rCrci7wkrnhAxX8FROQqgkYeBPMcS4NiCvPoGuudNa2UEdbYRetxr+O20aLsZo9l30W hCMHsbDibqMa8dzvEn4snZM1My/sx5Zpb85AY9DIWM+2rm4k9EQfmWkPuOvCeDQDP2gF mZsNaYujPZBFVgQrQqsKVf3U0RiB3U1qAANX412MVhzwoTO1OWbStFVA+YKD9eMDxNUH TD0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=3IeO20HPyhSdEdk5uN9iXWDpwvGeI78K1uQMrh49nNE=; b=RIjKohBRV2JZmZLSYfkE1/mhfMpBBymhVhKTiT98TJ2mQguKkprdgMzHKd7ME4ZzrV Ox8/G72q1SCTCRQlA9/rZeCqVn/8DwtaJj8s0t5QHDK5ZKNwDUNCihttRqoSGLj8zW3S f9BM7tmzLGUMIQik0SZCYmJOkWdmbBKIixE3d/nRJZBbG/D0gFgxltU77iZs4rPOcfT3 wraQOKQSbtyH6UD9XrdcZZhh1NdUCr4p7aGrwkVEeyXHVrzGfQWlsz1lxajpSjBNSlUV 7ELp+wRSv2u2S5K6kpCbTzn6mV6blu0suGNNhFGEODxd6wziszVvWpHnveU4ulOLslTj cnhg== X-Gm-Message-State: AFeK/H0YxNMB3qS4tIAuzejXW/ldPNUbhbX7zu3Z0Kr45uDzlDotzG0V/k+R4gJReBpf9A== X-Received: by 10.28.154.7 with SMTP id c7mr512127wme.119.1489508318751; Tue, 14 Mar 2017 09:18:38 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 14 Mar 2017 17:18:17 +0100 Message-Id: <1489508300-48184-16-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1489508300-48184-1-git-send-email-pbonzini@redhat.com> References: <1489508300-48184-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] [PULL 15/18] main-loop: remove now unnecessary optimization X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 This optimization is not necessary anymore, because the vCPU now drops the I/O thread lock even with TCG. Drop it to simplify the code and avoid the "I/O thread spun for 1000 iterations" warning. Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Edgar E. Iglesias Signed-off-by: Paolo Bonzini --- vl.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/vl.c b/vl.c index 1a95500..0b4ed52 100644 --- a/vl.c +++ b/vl.c @@ -1888,17 +1888,14 @@ static bool main_loop_should_exit(void) =20 static void main_loop(void) { - bool nonblocking; - int last_io =3D 0; #ifdef CONFIG_PROFILER int64_t ti; #endif do { - nonblocking =3D tcg_enabled() && last_io > 0; #ifdef CONFIG_PROFILER ti =3D profile_getclock(); #endif - last_io =3D main_loop_wait(nonblocking); + main_loop_wait(false); #ifdef CONFIG_PROFILER dev_time +=3D profile_getclock() - ti; #endif --=20 1.8.3.1