From nobody Mon Feb 9 07:56:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489508542018989.5946504917326; Tue, 14 Mar 2017 09:22:22 -0700 (PDT) Received: from localhost ([::1]:60574 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnpDC-0005jV-Ki for importer@patchew.org; Tue, 14 Mar 2017 12:22:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnp9i-0003XY-RR for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnp9h-0006fm-FN for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:38 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:36136) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cnp9h-0006es-84 for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:37 -0400 Received: by mail-wm0-x243.google.com with SMTP id v190so583324wme.3 for ; Tue, 14 Mar 2017 09:18:37 -0700 (PDT) Received: from 640k.lan (94-39-132-181.adsl-ull.clienti.tiscali.it. [94.39.132.181]) by smtp.gmail.com with ESMTPSA id k195sm408197wmd.7.2017.03.14.09.18.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Mar 2017 09:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x2YiLPvlct4lKtZehtyRnOoVtOlQPImtOorsSH0q/is=; b=OODQBIcBHw9rYKEMXofsNONrGmde97vKHBWnsxGUpjdXbMZ34OGIbOUGkHpfD+2iIq MMPn4zGdjGU0YYVxIjlTsNHuLqioikt2/M8V2rqKRDdEBbm3/9HNsXcavUd3Ny41DCQF G6Uw448n6W8g8TaKhtgNvLZz5HN7HIiXxBH5rP53DuDKARSqMaRF0+4KHH94/tI9RYt0 mI5+bOdW4IqnFyRXCeaBAbVNeqbm2p5fd68c/Ra6jFljeYTxQEtC92SGiJQ3SaZY38r6 8geixZY42le9TfMQCp46HEaQ0FAADmRd8SdvkxYyEMQ45mGhh5hV8/STZSrpfNWMEUnj 63GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=x2YiLPvlct4lKtZehtyRnOoVtOlQPImtOorsSH0q/is=; b=OEuJ9IMkt5101CAU07BT95CQC5TmhlHeV6kAkc3TFRsQqPApQjt6wSkQUKeW2DGTmF oExVoSOebR4Jgr+YgNf/IsHHvSq+SefHKYK3VG+4fQ81+yslp/GvHLEZFvAkdPeC6kRG iVHDm7au4XR0DYCdvcHqQfMeDsvBIMLGX8db3vbUzKthk1TkEb+CbGRMviwNJof6o44h HaI2JVhqmeQq7qX/ail7D4Icef2wx3GKk3viwj6flJfyZNw3qzYWY/a8NUg5Es0Pmw0o PS3WK6q4C3syZ5OkMlufGbC3VqG7qpfaXGn3pDy2KLATnvS9JpkrdxuXrC56lKgB0QQF aSlg== X-Gm-Message-State: AFeK/H1BLKBQ76P69VzHF0jy9tYxOkPnPUHy/F0fUlTcep8+lHWxPWMRmBBby2Z7I5IB6g== X-Received: by 10.28.17.11 with SMTP id 11mr15531221wmr.32.1489508316144; Tue, 14 Mar 2017 09:18:36 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 14 Mar 2017 17:18:14 +0100 Message-Id: <1489508300-48184-13-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1489508300-48184-1-git-send-email-pbonzini@redhat.com> References: <1489508300-48184-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] [PULL 12/18] qemu-timer: fix off-by-one X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 If the first timer is exactly at the current value of the clock, the deadline is met and the timer should fire. This fixes itself on the next iteration of the loop without icount; with icount, however, execution of instructions will stop exactly at the deadline and won't proceed. Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Edgar E. Iglesias Signed-off-by: Paolo Bonzini --- util/qemu-timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index 6cf70b9..2f20151 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -199,7 +199,7 @@ bool timerlist_expired(QEMUTimerList *timer_list) expire_time =3D timer_list->active_timers->expire_time; qemu_mutex_unlock(&timer_list->active_timers_lock); =20 - return expire_time < qemu_clock_get_ns(timer_list->clock->type); + return expire_time <=3D qemu_clock_get_ns(timer_list->clock->type); } =20 bool qemu_clock_expired(QEMUClockType type) --=20 1.8.3.1