From nobody Mon Feb 9 06:48:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1489508965279812.8359084908487; Tue, 14 Mar 2017 09:29:25 -0700 (PDT) Received: from localhost ([::1]:60607 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnpK7-0003vk-RC for importer@patchew.org; Tue, 14 Mar 2017 12:29:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnp9i-0003XX-Rf for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnp9f-0006e0-L1 for qemu-devel@nongnu.org; Tue, 14 Mar 2017 12:18:38 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:35659) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cnp9f-0006dX-El; Tue, 14 Mar 2017 12:18:35 -0400 Received: by mail-wm0-x243.google.com with SMTP id z63so594616wmg.2; Tue, 14 Mar 2017 09:18:35 -0700 (PDT) Received: from 640k.lan (94-39-132-181.adsl-ull.clienti.tiscali.it. [94.39.132.181]) by smtp.gmail.com with ESMTPSA id k195sm408197wmd.7.2017.03.14.09.18.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Mar 2017 09:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=FaOFUuUJPTTFES6IoT+VdGN7mVm4dR8JcDuTtmTvfmY=; b=ApmUcmQkNmE0EEhqaV107iTu43kg4ccqGsHl95bHjezDueBBrTKnVmZGipwPOBwxzt gNVphCDJxy9AnH74FUnN45N2Xsa2ROr7+xAxBIKL36uJQVsZxobCPxk4cHq+bz4xkRyR 6R78wYIC93HECwG1je+sltuq9fylNpSDOxCM2LK2e2UXSv/adS254+TS41ewVo6yvKOw /t7F9HjS6fz9Ob86C3B7Of7kGYvox1MJiDRDhw0pD2NdbPs7Uc5sejtYfk6swGYqIVjx I1lTSbBQcqmbmCAxTZeuJlTN+I15Ycv4mXzHq4Upn4Cb10vdbfHFbn59I9dC/tTpmQvO bLrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=FaOFUuUJPTTFES6IoT+VdGN7mVm4dR8JcDuTtmTvfmY=; b=bHSeJ4PQRkXr3JI9tSGy2C/Dx7O0H7YzifQcJjccfSAm1BpM16EhtH1z3ensI/Dp2n D5UP53aPaQFGRXxBbN39irokT1h1g2ZR5zuTSj5g31v1ox47Fo0vubczlaLk2tYVqOml e/jNYYSmh9eHdarRJUX5mE4J+0QFdSEZN9WGT4H+bArFv24mXadV5APcCEUJjuKaa6Y+ FH6edSpdZhYRWLMyBkCLGoAEgLvfTTLYhliZ2f0VIDVDJf1ipJ+4T3nmMv7A1/pQfqu7 AvEPWJR4sHYI0Og5k/KAMENsfrhzxn8g2KeogEhROyFHKcEKDLKXVAnPltmPabtkhbKk JDaQ== X-Gm-Message-State: AFeK/H0KHqxVCjfaKuGqWWEekRlQYmeds97J5eNPnSGL94IubFK06z1tRD7Q6QCgrQzCSQ== X-Received: by 10.28.66.207 with SMTP id k76mr15867411wmi.121.1489508314500; Tue, 14 Mar 2017 09:18:34 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Tue, 14 Mar 2017 17:18:12 +0100 Message-Id: <1489508300-48184-11-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1489508300-48184-1-git-send-email-pbonzini@redhat.com> References: <1489508300-48184-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::243 Subject: [Qemu-devel] [PULL 10/18] scsi: mptsas: fix the wrong reading size in fetch request X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , Li Qiang , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Li Qiang When fetching request, it should read sizeof(*hdr), not the pointer hdr. Signed-off-by: Li Qiang Message-Id: <1489488980-130668-1-git-send-email-liqiang6-s@360.cn> Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini --- hw/scsi/mptsas.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/scsi/mptsas.c b/hw/scsi/mptsas.c index 2e091c0..765ab53 100644 --- a/hw/scsi/mptsas.c +++ b/hw/scsi/mptsas.c @@ -756,7 +756,7 @@ static void mptsas_fetch_request(MPTSASState *s) =20 /* Read the message header from the guest first. */ addr =3D s->host_mfa_high_addr | MPTSAS_FIFO_GET(s, request_post); - pci_dma_read(pci, addr, req, sizeof(hdr)); + pci_dma_read(pci, addr, req, sizeof(*hdr)); =20 if (hdr->Function < ARRAY_SIZE(mpi_request_sizes) && mpi_request_sizes[hdr->Function]) { @@ -766,8 +766,8 @@ static void mptsas_fetch_request(MPTSASState *s) */ size =3D mpi_request_sizes[hdr->Function]; assert(size <=3D MPTSAS_MAX_REQUEST_SIZE); - pci_dma_read(pci, addr + sizeof(hdr), &req[sizeof(hdr)], - size - sizeof(hdr)); + pci_dma_read(pci, addr + sizeof(*hdr), &req[sizeof(*hdr)], + size - sizeof(*hdr)); } =20 if (hdr->Function =3D=3D MPI_FUNCTION_SCSI_IO_REQUEST) { --=20 1.8.3.1