From nobody Mon Feb 9 11:32:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 148855729747172.73104374258514; Fri, 3 Mar 2017 08:08:17 -0800 (PST) Received: from localhost ([::1]:58814 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjpke-0000AO-41 for importer@patchew.org; Fri, 03 Mar 2017 11:08:16 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjpge-0005nY-H8 for qemu-devel@nongnu.org; Fri, 03 Mar 2017 11:04:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjpgd-0000Ku-KN for qemu-devel@nongnu.org; Fri, 03 Mar 2017 11:04:08 -0500 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:48759) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cjpgd-0000Jj-EX for qemu-devel@nongnu.org; Fri, 03 Mar 2017 11:04:07 -0500 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.84_2) (envelope-from ) id 1cjpTX-0006DP-Bd; Fri, 03 Mar 2017 15:50:35 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 3 Mar 2017 15:50:29 +0000 Message-Id: <1488556233-31246-3-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1488556233-31246-1-git-send-email-peter.maydell@linaro.org> References: <1488556233-31246-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PATCH for-2.9 2/6] disas/i386: Avoid NULL pointer dereference in error case X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , patches@linaro.org, Laurent Vivier , Paolo Bonzini , "Edgar E. Iglesias" , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In a code path where we hit an internal disassembler error, execution would subsequently attempt to dereference a NULL pointer. This should never happen, but avoid the crash. Signed-off-by: Peter Maydell --- disas/i386.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disas/i386.c b/disas/i386.c index 07f871f..f1e376c 100644 --- a/disas/i386.c +++ b/disas/i386.c @@ -4043,7 +4043,7 @@ print_insn (bfd_vma pc, disassemble_info *info) } } =20 - if (putop (dp->name, sizeflag) =3D=3D 0) + if (dp->name !=3D NULL && putop (dp->name, sizeflag) =3D=3D 0) { for (i =3D 0; i < MAX_OPERANDS; ++i) { --=20 2.7.4