From nobody Tue May 7 04:15:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 148855578769921.17166663581895; Fri, 3 Mar 2017 07:43:07 -0800 (PST) Received: from localhost ([::1]:58687 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjpMI-0001R5-23 for importer@patchew.org; Fri, 03 Mar 2017 10:43:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjpLB-000123-IR for qemu-devel@nongnu.org; Fri, 03 Mar 2017 10:41:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjpL6-0007tm-Ly for qemu-devel@nongnu.org; Fri, 03 Mar 2017 10:41:57 -0500 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]:32985) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cjpL6-0007t5-FS for qemu-devel@nongnu.org; Fri, 03 Mar 2017 10:41:52 -0500 Received: by mail-wr0-x244.google.com with SMTP id g10so13757412wrg.0 for ; Fri, 03 Mar 2017 07:41:52 -0800 (PST) Received: from 640k.lan (94-36-245-171.adsl-ull.clienti.tiscali.it. [94.36.245.171]) by smtp.gmail.com with ESMTPSA id 36sm15653151wrk.57.2017.03.03.07.41.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Mar 2017 07:41:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id; bh=sxh5R/Yv3jacq9uoAxTAWnX2cQDr1EjZw5dWe5N21aY=; b=eqFSHxPda5iCHeozTntik6Ov97tbMBDcKo6pD7EoqZaDH2yeca3pzUXleUoCVbwlrz zR8s2S+MeQQd2HDBB9YexKn0zW/sLOOuu93z+ojPQi+rTpkwd0JUiYFhPYfRF66Hool7 6Mmq31r56SyiAQpRn31dLadnLLH1ZpTyiNekc+8gZ26hQryruLRt8OuUTsCQzng2hmOJ zRGPcs0wei9Jkdz1zSyOKK1VmSGs0U5NXsYgxIO8y3aOxTVcqykMAU1pSv4PLJI/HVZ5 JHfnjKOBiGdaZnK38cGqAvXsUThTI2Yw4UZSktPT6w27pSrh/9O6jC5TlbBwp1PcSiNt qQ+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id; bh=sxh5R/Yv3jacq9uoAxTAWnX2cQDr1EjZw5dWe5N21aY=; b=PV7D6a3ZGNAtAxAeMB3Bk0p5a9RJJMEIy0w9zs4IRInm2Jsp57SGLacPOXn2TzdGsg sqU5DIY6Ds6cU5/zLnKGKtprz0NB0pnJ3MMkm+dITNRPDdsqwSjFwze7BHT6AkO55CzZ XRDKcGpHdPxgwR/Bp7WaIUJb5Z1U+y/2tXHoIp3fBG4sdlPfu2fbS4ZEGLtU4il7u2gK 2JzPUzcuWNFpx3TUZ2nOt7irPAGGTi5lxTCayOYH5jy9sCZhL6I53kvPkdKBCfLkSlgE R302riLNr+NXJAxZSRf8apPjlKr7E0WtFlMdsUeRw2mxi0tnXz36LkYXbbKA2pMBRGNk UMZQ== X-Gm-Message-State: AMke39lOD+HNffLpeW13oZBCx12M0FXX6QlA/xIAOC0dHVhjk0nwX/1B4D5RgDs+TgsBmw== X-Received: by 10.223.173.199 with SMTP id w65mr3219031wrc.125.1488555711178; Fri, 03 Mar 2017 07:41:51 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Fri, 3 Mar 2017 16:41:47 +0100 Message-Id: <1488555707-14669-1-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::244 Subject: [Qemu-devel] [PATCH] iscsi: fix missing unlock X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Reported by Coverity. Signed-off-by: Paolo Bonzini --- block/iscsi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 76319a1..75d8905 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -637,6 +637,7 @@ retry: } #endif if (iTask.task =3D=3D NULL) { + qemu_mutex_unlock(&iscsilun->mutex); return -ENOMEM; } #if LIBISCSI_API_VERSION < (20160603) @@ -864,6 +865,7 @@ retry: } #endif if (iTask.task =3D=3D NULL) { + qemu_mutex_unlock(&iscsilun->mutex); return -ENOMEM; } #if LIBISCSI_API_VERSION < (20160603) @@ -904,6 +906,7 @@ static int coroutine_fn iscsi_co_flush(BlockDriverState= *bs) retry: if (iscsi_synchronizecache10_task(iscsilun->iscsi, iscsilun->lun, 0, 0= , 0, 0, iscsi_co_generic_cb, &iTask) =3D= =3D NULL) { + qemu_mutex_unlock(&iscsilun->mutex); return -ENOMEM; } =20 @@ -1237,6 +1240,7 @@ retry: 0, 0, iscsi_co_generic_cb, &iT= ask); } if (iTask.task =3D=3D NULL) { + qemu_mutex_unlock(&iscsilun->mutex); return -ENOMEM; } =20 --=20 1.8.3.1