From nobody Sat Feb 7 06:27:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1488449440103782.9463610412661; Thu, 2 Mar 2017 02:10:40 -0800 (PST) Received: from localhost ([::1]:51357 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjNgz-0004St-R8 for importer@patchew.org; Thu, 02 Mar 2017 05:10:37 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cjNf1-0003Xc-Dn for qemu-devel@nongnu.org; Thu, 02 Mar 2017 05:08:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cjNf0-0007fh-E5 for qemu-devel@nongnu.org; Thu, 02 Mar 2017 05:08:35 -0500 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:35343) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cjNf0-0007fD-8m for qemu-devel@nongnu.org; Thu, 02 Mar 2017 05:08:34 -0500 Received: by mail-pf0-x244.google.com with SMTP id 67so1971490pfg.2 for ; Thu, 02 Mar 2017 02:08:32 -0800 (PST) Received: from localhost.localdomain.localdomain ([104.192.110.250]) by smtp.gmail.com with ESMTPSA id l22sm15951965pfk.69.2017.03.02.02.08.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Mar 2017 02:08:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+NsoY96FFEd4xPfFIfOdlfSwPuHT+EmJXnebLSvK6yQ=; b=CQUuomZg2zpDVG/+ll/dHBZYjFBwCR2Fk0lUfXzVgHBlZZ+ZRT8pbrOfl+HLgc6gyd P7HsQKjEVM/bP7f2zJPEBunlLZEB/mTFzQrlpYQU9mi3q2auZNnL/u4SHES4W19ceFKW 5xehBwRcI81RrqMlFa9Q6Nr7Byjj/d70sQQS1Qc5IZ9wTlculvDzDysfSYDnvJ+ZJlBo 1Jw7mNPQXZnu+BzgmsfJBcOKSqTHhy7EbM7XtOxPYKT7uijKFrKRBlFAPw7iOme7ORk5 wwLe+XEyw3I07guk9V0mWlzMMk0WzTfzimPiPtIE764R5Erhyd6tI2xX+RoSFAIlkZc2 9o/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+NsoY96FFEd4xPfFIfOdlfSwPuHT+EmJXnebLSvK6yQ=; b=o/bF86mgJgMAzvnjgYW1k/ojBMA+iVYnLnI2BCfoi+nFGevIi+Witk2nfWo/mTHXts 5DZcmaudmH6zLfrRgzQ+lThrpHawUu1yNdZo0ARV/W170TP6TqNQJCaE3ts2ksrc2u5f 0j5uH6LVRY3v7B/AKPFkLhKk1nF5/wf19E3jxdX2NyUf860NBM/fF8xD6arzhZFGLvMs fWXJ2nSluqMEqyhBU65Y83qUZIndl2d5Ycr36ZwfFmJ3UCzAqkgrQ0gn6sNt74T2sk8c wzFeBjG8qXEQXFAMgxvTQzwDRU8fNygel+8JjxxEoiGBShknjORfXbQR9MOj8+OHXxwd 5KRw== X-Gm-Message-State: AMke39nauiSR/+OMfUMOnwBNSF6Lt3Kh+odc4HTIyr/mWdevlBZJjegvTGo1XlJ3liVjlg== X-Received: by 10.99.237.17 with SMTP id d17mr14391050pgi.82.1488449311612; Thu, 02 Mar 2017 02:08:31 -0800 (PST) From: Li Qiang X-Google-Original-From: Li Qiang To: jsnow@redhat.com, qemu-devel@nongnu.org Date: Thu, 2 Mar 2017 02:08:11 -0800 Message-Id: <1488449293-80280-2-git-send-email-liqiang6-s@360.cn> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1488449293-80280-1-git-send-email-liqiang6-s@360.cn> References: <1488449293-80280-1-git-send-email-liqiang6-s@360.cn> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::244 Subject: [Qemu-devel] [PATCH 1/3] ide: qdev: register ide bus unrealize function X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, Li Qiang , ppandit@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" we have an idebus unrealize function, but it was being registered as the unrealize function for the IDE Device, so it was not getting invoked on device teardown because nothing is "unrealizing" the IDE devices themselves. Suggested-by: John Snow Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/ide/qdev.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index dbaa75c..fbf7aa5 100644 --- a/hw/ide/qdev.c +++ b/hw/ide/qdev.c @@ -31,7 +31,7 @@ /* --------------------------------- */ =20 static char *idebus_get_fw_dev_path(DeviceState *dev); -static void idebus_unrealize(DeviceState *qdev, Error **errp); +static void idebus_unrealize(BusState *qdev, Error **errp); =20 static Property ide_props[] =3D { DEFINE_PROP_UINT32("unit", IDEDevice, unit, -1), @@ -43,14 +43,15 @@ static void ide_bus_class_init(ObjectClass *klass, void= *data) BusClass *k =3D BUS_CLASS(klass); =20 k->get_fw_dev_path =3D idebus_get_fw_dev_path; + k->unrealize =3D idebus_unrealize; } =20 -static void idebus_unrealize(DeviceState *qdev, Error **errp) +static void idebus_unrealize(BusState *bus, Error **errp) { - IDEBus *bus =3D DO_UPCAST(IDEBus, qbus, qdev->parent_bus); + IDEBus *ibus =3D IDE_BUS(bus); =20 - if (bus->vmstate) { - qemu_del_vm_change_state_handler(bus->vmstate); + if (ibus->vmstate) { + qemu_del_vm_change_state_handler(ibus->vmstate); } } =20 @@ -365,7 +366,6 @@ static void ide_device_class_init(ObjectClass *klass, v= oid *data) k->init =3D ide_qdev_init; set_bit(DEVICE_CATEGORY_STORAGE, k->categories); k->bus_type =3D TYPE_IDE_BUS; - k->unrealize =3D idebus_unrealize; k->props =3D ide_props; } =20 --=20 1.8.3.1