[Qemu-devel] [PULL 00/26] QAPI patches for 2017-02-28

Markus Armbruster posted 26 patches 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1488308796-28832-1-git-send-email-armbru@redhat.com
Test checkpatch failed
Test docker passed
Test s390x passed
There is a newer version of this series
MAINTAINERS                           |   1 +
block/nbd.c                           |   2 +-
block/nfs.c                           |   2 +-
block/ssh.c                           |   2 +-
docs/qapi-code-gen.txt                |   2 +-
hw/ppc/spapr_drc.c                    |   5 +
include/monitor/monitor.h             |   1 +
include/qapi/qmp/qerror.h             |   9 -
include/qapi/qobject-input-visitor.h  |  40 +++-
include/qapi/qobject-output-visitor.h |  35 +++-
include/qapi/visitor-impl.h           |   7 +-
include/qapi/visitor.h                |  19 +-
include/qemu/module.h                 |   2 -
monitor.c                             | 149 +++++--------
qapi/opts-visitor.c                   |  12 ++
qapi/qapi-visit-core.c                |   8 +
qapi/qmp-dispatch.c                   |  22 +-
qapi/qobject-input-visitor.c          | 219 ++++++++++++-------
qapi/string-input-visitor.c           |  97 +++++----
qapi/trace-events                     |   1 +
qga/main.c                            |   2 +-
qmp.c                                 |   2 +-
qom/qom-qobject.c                     |   4 +-
scripts/qapi-commands.py              |   7 +-
scripts/qapi-visit.py                 |   3 +
target/s390x/cpu_models.c             |   2 +-
tests/Makefile.include                |   9 +-
tests/check-qnull.c                   |   2 +-
tests/libqtest.c                      |  29 ++-
tests/libqtest.h                      |   8 +
tests/qmp-test.c                      | 139 +++++++++++++
tests/test-opts-visitor.c             |  80 +++++++
tests/test-qga.c                      |   2 +-
tests/test-qmp-commands.c             |   4 +-
tests/test-qobject-input-strict.c     | 381 ----------------------------------
tests/test-qobject-input-visitor.c    | 260 ++++++++++++++++++++++-
tests/test-string-input-visitor.c     | 142 ++++++++++---
tests/test-visitor-serialization.c    |   2 +-
trace-events                          |   1 -
vl.c                                  |   2 +-
40 files changed, 1006 insertions(+), 710 deletions(-)
create mode 100644 tests/qmp-test.c
delete mode 100644 tests/test-qobject-input-strict.c
[Qemu-devel] [PULL 00/26] QAPI patches for 2017-02-28
Posted by Markus Armbruster 7 years ago
The following changes since commit 7d1730b7d9d8272a13245adfc9b0405e5a4bd0c2:

  Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into staging (2017-02-28 16:22:41 +0000)

are available in the git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2017-02-28

for you to fetch changes up to c3e7a042e42477ba2c202ba14029e5463a5cfa17:

  qapi: Improve qobject visitor documentation (2017-02-28 19:59:50 +0100)

----------------------------------------------------------------
QAPI patches for 2017-02-28

----------------------------------------------------------------
Markus Armbruster (26):
      qga: Fix crash on non-dictionary QMP argument
      libqtest: Work around a "QMP wants a newline" bug
      qmp-test: New, covering basic QMP protocol
      qmp: Dumb down how we run QMP command registration
      qmp: Clean up how we enforce capability negotiation
      qmp: Drop duplicated QMP command object checks
      qmp: Eliminate silly QERR_QMP_* macros
      qmp: Improve QMP dispatch error messages
      qapi: Improve a QObject input visitor error message
      qapi: Clean up after commit 3d344c2
      qapi: Make QObject input visitor set *list reliably
      qapi: Improve qobject input visitor error reporting
      qapi: Drop string input visitor method optional()
      qapi: Make string input and opts visitor require non-null input
      qom: Make object_property_set_qobject()'s input visitor strict
      test-qobject-input-visitor: Use strict visitor
      qapi: Drop unused non-strict qobject input visitor
      tests-qobject-input-strict: Merge into test-qobject-input-visitor
      test-string-input-visitor: Tear down existing test automatically
      test-string-input-visitor: Improve list coverage
      tests: Cover partial input visit of list
      test-qobject-input-visitor: Cover missing nested struct member
      qapi: Make input visitors detect unvisited list tails
      tests: Cover input visit beyond end of list
      qapi: Fix object input visit beyond end of list
      qapi: Improve qobject visitor documentation

 MAINTAINERS                           |   1 +
 block/nbd.c                           |   2 +-
 block/nfs.c                           |   2 +-
 block/ssh.c                           |   2 +-
 docs/qapi-code-gen.txt                |   2 +-
 hw/ppc/spapr_drc.c                    |   5 +
 include/monitor/monitor.h             |   1 +
 include/qapi/qmp/qerror.h             |   9 -
 include/qapi/qobject-input-visitor.h  |  40 +++-
 include/qapi/qobject-output-visitor.h |  35 +++-
 include/qapi/visitor-impl.h           |   7 +-
 include/qapi/visitor.h                |  19 +-
 include/qemu/module.h                 |   2 -
 monitor.c                             | 149 +++++--------
 qapi/opts-visitor.c                   |  12 ++
 qapi/qapi-visit-core.c                |   8 +
 qapi/qmp-dispatch.c                   |  22 +-
 qapi/qobject-input-visitor.c          | 219 ++++++++++++-------
 qapi/string-input-visitor.c           |  97 +++++----
 qapi/trace-events                     |   1 +
 qga/main.c                            |   2 +-
 qmp.c                                 |   2 +-
 qom/qom-qobject.c                     |   4 +-
 scripts/qapi-commands.py              |   7 +-
 scripts/qapi-visit.py                 |   3 +
 target/s390x/cpu_models.c             |   2 +-
 tests/Makefile.include                |   9 +-
 tests/check-qnull.c                   |   2 +-
 tests/libqtest.c                      |  29 ++-
 tests/libqtest.h                      |   8 +
 tests/qmp-test.c                      | 139 +++++++++++++
 tests/test-opts-visitor.c             |  80 +++++++
 tests/test-qga.c                      |   2 +-
 tests/test-qmp-commands.c             |   4 +-
 tests/test-qobject-input-strict.c     | 381 ----------------------------------
 tests/test-qobject-input-visitor.c    | 260 ++++++++++++++++++++++-
 tests/test-string-input-visitor.c     | 142 ++++++++++---
 tests/test-visitor-serialization.c    |   2 +-
 trace-events                          |   1 -
 vl.c                                  |   2 +-
 40 files changed, 1006 insertions(+), 710 deletions(-)
 create mode 100644 tests/qmp-test.c
 delete mode 100644 tests/test-qobject-input-strict.c

-- 
2.7.4


Re: [Qemu-devel] [PULL 00/26] QAPI patches for 2017-02-28
Posted by Peter Maydell 7 years ago
On 28 February 2017 at 19:06, Markus Armbruster <armbru@redhat.com> wrote:
> The following changes since commit 7d1730b7d9d8272a13245adfc9b0405e5a4bd0c2:
>
>   Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into staging (2017-02-28 16:22:41 +0000)
>
> are available in the git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2017-02-28
>
> for you to fetch changes up to c3e7a042e42477ba2c202ba14029e5463a5cfa17:
>
>   qapi: Improve qobject visitor documentation (2017-02-28 19:59:50 +0100)
>
> ----------------------------------------------------------------
> QAPI patches for 2017-02-28


Failed check-qtest-cris on x86/Linux host:

  GTESTER check-qtest-cris
Broken pipe
GTester: last random seed: R02Sc204c00354522c53b5f366d15508564e
Broken pipe
GTester: last random seed: R02Sceb39014d3fc571bff114b11f1579141
Broken pipe
GTester: last random seed: R02S1654ac812d0c303ef41ff0cb6d7f8e9b
Broken pipe
GTester: last random seed: R02S0f04ab4c25490264543e7838b0a8e311
Broken pipe
GTester: last random seed: R02S3a662141f9907b77c2472f82bc99dea4
Broken pipe
GTester: last random seed: R02S6edf627e16989258c2c3b827de365fdc
Broken pipe
/home/petmay01/linaro/qemu-for-merges/tests/Makefile.include:793:
recipe for target 'check-qtest-cris' failed


Failed check-qtest-sparc on OSX host:

  GTESTER check-qtest-sparc
Broken pipe
GTester: last random seed: R02Se853bd8eaab78c53402578734d57a2de
Broken pipe
GTester: last random seed: R02Sce0ed3ad5793accf735df29e84202cd8
Broken pipe
GTester: last random seed: R02S1d9e0ed3d8ec9138008d7c958f157c81
Broken pipe
GTester: last random seed: R02S3b5a25fd32857e1ecbef1c30ed6b280b
Broken pipe
GTester: last random seed: R02S21fee6c439480b9cc9e1d57e18fa326d
Broken pipe
GTester: last random seed: R02Sa9ada25a1102de6cb8446305b268178e

Yes, those logs are pretty useless. Possibly you're the victim
of some random-intermittent-failure already in the tree,
though it's not the "assert" issue with MTTCG we've seen.

I tried a rerun on OSX host and it failed in the check-qtest-arm
this time around (still no diagnostics beyond 'broken pipe').


thanks
-- PMM

Re: [Qemu-devel] [PULL 00/26] QAPI patches for 2017-02-28
Posted by no-reply@patchew.org 7 years ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 1488308796-28832-1-git-send-email-armbru@redhat.com
Type: series
Subject: [Qemu-devel] [PULL 00/26] QAPI patches for 2017-02-28

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1488308796-28832-1-git-send-email-armbru@redhat.com -> patchew/1488308796-28832-1-git-send-email-armbru@redhat.com
 - [tag update]      patchew/20170227201456.31814-1-berrange@redhat.com -> patchew/20170227201456.31814-1-berrange@redhat.com
Switched to a new branch 'test'
e9777e9 qapi: Improve qobject visitor documentation
dd9bf60 qapi: Fix object input visit beyond end of list
4443465 tests: Cover input visit beyond end of list
898d9e3 qapi: Make input visitors detect unvisited list tails
b6db608 test-qobject-input-visitor: Cover missing nested struct member
80757b0 tests: Cover partial input visit of list
fdae3b2 test-string-input-visitor: Improve list coverage
4fa58f6 test-string-input-visitor: Tear down existing test automatically
3aab16b tests-qobject-input-strict: Merge into test-qobject-input-visitor
83c83f8 qapi: Drop unused non-strict qobject input visitor
5854988 test-qobject-input-visitor: Use strict visitor
23da3ee qom: Make object_property_set_qobject()'s input visitor strict
67b3835 qapi: Make string input and opts visitor require non-null input
7948c3f qapi: Drop string input visitor method optional()
7e5ad00 qapi: Improve qobject input visitor error reporting
5be9196 qapi: Make QObject input visitor set *list reliably
979e388 qapi: Clean up after commit 3d344c2
9480410 qapi: Improve a QObject input visitor error message
b7e32a3 qmp: Improve QMP dispatch error messages
bbbd47c qmp: Eliminate silly QERR_QMP_* macros
62c12b7 qmp: Drop duplicated QMP command object checks
be68b6d qmp: Clean up how we enforce capability negotiation
ca7a5de qmp: Dumb down how we run QMP command registration
f412f0a qmp-test: New, covering basic QMP protocol
dd0679f libqtest: Work around a "QMP wants a newline" bug
4928e9c qga: Fix crash on non-dictionary QMP argument

=== OUTPUT BEGIN ===
Checking PATCH 1/26: qga: Fix crash on non-dictionary QMP argument...
Checking PATCH 2/26: libqtest: Work around a "QMP wants a newline" bug...
Checking PATCH 3/26: qmp-test: New, covering basic QMP protocol...
Checking PATCH 4/26: qmp: Dumb down how we run QMP command registration...
Checking PATCH 5/26: qmp: Clean up how we enforce capability negotiation...
Checking PATCH 6/26: qmp: Drop duplicated QMP command object checks...
Checking PATCH 7/26: qmp: Eliminate silly QERR_QMP_* macros...
Checking PATCH 8/26: qmp: Improve QMP dispatch error messages...
Checking PATCH 9/26: qapi: Improve a QObject input visitor error message...
Checking PATCH 10/26: qapi: Clean up after commit 3d344c2...
Checking PATCH 11/26: qapi: Make QObject input visitor set *list reliably...
Checking PATCH 12/26: qapi: Improve qobject input visitor error reporting...
Checking PATCH 13/26: qapi: Drop string input visitor method optional()...
Checking PATCH 14/26: qapi: Make string input and opts visitor require non-null input...
Checking PATCH 15/26: qom: Make object_property_set_qobject()'s input visitor strict...
Checking PATCH 16/26: test-qobject-input-visitor: Use strict visitor...
Checking PATCH 17/26: qapi: Drop unused non-strict qobject input visitor...
Checking PATCH 18/26: tests-qobject-input-strict: Merge into test-qobject-input-visitor...
ERROR: line over 90 characters
#487: FILE: tests/test-qobject-input-visitor.c:847:
+    v = visitor_input_test_init(data, "{ 'integer': -42, 'boolean': true, 'string': 'foo', 'extra': 42 }");

ERROR: line over 90 characters
#501: FILE: tests/test-qobject-input-visitor.c:861:
+    v = visitor_input_test_init(data, "{ 'string0': 'string0', 'dict1': { 'string1': 'string1', 'dict2': { 'userdef1': { 'integer': 42, 'string': 'string', 'extra': [42, 23, {'foo':'bar'}] }, 'string2': 'string2'}}}");

ERROR: line over 90 characters
#515: FILE: tests/test-qobject-input-visitor.c:875:
+    v = visitor_input_test_init(data, "[ { 'string': 'string0', 'integer': 42 }, { 'string': 'string1', 'integer': 43 }, { 'string': 'string2', 'integer': 44, 'extra': 'ggg' } ]");

ERROR: line over 90 characters
#588: FILE: tests/test-qobject-input-visitor.c:948:
+    v = visitor_input_test_init(data, "{ 'string': 'c', 'integer': 41, 'boolean': true }");

WARNING: line over 80 characters
#595: FILE: tests/test-qobject-input-visitor.c:955:
+static void test_visitor_in_fail_union_flat_no_discrim(TestInputVisitorData *data,

ERROR: line over 90 characters
#603: FILE: tests/test-qobject-input-visitor.c:963:
+    v = visitor_input_test_init(data, "{ 'integer': 42, 'string': 'c', 'string1': 'd', 'string2': 'e' }");

total: 5 errors, 1 warnings, 233 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 19/26: test-string-input-visitor: Tear down existing test automatically...
Checking PATCH 20/26: test-string-input-visitor: Improve list coverage...
Checking PATCH 21/26: tests: Cover partial input visit of list...
Checking PATCH 22/26: test-qobject-input-visitor: Cover missing nested struct member...
Checking PATCH 23/26: qapi: Make input visitors detect unvisited list tails...
Checking PATCH 24/26: tests: Cover input visit beyond end of list...
ERROR: if this code is redundant consider removing it
#86: FILE: tests/test-qobject-input-visitor.c:956:
+#if 0 /* FIXME crash */

total: 1 errors, 0 warnings, 95 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 25/26: qapi: Fix object input visit beyond end of list...
Checking PATCH 26/26: qapi: Improve qobject visitor documentation...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org