From nobody Mon Feb 9 10:58:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1487880334854593.8284181191545; Thu, 23 Feb 2017 12:05:34 -0800 (PST) Received: from localhost ([::1]:60736 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgzds-0004rR-8r for importer@patchew.org; Thu, 23 Feb 2017 15:05:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgzSs-0001xs-FL for qemu-devel@nongnu.org; Thu, 23 Feb 2017 14:54:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cgzSp-0000on-N8 for qemu-devel@nongnu.org; Thu, 23 Feb 2017 14:54:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56680) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cgzSp-0000nS-FM for qemu-devel@nongnu.org; Thu, 23 Feb 2017 14:54:07 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 885E280468 for ; Thu, 23 Feb 2017 19:54:07 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-55.ams2.redhat.com [10.36.116.55]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1NJs6le028216 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Thu, 23 Feb 2017 14:54:07 -0500 Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id A63891138607; Thu, 23 Feb 2017 20:54:02 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Thu, 23 Feb 2017 20:53:51 +0100 Message-Id: <1487879642-16139-14-git-send-email-armbru@redhat.com> In-Reply-To: <1487879642-16139-1-git-send-email-armbru@redhat.com> References: <1487879642-16139-1-git-send-email-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 23 Feb 2017 19:54:07 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 13/24] test-cutils: Cover qemu_strtosz() around range limits X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1487708048-2131-14-git-send-email-armbru@redhat.com> --- tests/test-cutils.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++++= ++-- 1 file changed, 59 insertions(+), 2 deletions(-) diff --git a/tests/test-cutils.c b/tests/test-cutils.c index 1773f15..df6c330 100644 --- a/tests/test-cutils.c +++ b/tests/test-cutils.c @@ -1371,16 +1371,52 @@ static void test_qemu_strtou64_full_max(void) =20 static void test_qemu_strtosz_simple(void) { - const char *str =3D "12345M"; + const char *str; char *endptr =3D NULL; int64_t res; =20 + str =3D "0"; + res =3D qemu_strtosz(str, &endptr); + g_assert_cmpint(res, =3D=3D, 0); + g_assert(endptr =3D=3D str + 1); + + str =3D "12345M"; res =3D qemu_strtosz(str, &endptr); g_assert_cmpint(res, =3D=3D, 12345 * M_BYTE); g_assert(endptr =3D=3D str + 6); =20 res =3D qemu_strtosz(str, NULL); g_assert_cmpint(res, =3D=3D, 12345 * M_BYTE); + + /* Note: precision is 53 bits since we're parsing with strtod() */ + + str =3D "9007199254740991"; /* 2^53-1 */ + res =3D qemu_strtosz_suffix(str, &endptr, QEMU_STRTOSZ_DEFSUFFIX_B); + g_assert_cmpint(res, =3D=3D, 0x1fffffffffffff); + g_assert(endptr =3D=3D str + 16); + + str =3D "9007199254740992"; /* 2^53 */ + res =3D qemu_strtosz_suffix(str, &endptr, QEMU_STRTOSZ_DEFSUFFIX_B); + g_assert_cmpint(res, =3D=3D, 0x20000000000000); + g_assert(endptr =3D=3D str + 16); + + str =3D "9007199254740993"; /* 2^53+1 */ + res =3D qemu_strtosz_suffix(str, &endptr, QEMU_STRTOSZ_DEFSUFFIX_B); + g_assert_cmpint(res, =3D=3D, 0x20000000000000); /* rounded to 53 bits = */ + g_assert(endptr =3D=3D str + 16); + + str =3D "9223372036854774784"; /* 0x7ffffffffffffc00 (53 msbs set) */ + res =3D qemu_strtosz_suffix(str, &endptr, QEMU_STRTOSZ_DEFSUFFIX_B); + g_assert_cmpint(res, =3D=3D, 0x7ffffffffffffc00); + g_assert(endptr =3D=3D str + 19); + + str =3D "9223372036854775295"; /* 0x7ffffffffffffdff */ + res =3D qemu_strtosz_suffix(str, &endptr, QEMU_STRTOSZ_DEFSUFFIX_B); + g_assert_cmpint(res, =3D=3D, 0x7ffffffffffffc00); /* rounded to 53 bit= s */ + g_assert(endptr =3D=3D str + 19); + + /* 0x7ffffffffffffe00..0x7fffffffffffffff get rounded to + * 0x8000000000000000, thus -ERANGE; see test_qemu_strtosz_erange() */ } =20 static void test_qemu_strtosz_units(void) @@ -1482,10 +1518,31 @@ static void test_qemu_strtosz_trailing(void) =20 static void test_qemu_strtosz_erange(void) { - const char *str =3D "10E"; + const char *str; char *endptr =3D NULL; int64_t res; =20 + str =3D "-1"; + res =3D qemu_strtosz(str, &endptr); + g_assert_cmpint(res, =3D=3D, -ERANGE); + g_assert(endptr =3D=3D str + 2); + + str =3D "9223372036854775296"; /* 0x7ffffffffffffe00 */ + res =3D qemu_strtosz_suffix(str, &endptr, QEMU_STRTOSZ_DEFSUFFIX_B); + g_assert_cmpint(res, =3D=3D, -ERANGE); + g_assert(endptr =3D=3D str + 19); + + str =3D "9223372036854775807"; /* 2^63-1 */ + res =3D qemu_strtosz_suffix(str, &endptr, QEMU_STRTOSZ_DEFSUFFIX_B); + g_assert_cmpint(res, =3D=3D, -ERANGE); + g_assert(endptr =3D=3D str + 19); + + str =3D "9223372036854775808"; /* 2^63 */ + res =3D qemu_strtosz_suffix(str, &endptr, QEMU_STRTOSZ_DEFSUFFIX_B); + g_assert_cmpint(res, =3D=3D, -ERANGE); + g_assert(endptr =3D=3D str + 19); + + str =3D "10E"; res =3D qemu_strtosz(str, &endptr); g_assert_cmpint(res, =3D=3D, -ERANGE); g_assert(endptr =3D=3D str + 3); --=20 2.7.4