From nobody Sun Feb 8 22:07:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1487683718099371.1920413311236; Tue, 21 Feb 2017 05:28:38 -0800 (PST) Received: from localhost ([::1]:44600 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cgAUe-0007Wz-Ki for importer@patchew.org; Tue, 21 Feb 2017 08:28:36 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cg9ei-0007mR-1w for qemu-devel@nongnu.org; Tue, 21 Feb 2017 07:34:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cg9ed-000869-80 for qemu-devel@nongnu.org; Tue, 21 Feb 2017 07:34:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39038) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cg9eV-00082y-Sp; Tue, 21 Feb 2017 07:34:43 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0C56837F1F; Tue, 21 Feb 2017 12:34:44 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-55.ams2.redhat.com [10.36.116.55]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1LCYgn4029937 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 21 Feb 2017 07:34:43 -0500 Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D9DD111386CE; Tue, 21 Feb 2017 13:34:39 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Tue, 21 Feb 2017 13:34:33 +0100 Message-Id: <1487680479-15132-6-git-send-email-armbru@redhat.com> In-Reply-To: <1487680479-15132-1-git-send-email-armbru@redhat.com> References: <1487680479-15132-1-git-send-email-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 21 Feb 2017 12:34:44 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PULL 05/11] hw/arm/highbank: Default -drive to if=ide instead of if=scsi X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , qemu-arm@nongnu.org, Peter Maydell Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" These machines have no onboard SCSI HBA, and no way to plug one. -drive if=3Dscsi therefore cannot work. They do have an onboard IDE controller (sysbus-ahci), but fail to honor if=3Dide. Change their default to if=3Dide, and add a TODO comment on what needs to be done to actually honor -drive if=3Dide. Cc: Rob Herring Cc: Peter Maydell Cc: qemu-arm@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: Thomas Huth Message-Id: <1487153147-11530-6-git-send-email-armbru@redhat.com> --- hw/arm/highbank.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index 80e5fd4..0a4508c 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -363,6 +363,8 @@ static void calxeda_init(MachineState *machine, enum cx= machines machine_id) sysbus_connect_irq(SYS_BUS_DEVICE(dev), 2, pic[82]); } =20 + /* TODO create and connect IDE devices for ide_drive_get() */ + highbank_binfo.ram_size =3D ram_size; highbank_binfo.kernel_filename =3D kernel_filename; highbank_binfo.kernel_cmdline =3D kernel_cmdline; @@ -405,7 +407,8 @@ static void highbank_class_init(ObjectClass *oc, void *= data) =20 mc->desc =3D "Calxeda Highbank (ECX-1000)"; mc->init =3D highbank_init; - mc->block_default_type =3D IF_SCSI; + mc->block_default_type =3D IF_IDE; + mc->units_per_default_bus =3D 1; mc->max_cpus =3D 4; } =20 @@ -421,7 +424,8 @@ static void midway_class_init(ObjectClass *oc, void *da= ta) =20 mc->desc =3D "Calxeda Midway (ECX-2000)"; mc->init =3D midway_init; - mc->block_default_type =3D IF_SCSI; + mc->block_default_type =3D IF_IDE; + mc->units_per_default_bus =3D 1; mc->max_cpus =3D 4; } =20 --=20 2.7.4