[Qemu-devel] [PATCH] spice: set merge-lists

Gerd Hoffmann posted 1 patch 142 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1487663871-11859-1-git-send-email-kraxel@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
ui/spice-core.c | 1 +
1 file changed, 1 insertion(+)

[Qemu-devel] [PATCH] spice: set merge-lists

Posted by Gerd Hoffmann 142 weeks ago
This way you can use -spice multiple times on the command line
and qemu will actually pick up all options.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 ui/spice-core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui/spice-core.c b/ui/spice-core.c
index 39ccab7..d613f1a 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -412,6 +412,7 @@ static SpiceChannelList *qmp_query_spice_channels(void)
 
 static QemuOptsList qemu_spice_opts = {
     .name = "spice",
+    .merge_lists = true,
     .head = QTAILQ_HEAD_INITIALIZER(qemu_spice_opts.head),
     .desc = {
         {
-- 
1.8.3.1


Re: [Qemu-devel] [PATCH] spice: set merge-lists

Posted by Marc-André Lureau 142 weeks ago
Hi

On Tue, Feb 21, 2017 at 12:00 PM Gerd Hoffmann <kraxel@redhat.com> wrote:

> This way you can use -spice multiple times on the command line
> and qemu will actually pick up all options.
>
>
Is this actually a good thing to have? vnc doesn't have it for example.
Perhaps some day we may want to have -spice for difference server
instances? (although there are some parameters that would be global, like
gl/rendernode)



> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  ui/spice-core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 39ccab7..d613f1a 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -412,6 +412,7 @@ static SpiceChannelList *qmp_query_spice_channels(void)
>
>  static QemuOptsList qemu_spice_opts = {
>      .name = "spice",
> +    .merge_lists = true,
>      .head = QTAILQ_HEAD_INITIALIZER(qemu_spice_opts.head),
>      .desc = {
>          {
> --
> 1.8.3.1
>
>
> --
Marc-André Lureau

Re: [Qemu-devel] [PATCH] spice: set merge-lists

Posted by Gerd Hoffmann 142 weeks ago
On Di, 2017-02-21 at 08:15 +0000, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Feb 21, 2017 at 12:00 PM Gerd Hoffmann <kraxel@redhat.com>
> wrote:
> 
>         This way you can use -spice multiple times on the command line
>         and qemu will actually pick up all options.
>         
> 
> 
> Is this actually a good thing to have? vnc doesn't have it for
> example. Perhaps some day we may want to have -spice for difference
> server instances?

Is that likely?  The use case for multiple vnc server instances is
multiple displays, which is not a problem for spice because it has
better multihead support.  Also spice-server library doesn't support
multiple instances today, are there plans to actually change that?

But, yes, if we want multiple instances some day this is probably a bad
idea ...

cheers,
  Gerd