From nobody Mon Feb 9 21:37:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1487153944208171.29359918533396; Wed, 15 Feb 2017 02:19:04 -0800 (PST) Received: from localhost ([::1]:39417 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdwfu-0002dU-Uh for importer@patchew.org; Wed, 15 Feb 2017 05:19:02 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdwTK-0006fm-DB for qemu-devel@nongnu.org; Wed, 15 Feb 2017 05:06:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdwTJ-0001n6-6G for qemu-devel@nongnu.org; Wed, 15 Feb 2017 05:06:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37346) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cdwT9-0001cz-5X; Wed, 15 Feb 2017 05:05:51 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C57738047D; Wed, 15 Feb 2017 10:05:50 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-50.ams2.redhat.com [10.36.116.50]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1FA5nFH023545 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 15 Feb 2017 05:05:50 -0500 Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id DF1C311384B0; Wed, 15 Feb 2017 11:05:47 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Wed, 15 Feb 2017 11:05:43 +0100 Message-Id: <1487153147-11530-5-git-send-email-armbru@redhat.com> In-Reply-To: <1487153147-11530-1-git-send-email-armbru@redhat.com> References: <1487153147-11530-1-git-send-email-armbru@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 15 Feb 2017 10:05:50 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3 4/8] hw: Default -drive to if=none instead of scsi when scsi cannot work X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, Peter Maydell , qemu-block@nongnu.org, Alistair Francis , qemu-arm@nongnu.org, "Edgar E. Iglesias" , mreitz@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Block backends defined with -drive if=3Dscsi are meant to be picked up by machine initialization code: a suitable frontend gets created and wired up automatically. if=3Dscsi drives not picked up that way can still be used with -device as if they had if=3Dnone, but that's unclean and best avoided. Unused ones produce an "Orphaned drive without device" warning. A few machine types default to if=3Dscsi, even though they don't actually have a SCSI HBA. This makes no sense. Change their default to if=3Dnone. Affected machines: * aarch64/arm: realview-pbx-a9 vexpress-a9 vexpress-a15 xilinx-zynq-a9 Cc: Peter Maydell Cc: "Edgar E. Iglesias" Cc: Alistair Francis Cc: qemu-arm@nongnu.org Signed-off-by: Markus Armbruster Reviewed-by: Thomas Huth Reviewed-by: Alistair Francis --- hw/arm/realview.c | 1 - hw/arm/vexpress.c | 1 - hw/arm/xilinx_zynq.c | 1 - 3 files changed, 3 deletions(-) diff --git a/hw/arm/realview.c b/hw/arm/realview.c index 8eafcca..8c11c7a 100644 --- a/hw/arm/realview.c +++ b/hw/arm/realview.c @@ -443,7 +443,6 @@ static void realview_pbx_a9_class_init(ObjectClass *oc,= void *data) =20 mc->desc =3D "ARM RealView Platform Baseboard Explore for Cortex-A9"; mc->init =3D realview_pbx_a9_init; - mc->block_default_type =3D IF_SCSI; mc->max_cpus =3D 4; } =20 diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c index e057568..c6b1e67 100644 --- a/hw/arm/vexpress.c +++ b/hw/arm/vexpress.c @@ -752,7 +752,6 @@ static void vexpress_class_init(ObjectClass *oc, void *= data) =20 mc->desc =3D "ARM Versatile Express"; mc->init =3D vexpress_common_init; - mc->block_default_type =3D IF_SCSI; mc->max_cpus =3D 4; } =20 diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index 7dac20d..3985356 100644 --- a/hw/arm/xilinx_zynq.c +++ b/hw/arm/xilinx_zynq.c @@ -323,7 +323,6 @@ static void zynq_machine_init(MachineClass *mc) { mc->desc =3D "Xilinx Zynq Platform Baseboard for Cortex-A9"; mc->init =3D zynq_init; - mc->block_default_type =3D IF_SCSI; mc->max_cpus =3D 1; mc->no_sdcard =3D 1; } --=20 2.7.4