[Qemu-devel] [PATCH v7 0/2] docs: Improve sample configuration files

Andrea Bolognani posted 2 patches 163 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1486747506-15876-1-git-send-email-abologna@redhat.com
Test checkpatch passed
Test docker passed
Test s390x passed
docs/mach-virt-graphical.cfg  | 281 +++++++++++++++++++++++++++++++++++++++++
docs/mach-virt-serial.cfg     | 243 +++++++++++++++++++++++++++++++++++
docs/q35-chipset.cfg          | 152 ----------------------
docs/q35-emulated.cfg         | 288 ++++++++++++++++++++++++++++++++++++++++++
docs/q35-virtio-graphical.cfg | 248 ++++++++++++++++++++++++++++++++++++
docs/q35-virtio-serial.cfg    | 193 ++++++++++++++++++++++++++++
6 files changed, 1253 insertions(+), 152 deletions(-)
create mode 100644 docs/mach-virt-graphical.cfg
create mode 100644 docs/mach-virt-serial.cfg
delete mode 100644 docs/q35-chipset.cfg
create mode 100644 docs/q35-emulated.cfg
create mode 100644 docs/q35-virtio-graphical.cfg
create mode 100644 docs/q35-virtio-serial.cfg

[Qemu-devel] [PATCH v7 0/2] docs: Improve sample configuration files

Posted by Andrea Bolognani 163 weeks ago
Changes since [v6]

  * Address review comments:
    - re-introduce optical media support;
    - rename PCIe Root Ports from pci.* to pcie.*;
    - remove reference to GTK+.

Changes since [v5]

  * Address review comments:
    - use the native serial console rather than the VirtIO
      based one, and enable monitor multiplexing so that
      the user can switch between the two;
    - add GIC version configuration;
    - improve wording all over the place.

  * Improvements:
    - add information about Debian/Ubuntu firmware
      packages.

Changes since [v4]

  * Improvements:
    - move storage configuration from the command line
      to the configuration files so that the command
      line is shorter and we can provide better
      documentation for the various parts;
    - configure the amount of memory for the guest in
      the file too;
    - document the fact that you might want/need to use
      '-serial stdio' and '-display vnc=...' in some
      situations;
    - fix the value of 'port' for one of the
      pcie-root-port devices;
    - fix some inaccurate comments.

  * Arguably the opposite:
    - remove the sample command line for running a live
      OS from the file header. I could be convinced to
      add it back as a (commented) section about it, if
      people think it's useful enough.

Changes since [v3]

  * Address review comments:
    - place VGA at 00:01.0;
    - use pcie-root-port instead of ioh3420 in
      q35-virtio-*.cfg;
    - add a comment to let users know that PCI Express
      devices should not be placed on the legacy PCI
      bridge.

Changes since [v2]

  * Address review comments:
    - use -nodefaults in q35-emulated.cfg too;
    - add explicit VGA and Ethernet.

  * Improvements:
    - use virtconsole and virtio-serial instead of
      isa-serial in q35-virtio-serial.cfg.

  * Possibily controversial:
    - get rid of q35-virtio-common.cfg and add the PCIe
      Root Ports back into q35-virtio-*.cfg: while this
      leads to having some duplicated content, I feel like
      the sample configurations are much more useful when
      they can stand entirely on their own, especially now
      that they start with a detailed hardware listing.

  * Cosmetic stuff:
    - hardware listing looks like the output of lspci;
    - section names match what's used in the hardware
      listing so it's faster to jump to the section;
    - PCI addresses also match the output of lspci;
    - PCI Express is used instead of PCIe.

Changes since [v1]

  * Address review comments:
    - improve the existing configuration file instead
      of removing it;
    - split off the common part for VirtIO guests;
    - plug all ioh3420 devices in a single slot;
    - use slot 1c for ioh3420 devices;
    - remove useless USB keyboard.

  * Improve usage description:
    - make sure the OS disk actually uses the VirtIO
      SCSI controller, as intended, rather than the
      built-in SATA one;
    - provide a command line for running live CDs.

  * Document more devices:
    - the video card is added by default;
    - so is the Ethernet adapter, apparently.

[v1] http://lists.nongnu.org/archive/html/qemu-devel/2017-01/msg06342.html
[v2] http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg00184.html
[v3] http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg00461.html
[v4] http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg00672.html
[v5] http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg01714.html
[v6] http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg02206.html

Andrea Bolognani (2):
  q35: Improve sample configuration files
  mach-virt: Provide sample configuration files

 docs/mach-virt-graphical.cfg  | 281 +++++++++++++++++++++++++++++++++++++++++
 docs/mach-virt-serial.cfg     | 243 +++++++++++++++++++++++++++++++++++
 docs/q35-chipset.cfg          | 152 ----------------------
 docs/q35-emulated.cfg         | 288 ++++++++++++++++++++++++++++++++++++++++++
 docs/q35-virtio-graphical.cfg | 248 ++++++++++++++++++++++++++++++++++++
 docs/q35-virtio-serial.cfg    | 193 ++++++++++++++++++++++++++++
 6 files changed, 1253 insertions(+), 152 deletions(-)
 create mode 100644 docs/mach-virt-graphical.cfg
 create mode 100644 docs/mach-virt-serial.cfg
 delete mode 100644 docs/q35-chipset.cfg
 create mode 100644 docs/q35-emulated.cfg
 create mode 100644 docs/q35-virtio-graphical.cfg
 create mode 100644 docs/q35-virtio-serial.cfg

-- 
2.7.4