From nobody Sun May 5 13:04:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; Return-Path: Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mx.zohomail.com with SMTPS id 1486146334422330.38186719596797; Fri, 3 Feb 2017 10:25:34 -0800 (PST) Received: from localhost ([::1]:36284 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZiY6-0004hq-RU for importer@patchew.org; Fri, 03 Feb 2017 13:25:30 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZiX3-00044t-2T for qemu-devel@nongnu.org; Fri, 03 Feb 2017 13:24:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZiX2-0000iy-0t for qemu-devel@nongnu.org; Fri, 03 Feb 2017 13:24:25 -0500 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:48396) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cZiX1-0000iV-Px for qemu-devel@nongnu.org; Fri, 03 Feb 2017 13:24:23 -0500 Received: from pm215 by orth.archaic.org.uk with local (Exim 4.84_2) (envelope-from ) id 1cZiWy-0002hw-Oy; Fri, 03 Feb 2017 18:24:20 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 3 Feb 2017 18:24:20 +0000 Message-Id: <1486146260-8092-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:8b0:1d0::2 Subject: [Qemu-devel] [PATCH] ui/vnc: Drop unused vnc_has_job() and vnc_jobs_clear() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Gerd Hoffmann , patches@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The functions vnc_has_job() and vnc_jobs_clear() are never used; remove them. Signed-off-by: Peter Maydell Reviewed-by: Gonglei --- I last had a go at this five years ago: http://patchwork.ozlabs.org/patch/192335/ Since then vnc_stop_worker_thread() got removed anyway in commit 09526058d, but the vnc_jobs_clear() function that it was the only caller of got left behind. vnc_has_job() has never been used by anybody, and it's impossible to use in a non-racy way, so drop it too. ui/vnc-jobs.h | 2 -- ui/vnc-jobs.c | 23 ----------------------- 2 files changed, 25 deletions(-) diff --git a/ui/vnc-jobs.h b/ui/vnc-jobs.h index 044bf9f..59f66bc 100644 --- a/ui/vnc-jobs.h +++ b/ui/vnc-jobs.h @@ -34,8 +34,6 @@ VncJob *vnc_job_new(VncState *vs); int vnc_job_add_rect(VncJob *job, int x, int y, int w, int h); void vnc_job_push(VncJob *job); -bool vnc_has_job(VncState *vs); -void vnc_jobs_clear(VncState *vs); void vnc_jobs_join(VncState *vs); =20 void vnc_jobs_consume_buffer(VncState *vs); diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c index 98ca978..f786777 100644 --- a/ui/vnc-jobs.c +++ b/ui/vnc-jobs.c @@ -128,29 +128,6 @@ static bool vnc_has_job_locked(VncState *vs) return false; } =20 -bool vnc_has_job(VncState *vs) -{ - bool ret; - - vnc_lock_queue(queue); - ret =3D vnc_has_job_locked(vs); - vnc_unlock_queue(queue); - return ret; -} - -void vnc_jobs_clear(VncState *vs) -{ - VncJob *job, *tmp; - - vnc_lock_queue(queue); - QTAILQ_FOREACH_SAFE(job, &queue->jobs, next, tmp) { - if (job->vs =3D=3D vs || !vs) { - QTAILQ_REMOVE(&queue->jobs, job, next); - } - } - vnc_unlock_queue(queue); -} - void vnc_jobs_join(VncState *vs) { vnc_lock_queue(queue); --=20 2.7.4