[PATCH] configure: Fix gio detection

Cole Robinson posted 1 patch 3 years, 4 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1249e3b862a119bdcba74f8f052222cc28de988d.1604588274.git.crobinso@redhat.com
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] configure: Fix gio detection
Posted by Cole Robinson 3 years, 4 months ago
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 2c3c69f118..bc06aa81e5 100755
--- a/configure
+++ b/configure
@@ -3499,7 +3499,7 @@ if $pkg_config --atleast-version=$glib_req_ver gio-2.0; then
     # with pkg-config --static --libs data for gio-2.0 that is missing
     # -lblkid and will give a link error.
     write_c_skeleton
-    if compile_prog "" "gio_libs" ; then
+    if compile_prog "" "$gio_libs" ; then
         gio=yes
     else
         gio=no
-- 
2.28.0


Re: [PATCH] configure: Fix gio detection
Posted by Marc-André Lureau 3 years, 4 months ago
Hi

On Thu, Nov 5, 2020 at 6:58 PM Cole Robinson <crobinso@redhat.com> wrote:
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 2c3c69f118..bc06aa81e5 100755
> --- a/configure
> +++ b/configure
> @@ -3499,7 +3499,7 @@ if $pkg_config --atleast-version=$glib_req_ver gio-2.0; then
>      # with pkg-config --static --libs data for gio-2.0 that is missing
>      # -lblkid and will give a link error.
>      write_c_skeleton
> -    if compile_prog "" "gio_libs" ; then
> +    if compile_prog "" "$gio_libs" ; then
>          gio=yes
>      else
>          gio=no

it's queued already "[PULL 12/20] configure: fix gio_libs reference"

thanks