From nobody Sun Feb 8 17:13:08 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=web.de ARC-Seal: i=1; a=rsa-sha256; t=1603911114; cv=none; d=zohomail.com; s=zohoarc; b=c4jK6OZVHssJKWgS+R6OTpwvjDc2ZWJxjjatH8oERofVkqS2Cm2boNKcNtwE7QUj9M20EjwWww24xMoGcgmQN11HF3KnCybSRdOAY3aVdCJ/XzjbfXBw81J57xtB9d487IKbV2C1iiRuxgqAcayDLVcTMO5+RRkEs/kIWSOFkx0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603911114; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Q9cObm7kMdFLF3F88Pdlb/F2P2IVv9trZA706gcGkKw=; b=RQkKU+tUTWYlmV32juF+K2Q3h4WVXvY656AeqPXInWD6aMLeDUohiyoYEc7/yqSwA/J6SqUFJIBKDINeuQcJAnnS2hHgsD78j95TfPp1BjiuDvghX5zdXmSed0j6i+Xz3qsnGYFEFWGSEAdhYhrzeS6HOqKdtKqHgeV8ii9yR20= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603911114406779.8826196277846; Wed, 28 Oct 2020 11:51:54 -0700 (PDT) Received: from localhost ([::1]:53430 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXqY4-0005w6-T1 for importer@patchew.org; Wed, 28 Oct 2020 14:51:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXqSC-0000Oa-Rz; Wed, 28 Oct 2020 14:45:49 -0400 Received: from mout.web.de ([217.72.192.78]:36183) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXqSB-0003JH-0U; Wed, 28 Oct 2020 14:45:48 -0400 Received: from luklap ([94.134.180.124]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LlWGZ-1jzssU05xf-00bILd; Wed, 28 Oct 2020 19:45:41 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1603910741; bh=iohBE2TsRUHqlaHAZq3nAbb6MbYyYQk71IzJEZLd1Ag=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References; b=il8Tjkz2a0hFfBrpQDmrh6/6+wfRRVRZRz6jdFjqckTdczqjQEZ825FuCAk+npQtv h2veRZx2Ek2n8xtVEzflXzcPNvRV/1H6RpnHDkIaCstVvVOevb9PTB5/4ScoX6SrsD dDShMYhmkCMheUurNzWp0BAODoNBNAd8E/H1hJ/w= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Date: Wed, 28 Oct 2020 19:45:39 +0100 From: Lukas Straub To: qemu-devel Subject: [PATCH v9 6/8] io: Document qmp oob suitability of qio_channel_shutdown and io_shutdown Message-ID: <10e56f6d30fca6dcb75c0be8ed605bbbe2b0fec7.1603909658.git.lukasstraub2@web.de> In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/sLb18prFuGqp30VaG6BeDue"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Provags-ID: V03:K1:Ds90NGIY5RZLKXGb9z0vHscFNsktlAKePLSk1mem/xVbZkl98Lg JXsilk42eQlEF44Y85OK1aPq2ISLW9RMYo3lZ7SDkFlqt/orjBTBEy8NJuIXI/fc4IYVCmg 5XcCURhzzHJiwq5cfy8RorX3P3kC6QS206zqN/dO3iAj5CGcIe/9xthk9EP0H0jE/eLUk3D KEILFCwxJSItZGQRcT/hA== X-UI-Out-Filterresults: notjunk:1;V03:K0:CC4KGKQ7peY=:fFoliSV4iffELOMD6EwQ1k 6oiIoUbumlg8l5EznCeRc+a4M0o3s6qziAkDgHfCxs2qKqupScPsXcmgTMl6oiiRa6Vsu6XvC 2Ozz5qaINk06DgCMwgWAlPgcOE/4DYUeC5M/5omRHK8cgBD6nAiMFMHMGEk4f2bcYmCtd1JHS MH3WArFMb5cYC7BhEiunaVte9nCSiMDtzt/4J+2P3UCaMr0PoLmbP0ctmjrsmx/2Xbundxkkc uNndVCTwvygvv9FdRsq031OZa63kWFKNIeRQG75YXJAaoBDUx5dfHAmWKrSQayrw7/R98kUdf nIMEhKsTydqikdD4XlC8KtbsT0uJUvFSWGp4u2K3twaMJMW7TthgIiclbRIyrzn5p5loJCjvF KVlXDGRRnjUzyXZW0hsITLeIhJ92bl0HxbioXvIyyd+3sVZoCaQMPaKmnDGjOD9mFnWB5v7C6 lPoI+ygjPAUH064WoePyOQ7W+MZ/eLKUtsWQtyCZtqZZJm9E1piRnGfamrG/QrHEHboqn+jO1 cmIS8/NzWLzIgVjQTOlWdz0NYkZiViEMdoRM7tvntmVKdK3bY4yHUMhPTwIjsMEqakVhDtXLy dvbX0oK4BwMEh+HxLXsXBexDv1CVsi0EMBWwv5D4uJd9pcqu4kS/9+XopyhK4ISh/V/YzlkfI elyO79RK9TSp9chw5GB3dyZ6IirJrpN7D0UyBq0aOz3zTP4wi10/MkCGZlmYP6sXXx6t+xr7K iSbAUxg6qwsQtx5toqESlEJb5g+xy72zh3dGQKrtKSFF+3KOPkMEkRez9EG9/MXnEuqm44Boq GwARq3YBXR6PLJkYTY8YuPlj89zBKHlqWJiHGGMMLFe0bPhL4ld1xEOMu9WCwE6AYP+XYUiQg tCX3s7Mh6mQs6i8u/djA== Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=217.72.192.78; envelope-from=lukasstraub2@web.de; helo=mout.web.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 13:12:59 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Daniel P. =?UTF-8?B?QmVycmFuZ8Op?=" , qemu-block , Juan Quintela , Markus Armbruster , "Dr. David Alan Gilbert" , Max Reitz , Paolo Bonzini , =?UTF-8?B?TWFyYy1BbmRy?= =?UTF-8?B?w6k=?= Lureau Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-Zoho-Virus-Status: 1 X-ZohoMail-DKIM: fail (Header signature does not verify) --Sig_/sLb18prFuGqp30VaG6BeDue Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Migration and yank code assume that qio_channel_shutdown is thread -safe and can be called from qmp oob handler. Document this after checking the code. Signed-off-by: Lukas Straub Acked-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrang=C3=A9 --- include/io/channel.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/io/channel.h b/include/io/channel.h index 3c04f0edda..e0b9fc615d 100644 --- a/include/io/channel.h +++ b/include/io/channel.h @@ -92,7 +92,8 @@ struct QIOChannel { * provide additional optional features. * * Consult the corresponding public API docs for a description - * of the semantics of each callback + * of the semantics of each callback. io_shutdown in particular + * must be thread-safe, terminate quickly and must not block. */ struct QIOChannelClass { ObjectClass parent; @@ -510,6 +511,8 @@ int qio_channel_close(QIOChannel *ioc, * QIO_CHANNEL_FEATURE_SHUTDOWN prior to calling * this method. * + * This function is thread-safe, terminates quickly and does not block. + * * Returns: 0 on success, -1 on error */ int qio_channel_shutdown(QIOChannel *ioc, -- 2.20.1 --Sig_/sLb18prFuGqp30VaG6BeDue Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEg/qxWKDZuPtyYo+kNasLKJxdslgFAl+ZvFMACgkQNasLKJxd slgfnBAAm4EzJtCrG+SexTdcCJzKOCZTfaBNe2IR6jtDN5kFVykaRkSavwDy9xWP HZaH+yADFC/t77WbOWTTNNvgBtlLNzVdFDRwMuampSRjo2uCQHntJDllYA2FQysD cFL0vC+LKCvrPbMgi3+EED7mMTQLIVQ8JnGcnchQSJ4PCSxu1cFtOvUgAjT6fNPM LIMiav3YHS3YG0tJiWq3LGt9UdKtIvfYcDVPQRGkYs1zoqIBwQwGFzTi+l888LdC +hAk9mra/+V5ERb5TufpaJZh5oF4Ev4LcDD3bT5PsXG48UKjMqFzXbhfELRvl/r3 INBPdm9+Z2zjh+vnxFkukBWNHTxpE+s8QP1RgLQVYUeQmC5dIzZyis7pjwpovon+ Glv601ib5Q/Dw0eYO/TJWmmWbr1u0Ir/UWGuv9hVpWXnuEiiERgjAxHodfVNwLLc FlC9Ztpo+gKZnhkhtvDURotTMT6XbbO1hb2PW4y9wkiq1GGzFEmT8U1S5VPLBFXO 7vneOBCZcRvV3SkcwK8WQ2Fb8hGrpXZLaUtArmHW87XdS0W3JvJWJz2qlIJHpIlH ToueV4S+V1HSLJDJprM+Etc92NOP101TIHolOyZvhfZBmN5qvqnCBl72ct6tq2q6 KUqByO6dqCX9MOW+I5Ja0PkJ3msScOE8ZejrT5bmd0uP7IKeQtA= =1VfW -----END PGP SIGNATURE----- --Sig_/sLb18prFuGqp30VaG6BeDue--