From nobody Sat Nov 15 22:37:26 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1747223771; cv=none; d=zohomail.com; s=zohoarc; b=NH0yKYPbJMQSYL2J2lSNbjiv80r3w7aNwirDnELJET8SlVusyyr2Cr2Q3ms3pDaTci2nRxI/EbbU8LdpqRroGHZ7qrBMKR30UvhjYnE0fDrgMu02BYax9Hfy3gbCC4k/PS8mMg2kPjSHUQ+a0CSg2iN2JUAqMmtqyNRk9sYsxEo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1747223771; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=o3VTGXmHpKQX+xxI8x7d0AGiDNhIqUOHSWtPCL/LLDE=; b=Ool+JjVCJs2ULvQ6NXDldrMJkZXtqL9LAHp29y/mlV+Cub2vS8kV+fRNb7aN1/ST1ltkiZU5WTqxkcs1IzRE3bGY7XqxkwFbH835zom/lmI++MNFJjicFNqy98ykrXHsvqb9rLlo6mqnvCVwhAI8DdL7h5bmEPUdYoGfkSJYUS8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1747223771053594.1306805594314; Wed, 14 May 2025 04:56:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uFAd8-0005pF-5P; Wed, 14 May 2025 07:50:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uFAd5-0005ol-57 for qemu-devel@nongnu.org; Wed, 14 May 2025 07:50:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uFAd2-00062K-1n for qemu-devel@nongnu.org; Wed, 14 May 2025 07:50:30 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-GDDmSUsoPj6v1J6Yprl72Q-1; Wed, 14 May 2025 07:50:24 -0400 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43cf44b66f7so39046575e9.1 for ; Wed, 14 May 2025 04:50:24 -0700 (PDT) Received: from redhat.com ([2a0d:6fc0:1517:1000:ea83:8e5f:3302:3575]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442ebda7d2csm34609005e9.3.2025.05.14.04.50.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 May 2025 04:50:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747223425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o3VTGXmHpKQX+xxI8x7d0AGiDNhIqUOHSWtPCL/LLDE=; b=MuFG+r3Y2+kKDnQnsZ9C0m0E5wf71ppSyEio9j62wd9kwBFcgFzD2lBaGV5URAUnuchZrd WPPh7b3rc8qKjU5h9UVLR9e3SSHFWVI0k+vLscQo/gt1AFfbhNOtFDOh2CGv9pizSLX8te EVWIV+HC4+lsp5QkABkALuB9Ng1mq1g= X-MC-Unique: GDDmSUsoPj6v1J6Yprl72Q-1 X-Mimecast-MFC-AGG-ID: GDDmSUsoPj6v1J6Yprl72Q_1747223424 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747223423; x=1747828223; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o3VTGXmHpKQX+xxI8x7d0AGiDNhIqUOHSWtPCL/LLDE=; b=mHh6dsLPmeGY6qTpxGXE28NRR6MFVxV3oqZHv3o/UI25YQc9jUYO61HerAOaDkpcKS vrxRuAujdY3vPDUibDm7Pg0ndkdYATlx3881xsmfv4vfBYo7+8pn07E2SKuFgavcX2EH O6dnl/Pl1Isq2GOzXF8SiORxtXojHObEDMhKntt84SG7QFd9Qw+LO9iz9joQITP4+Xae pWrvvKLceFXW9qeol1+J1DQHuzC7wUUthKX5rD80h6D3CGIo3FpUaZPZx2yQ9K568y5t zSATVJUeKhCyBm3KeToDHAJSxHfapAkTcwAktTkOpbFqZfxT7qjnxvn05ffavFq42Gkc c/Gg== X-Gm-Message-State: AOJu0Yz3flsGhCq8UujW+oCOg2knfoU1AXiIX7GyLfAA1Jti9q+3M3bi StIlUijRDKNcCbYA5JKz/tt9EEvRItqFErfevxxwqKTzhhhrFaN4sgkXWHEUIzmRaAlGO4BlqLa IRe9XQvYx3/KqeZ8y+vcvs9XPRkfZIFoCs+43FD8xxc/pPFks2rfVF0PD+7czChj4NDmLKL1RCY cLu871GV6ED7RnGgbV4qd8KUAjsE7EeQ== X-Gm-Gg: ASbGncvvLW8Ef9svUj+/dVETJvYsE+kGGh600Rpf5ZArE7o/Or5uXl1tQJv2nENa8d7 dVSjWPXPBmqailo6wgqW4sihxSS4sdcBczoEZcQmjcg6nlZQhzgLOgMUUp8c+T9scjocx+pGEgu JlmLnaqppWBb7/02T7ao2gWDQ/v8dZJNnml4B42rgOtcCitoxwBWHRd+rJs7mYwiAe9iXXyL9g7 LKjjLAVhgjdO6SCwkW7vYyRNvSGL9Gz280BHwSKo0jvLyHBMTOh+rTIvEmPGsVql4ia5IH1/gFT Ts9HOw== X-Received: by 2002:a05:600c:3b02:b0:442:dc75:5625 with SMTP id 5b1f17b1804b1-442f20bb658mr29380905e9.5.1747223423117; Wed, 14 May 2025 04:50:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH9OtKNXwEwIwOe42LtWVOzShCbOdu1QuoGq1FdmQpKQxfmA/JJfwXM9mHoFwLYp9tl2KXb7Q== X-Received: by 2002:a05:600c:3b02:b0:442:dc75:5625 with SMTP id 5b1f17b1804b1-442f20bb658mr29380655e9.5.1747223422736; Wed, 14 May 2025 04:50:22 -0700 (PDT) Date: Wed, 14 May 2025 07:50:20 -0400 From: "Michael S. Tsirkin" To: qemu-devel@nongnu.org Cc: Peter Maydell , Davidlohr Bueso , Fan Ni , Jonathan Cameron Subject: [PULL 02/27] hw/cxl: Support get/set mctp response payload size Message-ID: <1000158f031818bf286454c8691da9b4f33c4d02.1747223385.git.mst@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.686, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1747223771436116600 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Davidlohr Bueso Add Get/Set Response Message Limit commands. Signed-off-by: Davidlohr Bueso Reviewed-by: Fan Ni Signed-off-by: Jonathan Cameron Message-Id: <20250305092501.191929-3-Jonathan.Cameron@huawei.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/cxl/cxl-mailbox-utils.c | 58 ++++++++++++++++++++++++++++++++++++-- 1 file changed, 56 insertions(+), 2 deletions(-) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c index 4401f446d9..bd25df033a 100644 --- a/hw/cxl/cxl-mailbox-utils.c +++ b/hw/cxl/cxl-mailbox-utils.c @@ -7,6 +7,8 @@ * COPYING file in the top-level directory. */ =20 +#include + #include "qemu/osdep.h" #include "hw/pci/msi.h" #include "hw/pci/msix.h" @@ -56,6 +58,8 @@ enum { INFOSTAT =3D 0x00, #define IS_IDENTIFY 0x1 #define BACKGROUND_OPERATION_STATUS 0x2 + #define GET_RESPONSE_MSG_LIMIT 0x3 + #define SET_RESPONSE_MSG_LIMIT 0x4 #define BACKGROUND_OPERATION_ABORT 0x5 EVENTS =3D 0x01, #define GET_RECORDS 0x0 @@ -413,12 +417,58 @@ static CXLRetCode cmd_infostat_identify(const struct = cxl_cmd *cmd, is_identify->component_type =3D 0x3; /* Type 3 */ } =20 - /* TODO: Allow this to vary across different CCIs */ - is_identify->max_message_size =3D 9; /* 512 bytes - MCTP_CXL_MAILBOX_B= YTES */ + is_identify->max_message_size =3D (uint8_t)log2(cci->payload_max); *len_out =3D sizeof(*is_identify); return CXL_MBOX_SUCCESS; } =20 +/* CXL r3.1 section 8.2.9.1.3: Get Response Message Limit (Opcode 0003h) */ +static CXLRetCode cmd_get_response_msg_limit(const struct cxl_cmd *cmd, + uint8_t *payload_in, + size_t len_in, + uint8_t *payload_out, + size_t *len_out, + CXLCCI *cci) +{ + struct { + uint8_t rsp_limit; + } QEMU_PACKED *get_rsp_msg_limit =3D (void *)payload_out; + QEMU_BUILD_BUG_ON(sizeof(*get_rsp_msg_limit) !=3D 1); + + get_rsp_msg_limit->rsp_limit =3D (uint8_t)log2(cci->payload_max); + + *len_out =3D sizeof(*get_rsp_msg_limit); + return CXL_MBOX_SUCCESS; +} + +/* CXL r3.1 section 8.2.9.1.4: Set Response Message Limit (Opcode 0004h) */ +static CXLRetCode cmd_set_response_msg_limit(const struct cxl_cmd *cmd, + uint8_t *payload_in, + size_t len_in, + uint8_t *payload_out, + size_t *len_out, + CXLCCI *cci) +{ + struct { + uint8_t rsp_limit; + } QEMU_PACKED *in =3D (void *)payload_in; + QEMU_BUILD_BUG_ON(sizeof(*in) !=3D 1); + struct { + uint8_t rsp_limit; + } QEMU_PACKED *out =3D (void *)payload_out; + QEMU_BUILD_BUG_ON(sizeof(*out) !=3D 1); + + if (in->rsp_limit < 8 || in->rsp_limit > 10) { + return CXL_MBOX_INVALID_INPUT; + } + + cci->payload_max =3D 1 << in->rsp_limit; + out->rsp_limit =3D in->rsp_limit; + + *len_out =3D sizeof(*out); + return CXL_MBOX_SUCCESS; +} + static void cxl_set_dsp_active_bm(PCIBus *b, PCIDevice *d, void *private) { @@ -3105,6 +3155,10 @@ void cxl_initialize_t3_ld_cci(CXLCCI *cci, DeviceSta= te *d, DeviceState *intf, =20 static const struct cxl_cmd cxl_cmd_set_t3_fm_owned_ld_mctp[256][256] =3D { [INFOSTAT][IS_IDENTIFY] =3D { "IDENTIFY", cmd_infostat_identify, 0, 0= }, + [INFOSTAT][GET_RESPONSE_MSG_LIMIT] =3D { "GET_RESPONSE_MSG_LIMIT", + cmd_get_response_msg_limit, 0, = 0 }, + [INFOSTAT][SET_RESPONSE_MSG_LIMIT] =3D { "SET_RESPONSE_MSG_LIMIT", + cmd_set_response_msg_limit, 1, = 0 }, [LOGS][GET_SUPPORTED] =3D { "LOGS_GET_SUPPORTED", cmd_logs_get_support= ed, 0, 0 }, [LOGS][GET_LOG] =3D { "LOGS_GET_LOG", cmd_logs_get_log, 0x18, 0 }, --=20 MST