From nobody Tue Nov 18 09:08:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1609033055; cv=none; d=zohomail.com; s=zohoarc; b=PVXx11U4p/uE35XTdSw2eQ93aXabjYrlFXTxckx3a801Xs4AH+aUrQ94WVZDdANUZ04R/w8uF29rzvqdlthOMSskuvL/IrYCHCIr7o7wWqd7m5NVkVyYZPHdD8/hgakix9XjMdS8TYvaDKe8Z2iIY0kyvvYee9bpN37emXwWE+w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609033055; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=UiC/GMk1WJdb4it7JywLCwwvk6a+QhOxijrG9blSa7U=; b=dMmPfSnjoCQ4MmuS8C8SjrQSYGI6/PKb8CMtHcgUJgTlAoZATmpjc1DQ5xXtvBj1r0ir44m+kpMEUtW0SQwO0/IYywLBV8cfGs0UnQ1LiwZ5KQkazTTq2lG4cDTPQV0f7GD726jXJNYGcO9oMG3kAt+AoMUBLtcR1kqPIByh1UU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1609033055747126.52490226720647; Sat, 26 Dec 2020 17:37:35 -0800 (PST) Received: from localhost ([::1]:60174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktL03-0003bh-0m for importer@patchew.org; Sat, 26 Dec 2020 20:37:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktKkY-0008TZ-NV for qemu-devel@nongnu.org; Sat, 26 Dec 2020 20:21:35 -0500 Received: from zero.eik.bme.hu ([152.66.115.2]:61530) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktKkS-0001Dp-R7 for qemu-devel@nongnu.org; Sat, 26 Dec 2020 20:21:34 -0500 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id A40DB7470F7; Sun, 27 Dec 2020 02:21:18 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id F41667470F5; Sun, 27 Dec 2020 02:21:17 +0100 (CET) Message-Id: <0de0e2415076e095479000882df6ff42619eafc8.1609031406.git.balaton@eik.bme.hu> In-Reply-To: References: Subject: [PATCH 12/12] vt82c686: Do not add floppy Date: Sun, 27 Dec 2020 02:10:06 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: qemu-devel@nongnu.org X-Spam-Probability: 8% Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Huacai Chen , f4bug@amsat.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Reply-to: BALATON Zoltan From: BALATON Zoltan via Content-Type: text/plain; charset="utf-8" The floppy is inaccessible because its ports are shadowed by the config registers of the superio part (switchable on the real chip but we don't model that) so disable adding the floppy matching the existing comment in vt82c686b_isa_realize() as it's not usable. Signed-off-by: BALATON Zoltan --- hw/isa/vt82c686.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 698627d1b5..2b7a3bdba1 100644 --- a/hw/isa/vt82c686.c +++ b/hw/isa/vt82c686.c @@ -348,14 +348,19 @@ static const TypeInfo via_isa_info =3D { }, }; =20 +static bool vt82c686b_superio_floppy_is_enabled(ISASuperIODevice *sio, uin= t8_t index) +{ + return false; /* Disabled due to clash with SuperIO Config reg por= ts */ +} + static void vt82c686b_superio_class_init(ObjectClass *klass, void *data) { ISASuperIOClass *sc =3D ISA_SUPERIO_CLASS(klass); =20 sc->serial.count =3D 2; sc->parallel.count =3D 1; - sc->ide.count =3D 0; - sc->floppy.count =3D 1; + sc->ide.count =3D 0; /* Emulated by via-ide */ + sc->floppy.is_enabled =3D vt82c686b_superio_floppy_is_enabled; } =20 static const TypeInfo via_superio_info =3D { --=20 2.21.3