From nobody Mon Feb 9 03:20:08 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=eik.bme.hu Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1635375030584418.1939808064118; Wed, 27 Oct 2021 15:50:30 -0700 (PDT) Received: from localhost ([::1]:43870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfrka-0003MA-Sh for importer@patchew.org; Wed, 27 Oct 2021 18:50:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45658) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfrMc-000830-Hn for qemu-devel@nongnu.org; Wed, 27 Oct 2021 18:25:46 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]:39564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfrMY-0002r3-EG for qemu-devel@nongnu.org; Wed, 27 Oct 2021 18:25:42 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id 3D9A67561AE; Thu, 28 Oct 2021 00:25:17 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 62E127561B9; Thu, 28 Oct 2021 00:25:16 +0200 (CEST) Message-Id: <09bae4fbe771f45c70bf586942ed9324ffb20183.1635371671.git.balaton@eik.bme.hu> In-Reply-To: References: From: BALATON Zoltan Subject: [PATCH v3 18/18] hw/intc/sh_intc: Simplify allocating sources array Date: Wed, 27 Oct 2021 23:54:31 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: qemu-devel@nongnu.org X-Spam-Probability: 8% Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Richard Henderson , Magnus Damm , Yoshinori Sato Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZM-MESSAGEID: 1635375032034100001 Content-Type: text/plain; charset="utf-8" Use g_new0 instead of g_malloc0 and avoid some unneeded temporary variable assignments. Signed-off-by: BALATON Zoltan --- hw/intc/sh_intc.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/hw/intc/sh_intc.c b/hw/intc/sh_intc.c index eb58707e83..ed0a5f87cc 100644 --- a/hw/intc/sh_intc.c +++ b/hw/intc/sh_intc.c @@ -400,21 +400,14 @@ int sh_intc_init(MemoryRegion *sysmem, /* Allocate 4 MemoryRegions per register (2 actions * 2 aliases) */ desc->iomem_aliases =3D g_new0(MemoryRegion, (nr_mask_regs + nr_prio_regs) * 4); - - j =3D 0; - i =3D sizeof(struct intc_source) * nr_sources; - desc->sources =3D g_malloc0(i); - + desc->sources =3D g_new0(struct intc_source, nr_sources); for (i =3D 0; i < desc->nr_sources; i++) { - struct intc_source *source =3D &desc->sources[i]; - - source->parent =3D desc; + desc->sources[i].parent =3D desc; } - desc->irqs =3D qemu_allocate_irqs(sh_intc_set_irq, desc, nr_sources); memory_region_init_io(&desc->iomem, NULL, &sh_intc_ops, desc, "intc", 0x100000000ULL); - + j =3D 0; if (desc->mask_regs) { for (i =3D 0; i < desc->nr_mask_regs; i++) { struct intc_mask_reg *mr =3D &desc->mask_regs[i]; --=20 2.21.4