From nobody Mon Feb 9 03:14:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1562698203; cv=none; d=zoho.com; s=zohoarc; b=cMpiMWZLbDSo4QxEl9gWHfYx55IseDPj+dOZ+JYaA0+tuatb5Yxxs+ayPEFUpWmz6WGgEbv1iQIcdJ4+oC9WNo1FH5tLhJzeDc0KaQs2tKtGXDesou214CHpoIQIO25EdYnZqthjxz+ztmLsysFk+wH3oet2MYaPGwQdFhD6lxo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1562698203; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=NFsbZz+vSV0dR/VsuT/cDCHXS4Tsui+1Dr2/Nb0Mgqg=; b=nTcCpOeHcSUWZuAt4GtGZqRiE4H/k2eM06cwbtow2XO+hbByR4tyUvc/qkKJF97t3TtHXwtC4R1AYM0m0BBOvRKeiiPWnuR/+zAR2RuEYMg3is4LgB2euyC4jHVrH/M9+M1KcH1qeMgcbf5sFpTDZZ7c0dYAWTSBcF/dLs6uUGo= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1562698203366810.606357555593; Tue, 9 Jul 2019 11:50:03 -0700 (PDT) Received: from localhost ([::1]:52810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkvBf-0002E8-CX for importer@patchew.org; Tue, 09 Jul 2019 14:49:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36763) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkuyK-00049o-Ma for qemu-devel@nongnu.org; Tue, 09 Jul 2019 14:36:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkuyJ-0003d1-Kx for qemu-devel@nongnu.org; Tue, 09 Jul 2019 14:36:12 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:44087) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hkuyH-0003Wk-IQ for qemu-devel@nongnu.org; Tue, 09 Jul 2019 14:36:09 -0400 Received: by mail-wr1-x441.google.com with SMTP id p17so10938166wrf.11 for ; Tue, 09 Jul 2019 11:36:00 -0700 (PDT) Received: from nullptr.home.dirty-ice.org (2a01-036c-0113-6e3f-0000-0000-0000-0005.pool6.digikabel.hu. [2a01:36c:113:6e3f::5]) by smtp.gmail.com with ESMTPSA id c12sm20565042wrd.21.2019.07.09.11.35.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jul 2019 11:35:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NFsbZz+vSV0dR/VsuT/cDCHXS4Tsui+1Dr2/Nb0Mgqg=; b=C/aEUY13tH+RUJjvY1OOH0juF7fjzi46PDZvZUDdmMSbBkXGcpszvl3SQDzLeAFvor E8oOhbadbXuXb67BcWoxqtrlxypfrnhOAUco+/QRfvrFaf2iZDElFbQgtzHo1wRaTgbM dce613cTwQaGOaRDeOt2pR4P6vWxIUnbgrVdu+PBnIatCjABVxfGMAP1Kcj2CRLmQu30 TtYM0nYg7p8fI/D/KNy9wmjLskmpxud62rrOd48C8cJJU/y1IQpt7ssNJLQbWN4z7Vxw J10UuUHIXtXyV/jQKIxWnQXUkB92DkKatF9xrU0Vs9iJQwmDsfqylbx6qluV9rkls+6S gamQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NFsbZz+vSV0dR/VsuT/cDCHXS4Tsui+1Dr2/Nb0Mgqg=; b=sKm/3T0Lvi9robNfyg1ZnYs/D9834ZIrZkzHCDgiJQNFNnuXlonXjwP6fjnyW6txR0 j/hW3jH/jvf+eRLOr7oEOEcijvsU9p4ch82nscvwwLGEjXlRMLu13ns/nh4IJ+IquSCG 09Kh12ODwJTqbBBSQ5wUSSyrvr97kRY5xVvr7Xn1kc6Nb1Z5gBaRLS5bkzZ/IIm16Ane zbM03QWCVl9NjN5RoU02nk/NxzeFEAESEKLfEuEl8KzmjRnmFead5nDfcpJN79rLmqBP /OzMfWyTzIgDvoTW5/JyZ3Oozff6qMMI9ZlBVCKG4sPJ8x40jUptY2Ch6DpIUcLXK+ae 96nQ== X-Gm-Message-State: APjAAAUB4juCYxjr8wSR3xdqIABjBz132nmb1zhx3zf9qNFTPFLDxgGe 3Yi0m5mP4BhKbmFREljMcy2zwC/l X-Google-Smtp-Source: APXvYqyzAgmhCSkroi/9G7/n7wu5cPR3XjyX7+JdZ1HraYMYlvbV4zekMdCOYkoiPbAUMAKmRbhVjw== X-Received: by 2002:adf:f98a:: with SMTP id f10mr1281434wrr.250.1562697359785; Tue, 09 Jul 2019 11:35:59 -0700 (PDT) From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?=" X-Google-Original-From: =?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?= To: qemu-devel@nongnu.org Date: Tue, 9 Jul 2019 20:35:49 +0200 Message-Id: <090ab2fb6a10d601e68012b4152c2dba7a902ca4.1562695780.git.DirtY.iCE.hu@gmail.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH 09/11] paaudio: fix playback glitches X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Pulseaudio normally assumes that when the server wants it, the client can generate the audio samples and send it right away. Unfortunately this is not the case with QEMU -- it's up to the emulated system when does it generate the samples. Buffering the samples and sending them from a background thread is just a workaround, that doesn't work too well. Instead enable pa's compatibility support and let pa worry about the details. Signed-off-by: K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n --- audio/paaudio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/audio/paaudio.c b/audio/paaudio.c index 9d46f11b0a..d320d2e453 100644 --- a/audio/paaudio.c +++ b/audio/paaudio.c @@ -512,10 +512,8 @@ static pa_stream *qpa_simple_new ( =20 flags =3D PA_STREAM_INTERPOLATE_TIMING -#ifdef PA_STREAM_ADJUST_LATENCY - | PA_STREAM_ADJUST_LATENCY -#endif - | PA_STREAM_AUTO_TIMING_UPDATE; + | PA_STREAM_AUTO_TIMING_UPDATE + | PA_STREAM_EARLY_REQUESTS; =20 if (dev) { /* don't move the stream if the user specified a sink/source */ --=20 2.22.0