From nobody Sat Feb 7 05:56:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=crudebyte.com ARC-Seal: i=1; a=rsa-sha256; t=1603112714; cv=none; d=zohomail.com; s=zohoarc; b=jQw85xZJXqxdMgaRswq6sPEey2yPj6H25pxyuck1esQad8+n9NCV+FNiNvLYjKufO/wls0mSYQVbHI5/7Ar6QY2eNTw2e8QU9JBufpqcH5Abv3oxjpuzi9EppxDlGtlXA/hGIedgwlXCsRkxfbZUJhN33YsbE5gKmsu37b6Z9uk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1603112714; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=yDG/u17bdmxsKZTdFz3D0Y47pkgPagiwF3adJJ/WwAw=; b=Y61vGi3PHasoOfF7cZPGH36kaRkT9z3V8IdR2w4y3zeX5CA1pHzhJal7CevUNcTLyK4AY+CjKwEvei4fflQwi9f6KeHVh4osQfuFAAyRalfTg6DeYelBBRgURhV1lENwlEWFJIrjzPUGwVlGiRGjiwvr29pAKX7X+0ZbghJ9hpE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1603112714951484.2338589041881; Mon, 19 Oct 2020 06:05:14 -0700 (PDT) Received: from localhost ([::1]:52722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUUqf-0000S1-Sg for importer@patchew.org; Mon, 19 Oct 2020 09:05:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <051f0e5be12b2760d7fb2095b864b26ffe21f6de@lizzy.crudebyte.com>) id 1kUUib-0001KU-7r for qemu-devel@nongnu.org; Mon, 19 Oct 2020 08:56:53 -0400 Received: from lizzy.crudebyte.com ([91.194.90.13]:60589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <051f0e5be12b2760d7fb2095b864b26ffe21f6de@lizzy.crudebyte.com>) id 1kUUiZ-0001E1-Pt for qemu-devel@nongnu.org; Mon, 19 Oct 2020 08:56:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=lizzy; h=Cc:To:Subject:Date:From:References:In-Reply-To: Message-Id:Content-Type:Content-Transfer-Encoding:MIME-Version:Content-ID: Content-Description; bh=yDG/u17bdmxsKZTdFz3D0Y47pkgPagiwF3adJJ/WwAw=; b=nifGL wS8eapJghn4N4zc0fsd4eEF9N6w74BymoWrxQHIfNaOFaQeP4MKwAZ9WnHiOIcL7Rp1zhqJqAS4TJ lkzk5GHIu5McuLYr+42DMjul7IWeAIXZo+BxVt0X7sO6byHzp53TvvnQGx/yEl2OAjhHlLdzh/jMT NEHaE8LCywkkX9v8nauBRdEyrJW7o2STSJFZNW5Rx+3bHMhOM8X2budF58KUUpaJHEh9kniJ1YFy7 /+tlzSAwgqpofJJvcQ0tt0F7SmMtWxNP+ixOt91FFEsVJtQkQNygFzxFb6MiSCZ1rRusHzIyUSvUv cGk3CLvFUjyi6LSW460x3V6+4KZWw==; Message-Id: <051f0e5be12b2760d7fb2095b864b26ffe21f6de.1603111175.git.qemu_oss@crudebyte.com> In-Reply-To: References: From: Christian Schoenebeck Date: Thu, 8 Oct 2020 20:34:56 +0200 Subject: [PULL v3 4/6] tests/9pfs: wipe local 9pfs test directory To: qemu-devel@nongnu.org, Peter Maydell Cc: Greg Kurz Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=91.194.90.13; envelope-from=051f0e5be12b2760d7fb2095b864b26ffe21f6de@lizzy.crudebyte.com; helo=lizzy.crudebyte.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/19 06:27:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: 13 X-Spam_score: 1.3 X-Spam_bar: + X-Spam_report: (1.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_96_XX=3.405, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @crudebyte.com) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Before running the first 9pfs test case, make sure the test directory for running the 9pfs 'local' tests on is entirely empty. For that reason simply delete the test directory (if any) before (re)creating it on test suite startup. Note: The preferable precise behaviour would be the test directory only being wiped once *before* a test suite run. Right now the test directory is also wiped at the *end* of a test suite run because libqos is calling the virtio_9p_register_nodes() callback for some reason also when a test suite completed. This is suboptimal as developers cannot immediately see what files and directories the 9pfs local tests created precisely after the test suite completed. But fortunately the test directory is not wiped if some test failed. So it is probably not worth it drilling another hole into libqos for this issue. Signed-off-by: Christian Schoenebeck Message-Id: Signed-off-by: Christian Schoenebeck --- tests/qtest/libqos/virtio-9p.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/tests/qtest/libqos/virtio-9p.c b/tests/qtest/libqos/virtio-9p.c index ee331166de..8ee2a134bc 100644 --- a/tests/qtest/libqos/virtio-9p.c +++ b/tests/qtest/libqos/virtio-9p.c @@ -53,6 +53,18 @@ static void create_local_test_dir(void) g_assert((st.st_mode & S_IFMT) =3D=3D S_IFDIR); } =20 +/* Deletes directory previously created by create_local_test_dir(). */ +static void remove_local_test_dir(void) +{ + g_assert(local_test_path !=3D NULL); + char *cmd =3D g_strdup_printf("rm -r '%s'\n", local_test_path); + int res =3D system(cmd); + if (res < 0) { + /* ignore error, dummy check to prevent compiler error */ + } + g_free(cmd); +} + static void virtio_9p_cleanup(QVirtio9P *interface) { qvirtqueue_cleanup(interface->vdev->bus, interface->vq, alloc); @@ -230,6 +242,7 @@ static void virtio_9p_register_nodes(void) =20 /* make sure test dir for the 'local' tests exists and is clean */ init_local_test_path(); + remove_local_test_dir(); create_local_test_dir(); =20 QPCIAddress addr =3D { --=20 2.20.1