From nobody Sun May 19 01:42:57 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1670250189; cv=none; d=zohomail.com; s=zohoarc; b=iTB+jWcPEJjQdO17XbwG16nN9wmvBCvJV0gqpNayS6r+WB2iKadFBZMtKFjnXUI9XxVh+3Lg05Eb96TxBqYDPjTSPnjRg40RIeQNhEZEAFlop99OCsgQsy4eT8+YZwLcemdU+2u3kEY2OOdrcMTcn4sr6mTqP2/Gj3N34nvcvWI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670250189; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=58OEIBcQeJPcMhvyxdTx0XkrBPpQEQnoaKkYlgwnDlE=; b=mdUXplcAfAgF3FLol4svH6MhHqtu1CkeCy7xIIRhl2G38ic3BoZ6491o/Ap+/O3joc4J+iY59x4xss/BAsz0WDwMannz/c3iFlttmrepJE6qchoKm47EsMzs6jf0z+m20feQeGUAk1yGj6FmQzC1clJqRwlaR3YbL8rQrFW2oqc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1670250189719296.36550680696394; Mon, 5 Dec 2022 06:23:09 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2CN0-00016H-KW; Mon, 05 Dec 2022 09:22:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p24Zw-0008PQ-24 for qemu-devel@nongnu.org; Mon, 05 Dec 2022 01:03:48 -0500 Received: from szxga01-in.huawei.com ([45.249.212.187]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p24Zt-0001jP-0h for qemu-devel@nongnu.org; Mon, 05 Dec 2022 01:03:47 -0500 Received: from dggpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NQXtf4GWTzqSs0; Mon, 5 Dec 2022 13:59:22 +0800 (CST) Received: from dggpemm500010.china.huawei.com (7.185.36.134) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 5 Dec 2022 14:03:30 +0800 Received: from dggpemm500010.china.huawei.com ([7.185.36.134]) by dggpemm500010.china.huawei.com ([7.185.36.134]) with mapi id 15.01.2375.031; Mon, 5 Dec 2022 14:03:30 +0800 To: "qemu-devel@nongnu.org" , "jasowang@redhat.com" CC: "wangzhigang (O)" , "zhangliang (AG)" Subject: [PATCH] net: Fix qemu crash when hot-pluging a vhost-net failed. Thread-Topic: [PATCH] net: Fix qemu crash when hot-pluging a vhost-net failed. Thread-Index: AdkIXMCHd4gjC00QRBiCtntBSKqU3w== Date: Mon, 5 Dec 2022 06:03:30 +0000 Message-ID: <0357c2371db0438eac0de474db2b8ddc@huawei.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-originating-ip: [10.174.185.41] Content-Type: multipart/mixed; boundary="_004_0357c2371db0438eac0de474db2b8ddchuaweicom_" MIME-Version: 1.0 X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.187; envelope-from=yangming73@huawei.com; helo=szxga01-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 05 Dec 2022 09:22:55 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Yangming From: Yangming via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-Zoho-Virus-Status: 1 X-ZM-MESSAGEID: 1670250191727100003 --_004_0357c2371db0438eac0de474db2b8ddchuaweicom_ Content-Type: multipart/alternative; boundary="_000_0357c2371db0438eac0de474db2b8ddchuaweicom_" --_000_0357c2371db0438eac0de474db2b8ddchuaweicom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Dear all: I found a bug of qemu: hot-pluging a vhost-net may cause virtual machine cr= ash in following steps: 1. Starting a vm without any net device. 2. Hot-pluging 70 memory devices. 3. Hot-pluging a vhost-net device. After the 3rd step, the qemu crashed with following messages: vhost backend memory slots limit is less than current number of present mem= ory slots warning: vhost-net requested but could not be initialized qemu-system-x86_64: ../net/net.c:1106: net_client_init1: Assertion `nc' fai= led. 2022-12-05 03:14:08.794+0000: shutting down, reason=3Dcrashed This commit is used to fix the mentioned problem. It is based on commit a33= c25399f9bc3dcf83064adeba2a82e61bf4608 of master branch. Kind regards. --_000_0357c2371db0438eac0de474db2b8ddchuaweicom_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Dear all:

 

I found a bug of qemu: hot-plug= ing a vhost-net may cause virtual machine crash in following steps:
1. Starting a vm without any net device.
2. Hot-pluging 70 memory devices.
3. Hot-pluging a vhost-net device.

 

After the 3rd step, = the qemu crashed with following messages:

 

vhost backend memory slots limi= t is less than current number of present memory slots

warning: vhost-net requested bu= t could not be initialized

qemu-system-x86_64: ../net/net.= c:1106: net_client_init1: Assertion `nc' failed.

2022-12-05 03:14:08.794+000= 0: shutting down, reason=3Dcrashed

 

This commit is used to fix the = mentioned problem. It is based on commit a33c25399f9bc3dcf83064adeba2a82e61= bf4608 of master branch.

 

Kind regards.=

 

--_000_0357c2371db0438eac0de474db2b8ddchuaweicom_-- --_004_0357c2371db0438eac0de474db2b8ddchuaweicom_ Content-Type: application/octet-stream; name="0001-net-net.c-do-not-assert-nc-as-hotplug-vhost-net-may-.patch" Content-Description: 0001-net-net.c-do-not-assert-nc-as-hotplug-vhost-net-may-.patch Content-Disposition: attachment; filename="0001-net-net.c-do-not-assert-nc-as-hotplug-vhost-net-may-.patch"; size=2112; creation-date="Mon, 05 Dec 2022 03:49:23 GMT"; modification-date="Mon, 05 Dec 2022 03:49:23 GMT" Content-Transfer-Encoding: base64 RnJvbSBiMmJjYTQ4MzIxMmYwNGI5YjAyMTc1M2FlYzFmY2FlYWY0MTM4NWQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaW5nIFlhbmcgPHlhbmdtaW5nNzNAaHVhd2VpLmNvbT4KRGF0 ZTogRnJpLCAyNSBOb3YgMjAyMiAxMDo0NTo1MiArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIG5ldC9u ZXQuYzogRml4IHFlbXUgY3Jhc2ggd2hlbiBob3QtcGx1Z2luZyBhIHZob3N0LW5ldCBmYWlsZWQu IAoKSG90LXBsdWdpbmcgYSB2aG9zdC1uZXQgbWF5IGNhdXNlIHZpcnR1YWwgbWFjaGluZSBjcmFz aCBpbiBmb2xsb3dpbmcgc3RlcHM6CjEuIFN0YXJ0aW5nIGEgdm0gd2l0aG91dCBuZXQgZGV2aWNl cy4KMi4gSG90LXBsdWdpbmcgNzAgbWVtb3J5IGRldmljZXMuCjMuIEhvdC1wbHVnaW5nIGEgdmhv c3QtbmV0IGRldmljZS4KClRoZSByZWFzb24gaXMgOiBpZiBob3RwbHVnIGEgdmhvc3QtbmV0IGZh aWxlZCwgdGhlIG5jIGNhbm5vdCBiZSBmb3VuZCB2aWEgZnVuY3Rpb24gcWVtdV9maW5kX25ldGRl diwgYXMKaXQgaGFzIGJlZW4gY2xlYW5lZCB1cCB0aHJvdWdoIGZ1bmN0aW9uIHFlbXVfY2xlYW51 cF9uZXRfY2xpZW50LiBXaGljaCBsZWFkcyB0byB0aGUgcmVzdWx0CnRoYXQgYXNzZXJ0KG5jKSBm YWlsZWQsIHRoZW4gcWVtdSBjcmFzaGVkLgoKV2hpbGUsIHRoZSByb290IHJlYXNvbiBpcyB0aGF0 LCBpbiBjb21taXQgNDZkNGQzNmQwYmYyIGlmIG5vdCBib3RoIGhhc192aG9zdGZvcmNlIGFuZCB2 aG9zdGZvcmNlIGZsYWdzCmFyZSB0cnVlLCB0aGUgZXJycCB3b3VsZCBub3QgYmUgc2V0LiBUaGVu IG5ldF9pbml0X3RhcCB3b3VsZCBub3QgcmV0dXJuIGEgbmVnYXRpdmUgdmFsdWUsIGZhbGxvd2Vk IGJ5IGZvdW5kaW5nIG5jCmFuZCBhc3NlcnQgbmMuCgpJbiB0aGlzIHBhdGNoLCBhc3NlcnRpbmcg bmMgaXMgcmVwbGFjZWQgd2l0aCBzZXR0aW5nIGFuIGVycm9yIG1lc3NhZ2UuCgpGaXhlczogNDZk NGQzNmQwYmYyKCJ0YXA6IHNldHRpbmcgZXJyb3IgYXBwcm9wcmlhdGVseSB3aGVuIGNhbGxpbmcg bmV0X2luaXRfdGFwX29uZSgpIikKU2lnbmVkLW9mZi1ieTogTWluZyBZYW5nIDx5YW5nbWluZzcz QGh1YXdlaS5jb20+ClNpZ25lZC1vZmYtYnk6IExpYW5nIFpoYW5nIDx6aGFuZ2xpYW5nNUBodWF3 ZWkuY29tPgotLS0KIG5ldC9uZXQuYyB8IDExICsrKysrKysrKystCiAxIGZpbGUgY2hhbmdlZCwg MTAgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL25ldC9uZXQuYyBi L25ldC9uZXQuYwppbmRleCA4NDBhZDlkY2E1Li4xZDFkN2U1NGM0IDEwMDY0NAotLS0gYS9uZXQv bmV0LmMKKysrIGIvbmV0L25ldC5jCkBAIC0xMTAzLDcgKzExMDMsMTYgQEAgc3RhdGljIGludCBu ZXRfY2xpZW50X2luaXQxKGNvbnN0IE5ldGRldiAqbmV0ZGV2LCBib29sIGlzX25ldGRldiwgRXJy b3IgKiplcnJwKQogCiAgICAgaWYgKGlzX25ldGRldikgewogICAgICAgICBuYyA9IHFlbXVfZmlu ZF9uZXRkZXYobmV0ZGV2LT5pZCk7Ci0gICAgICAgIGFzc2VydChuYyk7CisgICAgICAgIC8qCisg ICAgICAgICAqIElmIHRoZSB0YXAgb2YgaG90cGx1Z2VkIG5ldCBkZXZpY2UgZG8gbm90IGhhcyBi b3RoIGhhc192aG9zdGZvcmNlIGZsYWcgYW5kIHZob3N0Zm9yY2UgZmxhZ3MsCisgICAgICAgICAq IHdoZW4gZXJyb3Igb2NjdXJzLCB0aGUgZXJyb3IgbWVzc2FncyB3aWxsIGJlIHJlcG9ydCBidXQg bm90IHNldCB0byBlcnJwLiBUaHVzIG5ldF9jbGllbnRfaW5pdF9mdW4KKyAgICAgICAgICogd2ls bCBub3QgcmV0dXJuIGEgbmVnYXRhdmUgdmFsdWUuIFRoZXJlZm9yZSB0aGUgdmFsdWUgb2YgbmMg bWlnaHQgYmUgTlVMTC4gVG8gbWFrZSBxZW11IHJvYnVzdCwKKyAgICAgICAgICogaXQgaXMgYmV0 dGVyIHRvIGp1ZGdlIGlmIG5jIGlzIE5VTEwuCisgICAgICAgICAqLworICAgICAgICBpZiAoIW5j KSB7CisgICAgICAgICAgICBlcnJvcl9zZXRnKGVycnAsICJEZXZpY2UgJyVzJyBjb3VsZCBub3Qg YmUgaW5pdGlhbGl6ZWQiLCBuZXRkZXYtPmlkKTsKKyAgICAgICAgICAgIHJldHVybiAtMTsKKyAg ICAgICAgfQogICAgICAgICBuYy0+aXNfbmV0ZGV2ID0gdHJ1ZTsKICAgICB9CiAKLS0gCjIuMzMu MAoK --_004_0357c2371db0438eac0de474db2b8ddchuaweicom_--