From nobody Mon Feb 9 12:14:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1566849567; cv=none; d=zoho.com; s=zohoarc; b=JKbg+O0yGZXqagKLrgqzBWSh+/R+NsxakmgNL5Qt6FuDW7MXkfPwtDdDUnZzRUpFKnAEeFxEE//087UFtT3hfdEFSb/Iv/HZgUn5IH0oOaL3r+MJg3SUN/8Nd3IZDR/tUV6XfllUFsFFrqxinjRUQ5fQ8a0KScAjehB7fsJLTMs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1566849567; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To:ARC-Authentication-Results; bh=wKcX2gKRML8gb5x7mdP0L0B90fYQ3nnlzE5zqwSEgP4=; b=GLBVJ36N/xUZ4VnFTZqFj2dnrs9rxuh7lc82Js4+WmCy2CdyXcexykN/kZTxBEkdHUgNSVvWOv6WZwOatehOnBRH6L3931aGmT9eni42oRhbz9yagSxy0b4f7tBJ+3oP+YqY0OES7u3VZi1ORYVNekVAjRw91VP8P8G+fDp8lTY= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1566849567686352.05752517857684; Mon, 26 Aug 2019 12:59:27 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 75385111A3C5; Mon, 26 Aug 2019 19:59:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A40DB1001B08; Mon, 26 Aug 2019 19:59:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 157B3180B536; Mon, 26 Aug 2019 19:59:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x7QJxH58018837 for ; Mon, 26 Aug 2019 15:59:17 -0400 Received: by smtp.corp.redhat.com (Postfix) id D7FE2413C; Mon, 26 Aug 2019 19:59:17 +0000 (UTC) Received: from mx1.redhat.com (ext-mx22.extmail.prod.ext.phx2.redhat.com [10.5.110.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BFDFE413A; Mon, 26 Aug 2019 19:59:10 +0000 (UTC) Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 75407189DAD6; Mon, 26 Aug 2019 19:59:09 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id 201so15096248qkm.9; Mon, 26 Aug 2019 12:59:09 -0700 (PDT) Received: from nullptr.home.dirty-ice.org (2a01-036c-0113-61b1-0000-0000-0000-0005.pool6.digikabel.hu. [2a01:36c:113:61b1::5]) by smtp.gmail.com with ESMTPSA id v7sm6795459qte.86.2019.08.26.12.59.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Aug 2019 12:59:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6vKc3KTMZLJZZmLzgCK03pmr6FwqF+2WsP7Qm1coCZg=; b=eshfaByV1dIgN+qbK35LY1YTWu5xITDr3OHBbFH/liNXxAnAh9kHbnj7llbgi8lbLj BrfE+171JvnoAdOaAps6gWh5sGHnA/XZpC4CIV6wjGmaLaknOqRRqbCNsJlfQzSi0I7f YyugO8PeIjYuVtuvj/5WY1cuEliRZZ+m8gP3xFvZaVgnu85emGsqIo8yjSAQ9zvdFnMI 3cwKjB8R7iuwqc0QvsBjE/UiVoMp4CYeEa45Wk8P1HE11xfLL64ia96a8LZhHle1ze7x 6mczqY+FYdis0PttDSuyisFq6+TQ/7wXq72jFAJ7rVPWk1lVNpk/WPBsYYz5vzt1QnDU PaKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6vKc3KTMZLJZZmLzgCK03pmr6FwqF+2WsP7Qm1coCZg=; b=nt06CdDMRcFU3Ui+4pD1ReLp60HkiXgssTInW/UDKijEtBbgrKDpO6+gxA58faWgNW RACUTuOsnwKqeOoXONKMNE+quOJ513KO+SyFjP/3fDVzgfldf1R9ZA2KoIt9U1eCf0QH Ed5bxIwODV06ek70UcPwwLTXtXqocuzFCYuAg3DYJNoLOor1MiXSYlXi2HN9x20xbUgr s/sfRyu7Nt6Ebue+vjo7Exv7UWbPAwVsQFAg/zOlDyRIjbE12O+9FgPEMDphmvsRDcaa 6022ZZul/rJGit9L9u2Z3L88cvjTQYWJtvk5a4QUKlOg6mPqNGsWeuANLQMMyWadC7Sw Npmg== X-Gm-Message-State: APjAAAUxy/hWtAwxV/8wTI+nD0WtR+Q5KfEaMnSyxoUfAWXKD8toNSwY +QOnoSYIuhNF1D8yJwsihr77+zyDQ+8= X-Google-Smtp-Source: APXvYqzaa22kZgnGLnDf+9v+3B1MLg0bzLxg1ecnhqVcmQmh9sM4VyJAqMwYZ/ky0KNQTzUVLSAkTw== X-Received: by 2002:a05:620a:137b:: with SMTP id d27mr18842173qkl.161.1566849548777; Mon, 26 Aug 2019 12:59:08 -0700 (PDT) From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?=" X-Google-Original-From: =?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?= To: qemu-devel@nongnu.org Date: Mon, 26 Aug 2019 21:59:02 +0200 Message-Id: <02d4328c33455742d01e0b62395013e95293c3ba.1566847960.git.DirtY.iCE.hu@gmail.com> In-Reply-To: References: MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.63]); Mon, 26 Aug 2019 19:59:09 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.63]); Mon, 26 Aug 2019 19:59:09 +0000 (UTC) for IP:'209.85.222.195' DOMAIN:'mail-qk1-f195.google.com' HELO:'mail-qk1-f195.google.com' FROM:'dirty.ice.hu@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.1 (DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS) 209.85.222.195 mail-qk1-f195.google.com 209.85.222.195 mail-qk1-f195.google.com X-Scanned-By: MIMEDefang 2.84 on 10.5.110.63 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: "reviewer:Incompatible changes" , Gerd Hoffmann , Maxim Levitsky Subject: [libvirt] [PATCH v2 2/4] audio: omitting audiodev= parameter is only deprecated X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Mon, 26 Aug 2019 19:59:26 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Unfortunately, changes introduced in af2041ed2d "audio: audiodev=3D parameters no longer optional when -audiodev present" breaks backward compatibility. This patch changes the error into a deprecation warning. Signed-off-by: K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n --- qemu-deprecated.texi | 7 +++++++ audio/audio.c | 8 ++++---- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 00a4b6f350..9d74a1cfc0 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -72,6 +72,13 @@ backend settings instead of environment variables. To e= ase migration to the new format, the ``-audiodev-help'' option can be used to convert the current values of the environment variables to ``-audiodev'' options. =20 +@subsection Creating sound card devices and vnc without audiodev=3D proper= ty (since 4.2) + +When not using the deprecated legacy audio config, each sound card +should specify an @code{audiodev=3D} property. Additionally, when using +vnc, you should specify an @code{audiodev=3D} propery if you plan to +transmit audio through the VNC protocol. + @subsection -mon ...,control=3Dreadline,pretty=3Don|off (since 4.1) =20 The @code{pretty=3Don|off} switch has no effect for HMP monitors, but is diff --git a/audio/audio.c b/audio/audio.c index ae335dbebb..e99fcd0694 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -1412,8 +1412,9 @@ static AudioState *audio_init(Audiodev *dev, const ch= ar *name) drvname =3D AudiodevDriver_str(dev->driver); } else if (!QTAILQ_EMPTY(&audio_states)) { if (!legacy_config) { - dolog("You must specify an audiodev=3D for the device %s\n", n= ame); - exit(1); + dolog("Device %s: audiodev default parameter is deprecated, pl= ease " + "specify audiodev=3D%s\n", name, + QTAILQ_FIRST(&audio_states)->dev->id); } return QTAILQ_FIRST(&audio_states); } else { @@ -1548,8 +1549,7 @@ CaptureVoiceOut *AUD_add_capture( =20 if (!s) { if (!legacy_config) { - dolog("You must specify audiodev when trying to capture\n"); - return NULL; + dolog("Capturing without setting an audiodev is deprecated\n"); } s =3D audio_init(NULL, NULL); } --=20 2.22.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list