From nobody Wed Apr 24 23:52:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1565787643; cv=none; d=zoho.com; s=zohoarc; b=I1uiR6iGCxEFlW1KuMJwoGUf4Sn9ldTtrWYoEz4r+NmiGBnvOPBQTbB1BKlQ/iVLjYTqYxcgOCKzdbT6ZaCmW9lqngO0OMWsNBtCcKrBl6IvqC0BVKj5jBwOczn/4cYXlDQDAt8cXnWoa1JnUfAwmw+EeS66gzNjlJm3FO+KLKQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1565787643; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To:ARC-Authentication-Results; bh=/fqXOzI+WSqNdxz5KFIpi/UT6BAlVhuhnq+Fk1E0HME=; b=fwsub9nn6LzBh7zWD/XKGbopCOwg3vsYcUJTRXLfg0Is0BWuaYl9jwG0xyXoRipuwwZ7yNK72KJoR+GKM/6UwPue/wHY26/pYEtsS/1tYJaXoT9C6IoCPzVi/bgU35hpBX1ziL+Slhrmx6ANUrq5jiGv4rNwqsAfDx0cs9jU/Jc= ARC-Authentication-Results: i=1; mx.zoho.com; spf=pass (zoho.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1565787643588893.7433444987247; Wed, 14 Aug 2019 06:00:43 -0700 (PDT) Received: from localhost ([::1]:60458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxstL-0000Bj-N9 for importer@patchew.org; Wed, 14 Aug 2019 09:00:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52851) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hxmYi-0007lP-OK for qemu-devel@nongnu.org; Wed, 14 Aug 2019 02:14:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hxmYh-0004eO-1v for qemu-devel@nongnu.org; Wed, 14 Aug 2019 02:14:56 -0400 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:2896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hxmYe-0004Gx-L7; Wed, 14 Aug 2019 02:14:54 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.9]) by rmmx-syy-dmz-app02-12002 (RichMail) with SMTP id 2ee25d53a6c413c-b41f4; Wed, 14 Aug 2019 14:14:29 +0800 (CST) Received: from LAPTOPBMTSOBR7 (unknown[112.25.154.148]) by rmsmtp-syy-appsvr05-12005 (RichMail) with SMTP id 2ee55d53a6c3f51-8957c; Wed, 14 Aug 2019 14:14:28 +0800 (CST) X-RM-TRANSID: 2ee25d53a6c413c-b41f4 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee55d53a6c3f51-8957c From: To: Date: Wed, 14 Aug 2019 14:14:26 +0800 Message-ID: <02cf01d55267$86cf2850$946d78f0$@cmss.chinamobile.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AdVSZzdMb/mLdwi2R02S0a02zpe8VQ== Content-Language: zh-cn X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 221.176.66.79 X-Mailman-Approved-At: Wed, 14 Aug 2019 08:58:51 -0400 Subject: [Qemu-devel] [PATCH] pc-bios/s390-ccw/net: fix a possible memory leak in get_uuid() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: borntraeger@de.ibm.com, thuth@redhat.com, cohuck@redhat.com, qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" There is a possible memory leak in get_uuid(). Should free allocated mem before=20 return NULL. Signed-off-by: Yifan Luo Reviewed-by: Cornelia Huck Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/netmain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/pc-bios/s390-ccw/netmain.c b/pc-bios/s390-ccw/netmain.c index f3542cb2cf1..f2dcc01e272 100644 --- a/pc-bios/s390-ccw/netmain.c +++ b/pc-bios/s390-ccw/netmain.c @@ -269,6 +269,7 @@ static const char *get_uuid(void) : "d" (r0), "d" (r1), [addr] "a" (buf) : "cc", "memory"); if (cc) { + free(mem); return NULL; } =20 --=20 2.21.0