From nobody Thu Apr 18 12:29:07 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=patchew-devel-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=patchew-devel-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1547388280174464.3673122994261; Sun, 13 Jan 2019 06:04:40 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 82DA6C00C0FE; Sun, 13 Jan 2019 14:04:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 72FBC100194B; Sun, 13 Jan 2019 14:04:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 330C9181B9E3; Sun, 13 Jan 2019 14:04:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x0DE4afB017225 for ; Sun, 13 Jan 2019 09:04:36 -0500 Received: by smtp.corp.redhat.com (Postfix) id 5773B18344; Sun, 13 Jan 2019 14:04:36 +0000 (UTC) Received: from mx1.redhat.com (ext-mx07.extmail.prod.ext.phx2.redhat.com [10.5.110.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 505F417C1B for ; Sun, 13 Jan 2019 14:04:34 +0000 (UTC) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 01B3CC0495B8 for ; Sun, 13 Jan 2019 14:04:33 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id v13so19986861wrw.5 for ; Sun, 13 Jan 2019 06:04:32 -0800 (PST) Received: from localhost.localdomain ([2001:b07:6468:f312:29c6:8eb4:8a56:e1f2]) by smtp.gmail.com with ESMTPSA id d16sm54518665wru.52.2019.01.13.06.04.30 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 13 Jan 2019 06:04:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=hX7bvXkcywJiVrS/qJd+E3gOPc2HuO7N+2z1Jwc14ic=; b=GdifzCWHc4Kskfzkr3Oi+1hgge+XzPsSK8oZAEGjphwHXBVOQHHgdEo8zlVPQlV9Pw VeYr5TetMp1poBdyL71m4StJA0hvEn68lG/SezZiER2IXcQvqlA52ovW+3iwKFO9+jpB SLMA8lHVbNe2j5Wi7kieK+8Y7RQ+7QO/hc8UTuAM6s2QiBbFyuhpk8Lz6tXGV9aRTCrQ DdYhFdvZ4fySaviNGtPx3c0odmkqf9Gc29lHqpWI5Sf1j5ayLANEEkTjRow5SFqIdtZi IgvSfVUQtVqhie7V18G3k8yBVEVE0Xxa2iKZBppDSbFZsPmkzbMZVWjgW0PE0nQng6hJ caHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version:content-transfer-encoding; bh=hX7bvXkcywJiVrS/qJd+E3gOPc2HuO7N+2z1Jwc14ic=; b=Fc4w7XN4MFuu0IDIa2R+tjv8GFDJkNOD8deOEWNxfU3+5UXytANe/us2QHQlaUpuT0 MQj/YytTyMQLPRvHcHQ2R0sjluh5elk0Y+DDnXz6CSsGj+BQFIQBi0OXeZSxWqsJUUUJ cTJGPf0+vEDIYupJdYCCCmEvPpvWsyLFIY/RKBFilV8kBbOk6YJQ0IOgRTZyOcB/8VHK PdQVZm9FWVDpD1ga6KQcRI6m18hWFWm+VuIsHnwMZ3P0SPu3QdxSR8mar9uclrlGPN4Q IKM86+33niiXZVWe40b2WFUbdtJbIut0kDl08oC7poHrnxKiBk+XBezt7v/BcAKzudW4 zHqA== X-Gm-Message-State: AJcUukdji7nh3zhYpGb36p3p4GuP4M5xE9lTvOoG8bWvdApGGATCvN6Y 7vjZZHwyqfiELkhdJlThxblALG2Bcp8= X-Google-Smtp-Source: ALg8bN7dhPKyl+sepGyDk4Yb6F8L0GepFdnViB6sgJMpvHNpTWMjY0PQC5D3zOuBkG0wgOAfh/S67w== X-Received: by 2002:a5d:570c:: with SMTP id a12mr20061888wrv.161.1547388271253; Sun, 13 Jan 2019 06:04:31 -0800 (PST) From: Paolo Bonzini To: patchew-devel@redhat.com Date: Sun, 13 Jan 2019 15:04:30 +0100 Message-Id: <20190113140430.14156-1-pbonzini@redhat.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sun, 13 Jan 2019 14:04:33 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sun, 13 Jan 2019 14:04:33 +0000 (UTC) for IP:'209.85.221.65' DOMAIN:'mail-wr1-f65.google.com' HELO:'mail-wr1-f65.google.com' FROM:'paolo.bonzini@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.008 (DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS) 209.85.221.65 mail-wr1-f65.google.com 209.85.221.65 mail-wr1-f65.google.com X-RedHat-Possible-Forgery: Paolo Bonzini X-Scanned-By: MIMEDefang 2.78 on 10.5.110.31 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: patchew-devel@redhat.com Subject: [Patchew-devel] [PATCH] testing: do not pass /dev/null stdin to script(1) X-BeenThere: patchew-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Patchew development and discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: patchew-devel-bounces@redhat.com Errors-To: patchew-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Sun, 13 Jan 2019 14:04:38 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The script tool exits immediately if it encounters an EOF on stdin. Therefore, we must pass a pipe or the testers' cron jobs will exit immediately and incorrectly. The script is still run with /dev/null as stdin, to avoid hangs on input. Fixes: eaad26f749f349e182fc360e707ab4deb74f62bd Signed-off-by: Paolo Bonzini --- patchew-cli | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/patchew-cli b/patchew-cli index 6a78f81..8012955 100755 --- a/patchew-cli +++ b/patchew-cli @@ -539,8 +539,8 @@ class TesterCommand(SubCommand): logf.write("=3D=3D=3D OUTPUT BEGIN =3D=3D=3D\n") logf.flush() start_time =3D time.time() - tp =3D subprocess.Popen(["/usr/bin/script", "-qefc", test_scri= pt, "/dev/null"], - cwd=3Dclone, stdout=3Dlogf, stderr=3Dlog= f) + tp =3D subprocess.Popen(["/usr/bin/script", "-qefc", test_scri= pt + "< /dev/null", "/dev/null"], + cwd=3Dclone, stdin=3Dsubprocess.PIPE, st= dout=3Dlogf, stderr=3Dlogf) rc =3D None timeout =3D r["test"]["timeout"] while timeout <=3D 0 or time.time() - start_time < timeout: --=20 2.20.1 _______________________________________________ Patchew-devel mailing list Patchew-devel@redhat.com https://www.redhat.com/mailman/listinfo/patchew-devel