From nobody Sat Oct 5 22:49:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=patchew-devel-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=patchew-devel-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1547200962557316.5644902955336; Fri, 11 Jan 2019 02:02:42 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 09403AC5FD; Fri, 11 Jan 2019 10:02:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E612727CCE; Fri, 11 Jan 2019 10:02:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D5742181BA1A; Fri, 11 Jan 2019 10:02:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x0BA2eie022682 for ; Fri, 11 Jan 2019 05:02:40 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1059CBA4F; Fri, 11 Jan 2019 10:02:40 +0000 (UTC) Received: from mx1.redhat.com (ext-mx06.extmail.prod.ext.phx2.redhat.com [10.5.110.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 08D5560C67 for ; Fri, 11 Jan 2019 10:02:37 +0000 (UTC) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0AFF21E31B for ; Fri, 11 Jan 2019 10:02:37 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id p4so14505486wrt.7 for ; Fri, 11 Jan 2019 02:02:36 -0800 (PST) Received: from donizetti.lan ([2001:b07:6468:f312:29c6:8eb4:8a56:e1f2]) by smtp.gmail.com with ESMTPSA id k7sm59223761wrl.51.2019.01.11.02.02.34 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Jan 2019 02:02:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=wmcYy337YfGFeK1LkDsBMir66XeR2OxZPzAChmaiI+I=; b=FrHKR3fSB9+fWPhtvL0snZPHl5dr7K+WQh1McnSBFLytxLfbdmnWYo3W9s7gMQi2RT CfmE2XWrBdwT2hHncFK9eJ6943FmAQh1UfoYVnGQVs3dCwJe1rc2r02PKydzpGMAsGIY fd0ISCmk3bV1l1bk047Xq6KvimDmuZ3zTFQEKSqjnxcZT8BRtWCNFGhM8wvbHr7srXBE bhdsdJbZgKMfMviKvMWU3cARUawvjU+FbOoCYKMPuDuo/O29fVlB9Yi6fF75XlDozzKB bbf98WO9i1uByMCbXolIefmN7hlv8QJL4v/3bL0fO8VE7Lxr7oCwitxdX+5w9xZ9fQ4c WmqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version:content-transfer-encoding; bh=wmcYy337YfGFeK1LkDsBMir66XeR2OxZPzAChmaiI+I=; b=U6KtenSNST/aCANoIvXEoBl2fNN9pIgi2I3YAICd6vrdimgwDFCqDrRTXVGb7Voacj oiUk0osmH2v81tFGP68dSl3IAgTjMZrP3ZKm6GSb6tyWUeR3ilb5KPkFeRXZzdb8skU5 iq/MFnSi02Rc8+RdOyj9G9oFoiAlE4ChuE/Uh598fy8QY6nnaVVgYDtRPW7LYynlVesc J9VFKvbQSy7leeqIpZeZoy4dJb5MGnZB6yug2iAcQeOub2RPD4H2445ulf88C0UaWV4a rtWm7V2PzgcE5g/CTkqIeZoBovC3NA9MqnhPtFSsNM6thlJrvgqZc9Fh91r79NO8Zx7T rTxg== X-Gm-Message-State: AJcUukcZnqWDRk2WsME6yELKleqUwhzsTDrGy3uAJZmpZ1q9tZjGj8ZP /4prvK4FySFSnMzY3CAli+600JAE8/w= X-Google-Smtp-Source: ALg8bN4A8OFF6tbvUeE1S9ncssY4iM2+zs4NbTDqxeftibBbFl9aL6gasyJ+noNjyGiSK25L/6UHNg== X-Received: by 2002:adf:e247:: with SMTP id n7mr12121462wri.205.1547200955110; Fri, 11 Jan 2019 02:02:35 -0800 (PST) From: Paolo Bonzini To: patchew-devel@redhat.com Date: Fri, 11 Jan 2019 11:02:32 +0100 Message-Id: <20190111100233.24335-1-pbonzini@redhat.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 11 Jan 2019 10:02:37 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 11 Jan 2019 10:02:37 +0000 (UTC) for IP:'209.85.221.68' DOMAIN:'mail-wr1-f68.google.com' HELO:'mail-wr1-f68.google.com' FROM:'paolo.bonzini@gmail.com' RCPT:'' X-RedHat-Spam-Score: -0.008 (DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS) 209.85.221.68 mail-wr1-f68.google.com 209.85.221.68 mail-wr1-f68.google.com X-RedHat-Possible-Forgery: Paolo Bonzini X-Scanned-By: MIMEDefang 2.78 on 10.5.110.30 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: patchew-devel@redhat.com Subject: [Patchew-devel] [PATCH] git: allow not passing the URL to applier-report X-BeenThere: patchew-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Patchew development and discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Sender: patchew-devel-bounces@redhat.com Errors-To: patchew-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 11 Jan 2019 10:02:41 +0000 (UTC) X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The applier-report handler tried to use the URL template from the project, = but there was a bug in the logic to do so. Fix it. Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng --- mods/git.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mods/git.py b/mods/git.py index a163062..4f3236b 100644 --- a/mods/git.py +++ b/mods/git.py @@ -273,9 +273,10 @@ class ApplierReportView(APILoginRequiredView): data['tag'] =3D 'refs/tags/' + tag if url: data['url'] =3D url - elif url_template and tag: + elif tag: url_template =3D p.get_property("git.url_template") - data['url'] =3D url_template.replace("%t", tag) + if url_template: + data['url'] =3D url_template.replace("%t", tag) if base: data['base'] =3D base r.status =3D Result.SUCCESS --=20 2.20.1 _______________________________________________ Patchew-devel mailing list Patchew-devel@redhat.com https://www.redhat.com/mailman/listinfo/patchew-devel