From nobody Mon Sep 16 19:22:11 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F6D360DFC for ; Tue, 20 Feb 2024 09:58:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708423117; cv=none; b=PZdilMLw2O1B8cX7jMuvk9GZ+7JbKXV6Aivu2PkeWn43lhE5JyEWfnWuwl1bdVS3e5zQ31nEPchgJzKVizJREcceT2SlMQ9OBNLkKPRQ3RMe5bbFhuVCQbufB3oUoJe2EsVf7RZm+g04rw/qLK0b+lkgV8bXDbEKfL+bEnWC4N4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708423117; c=relaxed/simple; bh=20FOi1rILPNfj1P9lJvpuHkosfki300oiO+jR2JjoJU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pYxpsXyyGJmShXLS+pnzhfOZtabTiZKcwWBHnGX4eIYxnFQka8VCaVS6TMPyihTHmBsj5nN666LUBCpVeSVoWazANMWTAwRrd2szznPo43I3dqm4JuudNH0Gb8bgZqN6cjCV0BE04CET1kSlb81RwqpLHUHMAWnvhWtcTeo1oDg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=op0Gh1Cw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="op0Gh1Cw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4C51C433C7; Tue, 20 Feb 2024 09:58:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708423116; bh=20FOi1rILPNfj1P9lJvpuHkosfki300oiO+jR2JjoJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=op0Gh1CwWXZxHVld1uuIik3ekHLCbq1340LlaF3vTfHHo/V1mxAE7EAY4LQkgADua HS2GIfrrMJcCVcG4qzIZ8gtlSRiIh65EjuFg/vLLHrG2UOQ5x06og54v++Xjtqx6m3 SzP1EXCSyhp0g5aGWwTmn14h+MkeEBf+EsffwflLe967jTCkeXb3wkd2zHrVA2dnn0 jgSI/EtosTkGEZtEmuekbQQLyqsCotVI6rlDofuwXkUNi4rNplKR+3aKrKfFl/zVgD VkLCpDH92Y1e4/3js7V7v4utaPID6RDQRRVpv7MCSZUm4w9qFUp90uBBI6o0ECJewz emVenYdAU6xTw== From: Geliang Tang To: mptcp@lists.linux.dev Cc: Geliang Tang Subject: [PATCH mptcp-next v14 02/14] mptcp: implement mptcp_userspace_pm_dump_addr Date: Tue, 20 Feb 2024 17:58:16 +0800 Message-Id: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Geliang Tang This patch implements mptcp_userspace_pm_dump_addr() to dump addresses from userspace pm address list. Use mptcp_token_get_sock() to get the msk from the given token, if userspace PM is enabled in it, traverse each address entry in address list, put every entry to userspace using mptcp_pm_nl_put_entry_msg(). Signed-off-by: Geliang Tang --- net/mptcp/pm_userspace.c | 60 ++++++++++++++++++++++++++++++++++++++++ net/mptcp/protocol.h | 2 ++ 2 files changed, 62 insertions(+) diff --git a/net/mptcp/pm_userspace.c b/net/mptcp/pm_userspace.c index bc97cc30f013..d6b7be3afbe5 100644 --- a/net/mptcp/pm_userspace.c +++ b/net/mptcp/pm_userspace.c @@ -572,3 +572,63 @@ int mptcp_userspace_pm_set_flags(struct net *net, stru= ct nlattr *token, sock_put(sk); return ret; } + +int mptcp_userspace_pm_dump_addr(struct sk_buff *msg, + struct netlink_callback *cb) +{ + struct id_bitmap { + DECLARE_BITMAP(map, MPTCP_PM_MAX_ADDR_ID + 1); + } *bitmap; + const struct genl_info *info =3D genl_info_dump(cb); + struct net *net =3D sock_net(msg->sk); + struct mptcp_pm_addr_entry *entry; + struct mptcp_sock *msk; + struct nlattr *token; + int ret =3D -EINVAL; + struct sock *sk; + void *hdr; + + bitmap =3D (struct id_bitmap *)cb->ctx; + token =3D info->attrs[MPTCP_PM_ATTR_TOKEN]; + + msk =3D mptcp_token_get_sock(net, nla_get_u32(token)); + if (!msk) { + NL_SET_ERR_MSG_ATTR(info->extack, token, "invalid token"); + return ret; + } + + sk =3D (struct sock *)msk; + + if (!mptcp_pm_is_userspace(msk)) { + GENL_SET_ERR_MSG(info, "invalid request; userspace PM not selected"); + goto out; + } + + lock_sock(sk); + spin_lock_bh(&msk->pm.lock); + list_for_each_entry(entry, &msk->pm.userspace_pm_local_addr_list, list) { + if (test_bit(entry->addr.id, bitmap->map)) + continue; + + hdr =3D genlmsg_put(msg, NETLINK_CB(cb->skb).portid, + cb->nlh->nlmsg_seq, &mptcp_genl_family, + NLM_F_MULTI, MPTCP_PM_CMD_GET_ADDR); + if (!hdr) + break; + + if (mptcp_nl_fill_addr(msg, entry) < 0) { + genlmsg_cancel(msg, hdr); + break; + } + + __set_bit(entry->addr.id, bitmap->map); + genlmsg_end(msg, hdr); + } + spin_unlock_bh(&msk->pm.lock); + release_sock(sk); + ret =3D msg->len; + +out: + sock_put(sk); + return ret; +} diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h index 843c1e31de3f..0f6eee5496ad 100644 --- a/net/mptcp/protocol.h +++ b/net/mptcp/protocol.h @@ -1071,6 +1071,8 @@ bool mptcp_pm_rm_addr_signal(struct mptcp_sock *msk, = unsigned int remaining, int mptcp_pm_get_local_id(struct mptcp_sock *msk, struct sock_common *skc); int mptcp_pm_nl_get_local_id(struct mptcp_sock *msk, struct mptcp_addr_inf= o *skc); int mptcp_userspace_pm_get_local_id(struct mptcp_sock *msk, struct mptcp_a= ddr_info *skc); +int mptcp_userspace_pm_dump_addr(struct sk_buff *msg, + struct netlink_callback *cb); =20 static inline u8 subflow_get_local_id(const struct mptcp_subflow_context *= subflow) { --=20 2.40.1