From nobody Sat May 4 03:43:04 2024 Delivered-To: wpasupplicant.patchew@gmail.com Received: by 2002:ab0:35eb:0:0:0:0:0 with SMTP id w11csp2404344uau; Wed, 22 Jun 2022 02:47:20 -0700 (PDT) X-Google-Smtp-Source: AGRyM1veR8zHtT/EX3UBmXh+P7m8q9ueSe7NTFDkPcOwa4UBjIH+ZuYwShT/z6KLMWHaOgj4WFaH X-Received: by 2002:a05:6870:472a:b0:fe:657:2daf with SMTP id b42-20020a056870472a00b000fe06572dafmr1523820oaq.16.1655891240093; Wed, 22 Jun 2022 02:47:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655891240; cv=none; d=google.com; s=arc-20160816; b=xNKHNQCdIepkq2KT9uHwoKTtC8u9Amk/Bgu8385PSy6l/VGE31lPICag+Fx2NXoBJV GCBDmuf0bO/i8xAoheYOolen1IjR2eNFTZpJACPz+QNru8Mr535of7dHcpvub2foSGLe 3IonFClKW6Lk6FNs1W4JeQAPFpoaDVHaYxG5a/4FTMmCNUAcc6kvQI8n4FlG5Wp00hDd rfsY6WUkjcVMvLAfC374a4agTb92sZgET39+Ikcu2cPGRxX1Gg96uzvSmqCVF6/yxn5y n6PIsfrh7Xe54cZgKtpECYn4Ghv3tUZ8lQ/hwKRLx3cev9eLdW+uPoSRG7Nowi0Cn3Hf nHzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:to:from :dkim-signature; bh=QVDcxwFosBl9KznFRwX3knXDH8xbKiMHn89A1N7ZNGo=; b=RV0XxEF8PjfkeBj7jbrM52MMw3hHnMZ2njpFlB2YgCyRFtF/WY7mXg7nJwur/mlivR SoXuCB4XW4ciItmoVU7aqDfyBq4zCazWVGcHvqZtrpn144DL5fBaA0R9fK39vdQsrhCH ivJkfICc4JDh6lV2bxdpHF6EyI6zGtEVBgTqjPsKzfLac+tjdQyPRtvR/0DJdMpJUGD5 ybCk6739bpvVcB7YzK5T3pm6UpJHXEVGupExJGMBBL6UQPfDLw5kbveYseW0E7cKIIg7 crTUN6HfwJIElmJXDhHWkbic5GOVnaKR8+p13o7qM0J3TG98euTjljrDb0VfhqkX+Kei emfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=a7oMy1le; spf=pass (google.com: domain of mptcp+bounces-5756-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 139.178.84.19 as permitted sender) smtp.mailfrom="mptcp+bounces-5756-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from da.mirrors.kernel.org (da.mirrors.kernel.org. [139.178.84.19]) by mx.google.com with ESMTPS id d14-20020a4aa58e000000b0040e505cded2si15425948oom.82.2022.06.22.02.47.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Jun 2022 02:47:20 -0700 (PDT) Received-SPF: pass (google.com: domain of mptcp+bounces-5756-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 139.178.84.19 as permitted sender) client-ip=139.178.84.19; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=a7oMy1le; spf=pass (google.com: domain of mptcp+bounces-5756-wpasupplicant.patchew=gmail.com@lists.linux.dev designates 139.178.84.19 as permitted sender) smtp.mailfrom="mptcp+bounces-5756-wpasupplicant.patchew=gmail.com@lists.linux.dev"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by da.mirrors.kernel.org (Postfix) with ESMTPS id C96282E09DC for ; Wed, 22 Jun 2022 09:47:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 77F46111E; Wed, 22 Jun 2022 09:47:18 +0000 (UTC) X-Original-To: mptcp@lists.linux.dev Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3ADE10E8 for ; Wed, 22 Jun 2022 09:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655891235; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QVDcxwFosBl9KznFRwX3knXDH8xbKiMHn89A1N7ZNGo=; b=a7oMy1lemxHyc2F48/4uUwBshhVZos3AI+UiWI3aeiCdPklQUb1gqlQboA/7QB3B82qjD0 kfMUdlmdwqYekZMRDa+m5rJFymXc2WWbtOhPG+38c4KbFQhELeCGjgM1ZatOBYWGYWtuvi s2G60kIJAH7Sxcd/vgute1IJJOrd6Ks= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-438-SLg5aBY8O8ujPyE3fh7jYg-1; Wed, 22 Jun 2022 05:47:14 -0400 X-MC-Unique: SLg5aBY8O8ujPyE3fh7jYg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C635E29DD98E for ; Wed, 22 Jun 2022 09:47:13 +0000 (UTC) Received: from gerbillo.redhat.com (unknown [10.39.193.233]) by smtp.corp.redhat.com (Postfix) with ESMTP id 585312166B29 for ; Wed, 22 Jun 2022 09:47:13 +0000 (UTC) From: Paolo Abeni To: mptcp@lists.linux.dev Subject: [PATCH mptcp-net] Squash-to: "selftests: mptcp: more stable diag tests" Date: Wed, 22 Jun 2022 11:47:05 +0200 Message-Id: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pabeni@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8"; x-default="true" The "....chk remote_key" testcase is failing quite often in debug build. I guess the mptcp_connect completes before the script execute this latter test, so I'm adding another large wait. It should not impact the test run-time, as the mptcp_connect processes are terminated just after running the check. Signed-off-by: Paolo Abeni --- this is wild guess, mostly to trigger/inspect the test results --- tools/testing/selftests/net/mptcp/diag.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/diag.sh b/tools/testing/self= tests/net/mptcp/diag.sh index ee2f238255ec..515859a5168b 100755 --- a/tools/testing/selftests/net/mptcp/diag.sh +++ b/tools/testing/selftests/net/mptcp/diag.sh @@ -179,7 +179,7 @@ ip -n $ns link set dev lo up echo "a" | \ timeout ${timeout_test} \ ip netns exec $ns \ - ./mptcp_connect -p 10000 -l -t ${timeout_poll} \ + ./mptcp_connect -p 10000 -l -t ${timeout_poll} -w 20 \ 0.0.0.0 >/dev/null & wait_local_port_listen $ns 10000 chk_msk_nr 0 "no msk on netns creation" @@ -188,7 +188,7 @@ chk_msk_listen 10000 echo "b" | \ timeout ${timeout_test} \ ip netns exec $ns \ - ./mptcp_connect -p 10000 -r 0 -t ${timeout_poll} \ + ./mptcp_connect -p 10000 -r 0 -t ${timeout_poll} -w 20 \ 127.0.0.1 >/dev/null & wait_connected $ns 10000 chk_msk_nr 2 "after MPC handshake " @@ -200,13 +200,13 @@ flush_pids echo "a" | \ timeout ${timeout_test} \ ip netns exec $ns \ - ./mptcp_connect -p 10001 -l -s TCP -t ${timeout_poll} \ + ./mptcp_connect -p 10001 -l -s TCP -t ${timeout_poll} -w 20 \ 0.0.0.0 >/dev/null & wait_local_port_listen $ns 10001 echo "b" | \ timeout ${timeout_test} \ ip netns exec $ns \ - ./mptcp_connect -p 10001 -r 0 -t ${timeout_poll} \ + ./mptcp_connect -p 10001 -r 0 -t ${timeout_poll} -w 20 \ 127.0.0.1 >/dev/null & wait_connected $ns 10001 chk_msk_fallback_nr 1 "check fallback" --=20 2.35.3