From nobody Sat Jul 25 07:27:12 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43A5629D29F for ; Mon, 13 Jul 2026 03:32:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783913545; cv=none; b=ahXztbQwyVe4LaNdSmY/Tc+dvTHNOKhTuVGgVUbscZYzRrIfAu3EJbQ7W9sNh67P+VLIFjQfAwt4GHnPzYabsN2Y6IyjGfr7SZhcKR8LqiJnfXdLPU8bqA/6EPOUy4OewenHeLPZP58zAhXcvddBMQbbs8L5jnm2sy9biGkfeqE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783913545; c=relaxed/simple; bh=jME7UwAhFGdpy0DC+LD1XLRwwMwYlVOX++7xseGcuGo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=A5/JLJiddpCIHOb3ZklBFKGL+YJHTkrXeTu1jDIksKRRTqvToLvToYeF9Vaxo/mfJ6MTJdgoSncYWpGPTfbdGM03SUw7Yxvqx/WXNs/BXvyD6hO/5+WlbogDaaBv65psrn6/iZ23G+ALnv88ln0PmsFkriwBXKqa/PeFdlzPqHM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MoDjj4wR; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MoDjj4wR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFB9A1F00A3A; Mon, 13 Jul 2026 03:32:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783913543; bh=EYeyAMGYwgrEvRqPliDbY8/sG7cAJUpla97WO7oBIDM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=MoDjj4wRDk247KmD8b8yMQ6Y+DRupetutrEhSdLqBGcoCsyXd0Dg/LSqv3cT+r5+T W1AIhEbP/ZoU+ZE9XNC0zzC/gu68cqDeRQt1LEEu9H/mjb2SWb/dUeeL4LApZqli+z acforAajqtCBR6ksk8GswG2w8rP3z29Keun+g6ltBKCerkDe72hbOCJxRDyPnCeASV 5kvZpwP/9PpVoDph+u6/QT0UTb4JxO6CfmvpikiEyENWWd++W/oVobJE6HBYWtdCzu UWB8DczshyWm2UcNIN/foD80+jJ58nqLHrwq2NvZT9Q1URXUhVKCxpQ117wGZqoleI F3rrtmq6nWkRQ== From: Geliang Tang To: mptcp@lists.linux.dev Cc: Geliang Tang , Paolo Abeni Subject: [PATCH mptcp-next v3 1/5] mptcp: use local variable tp in sendmsg_frag Date: Mon, 13 Jul 2026 11:32:09 +0800 Message-ID: X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Geliang Tang In mptcp_sendmsg_frag(), tcp_sk(ssk) is called multiple times. Introduce a local variable 'tp' to hold the tcp_sock pointer and use it throughout the function. This avoids repeated dereferencing and improves code readability, with no functional change. Suggested-by: Paolo Abeni Signed-off-by: Geliang Tang --- net/mptcp/protocol.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index ffcf5a1788f6..1cab07b1b9b1 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -1375,6 +1375,7 @@ static int mptcp_sendmsg_frag(struct sock *sk, struct= sock *ssk, u64 data_seq =3D dfrag->data_seq + info->sent; int offset =3D dfrag->offset + info->sent; struct mptcp_sock *msk =3D mptcp_sk(sk); + struct tcp_sock *tp =3D tcp_sk(ssk); bool zero_window_probe =3D false; struct mptcp_ext *mpext =3D NULL; bool can_coalesce =3D false; @@ -1410,14 +1411,14 @@ static int mptcp_sendmsg_frag(struct sock *sk, stru= ct sock *ssk, mpext =3D mptcp_get_ext(skb); if (!mptcp_skb_can_collapse_to(data_seq, skb, mpext)) { TCP_SKB_CB(skb)->eor =3D 1; - tcp_mark_push(tcp_sk(ssk), skb); + tcp_mark_push(tp, skb); goto alloc_skb; } =20 i =3D skb_shinfo(skb)->nr_frags; can_coalesce =3D skb_can_coalesce(skb, i, dfrag->page, offset); if (!can_coalesce && i >=3D READ_ONCE(net_hotdata.sysctl_max_skb_frags))= { - tcp_mark_push(tcp_sk(ssk), skb); + tcp_mark_push(tp, skb); goto alloc_skb; } =20 @@ -1471,7 +1472,7 @@ static int mptcp_sendmsg_frag(struct sock *sk, struct= sock *ssk, skb->truesize +=3D copy; sk_wmem_queued_add(ssk, copy); sk_mem_charge(ssk, copy); - WRITE_ONCE(tcp_sk(ssk)->write_seq, tcp_sk(ssk)->write_seq + copy); + WRITE_ONCE(tp->write_seq, tp->write_seq + copy); TCP_SKB_CB(skb)->end_seq +=3D copy; tcp_skb_pcount_set(skb, 0); =20 --=20 2.53.0 From nobody Sat Jul 25 07:27:12 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEA7E3368BF for ; Mon, 13 Jul 2026 03:32:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783913548; cv=none; b=KaVUPCgP30tzrjKQuJ5+FIayIkxxGzS1uFR8UwlOfgfddYUjUMQ44MOGOKP/u5cSRV2zJvhMfJSHOtAVJHyyz0SoLvECPwpCMSVJQrIz0VZUOm7j5GRNxMr/o/U49Dr8cpAR4DIvSfltCRTXAH+4/Q6eC6NX56p6QIk8pBBNeIQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783913548; c=relaxed/simple; bh=Wy+7caouhss7ma6Qt6XywZq6Qjka3+q8AJBJb0/3B3Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VwuGSGl8Lm1IBVa1vWq0MqMO5zd/CEpxnmXnwGBLmlDZjp1sVk202DAd8b+MswxC2ovPHQ9U53K1GnIA4Sn+0MY++Q7XC/uWM6hyF4O3wt6qd8waL/KnX89PWfxIqgeEyRzvqeFWm+ckdp4gI8YaYrgahaHPkU3Wq9DRb4+cdwk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cETERcSU; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cETERcSU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C9591F00A3D; Mon, 13 Jul 2026 03:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783913545; bh=sQ4youMK4F8CU445aZDFPowIII9kqkEWuc56EzJeDsA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=cETERcSU7gmNl05ntCgsvl86r6TEIGtus3y5ZU/PZs9stluHpEXHA1DU/5jW0rFSX hPzBabyVEC5QgW10acmJJogV6l8PjaT8ZkMVHmKJ3a6LCfux/TIT2TqtGN05b92JCA r6rSyzMQ6ElpfyBzwMF5VUdMtKCOYYK+Sd19km1Inw5HyKMQIupJm1BoO/Rroqud83 CKUkw6be1qtFxOCvlm1BA0yLlXADF3cy/gZF64oJsM0MGw7ZxKJIq5R58nEB4EUopQ 4rH4moV2rsPb1Qn646SMxSHH9yKS2MI1jy2+luiNxSuqg9UyBIdAga4DarwiuE3dge XbdaMB/bSxHHQ== From: Geliang Tang To: mptcp@lists.linux.dev Cc: Geliang Tang Subject: [PATCH mptcp-next v3 2/5] mptcp: add MSG_ZEROCOPY support Date: Mon, 13 Jul 2026 11:32:10 +0800 Message-ID: <3361a1c9bc1320d941f1490d781737b45008a0a1.1783913332.git.tanggeliang@kylinos.cn> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Geliang Tang This patch enables MSG_ZEROCOPY support for MPTCP sockets, allowing user-space to transmit data without intermediate kernel copies. The implementation follows the same lifecycle model as TCP: A single ubuf_info_msgzc is allocated per sendmsg via msg_zerocopy_realloc(). Its reference count consists of three parts: one 'caller' reference held until sendmsg returns, one reference per MPTCP dfrag in the retransmission queue (released when the dfrag is acked and cleared), and one reference per subflow skb that consumes dfrag bytes (released by TCP's skb_zcopy_clear() when the skb is acked). Completion is reported only after all bytes are acknowledged at both MPTCP and subflow levels. User pages are pinned via iov_iter_get_pages2() and stored directly in a newly allocated mptcp_data_frag. The dfrag takes one reference on the ubuf_info and one on the page. Subflow skbs take additional page references via get_page() and are marked with skb_zcopy_set() and SKBFL_PURE_ZEROCOPY, mirroring TCP's behavior and bypassing kernel memory accounting for those pages. The feature is silently downgraded to regular copy when MSG_FASTOPEN is set or the application has not opted in via setsockopt(SO_ZEROCOPY). If msg_zerocopy_realloc() fails (e.g. RLIMIT_MEMLOCK pressure), sendmsg(2) aborts with -ENOBUFS. Signed-off-by: Geliang Tang --- net/mptcp/protocol.c | 110 ++++++++++++++++++++++++++++++++++++++++--- net/mptcp/protocol.h | 1 + 2 files changed, 104 insertions(+), 7 deletions(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 1cab07b1b9b1..ec3e9905caa1 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -1118,9 +1118,11 @@ static bool mptcp_frag_can_collapse_to(const struct = mptcp_sock *msk, df->data_seq + df->data_len =3D=3D msk->write_seq; } =20 -static void dfrag_uncharge(struct sock *sk, int len) +static void dfrag_uncharge(struct sock *sk, int len, + struct mptcp_data_frag *dfrag) { - sk_mem_uncharge(sk, len); + if (!dfrag->ubuf) + sk_mem_uncharge(sk, len); sk_wmem_queued_add(sk, -len); } =20 @@ -1129,7 +1131,13 @@ static void dfrag_clear(struct sock *sk, struct mptc= p_data_frag *dfrag) int len =3D dfrag->data_len + dfrag->overhead; =20 list_del(&dfrag->list); - dfrag_uncharge(sk, len); + dfrag_uncharge(sk, len, dfrag); + if (dfrag->ubuf) { + net_zcopy_put(dfrag->ubuf); + put_page(dfrag->page); + kfree(dfrag); + return; + } put_page(dfrag->page); } =20 @@ -1174,7 +1182,7 @@ static void __mptcp_clean_una(struct sock *sk) dfrag->data_len -=3D delta; dfrag->already_sent -=3D delta; =20 - dfrag_uncharge(sk, delta); + dfrag_uncharge(sk, delta, dfrag); } =20 /* all retransmitted data acked, recovery completed */ @@ -1248,6 +1256,7 @@ mptcp_carve_data_frag(const struct mptcp_sock *msk, s= truct page_frag *pfrag, dfrag->already_sent =3D 0; dfrag->page =3D pfrag->page; dfrag->eor =3D 0; + dfrag->ubuf =3D NULL; =20 return dfrag; } @@ -1417,6 +1426,15 @@ static int mptcp_sendmsg_frag(struct sock *sk, struc= t sock *ssk, =20 i =3D skb_shinfo(skb)->nr_frags; can_coalesce =3D skb_can_coalesce(skb, i, dfrag->page, offset); + if (can_coalesce) { + bool zc =3D skb_shinfo(skb)->flags & SKBFL_PURE_ZEROCOPY; + + if (!!dfrag->ubuf !=3D zc) { + can_coalesce =3D false; + tcp_mark_push(tp, skb); + goto alloc_skb; + } + } if (!can_coalesce && i >=3D READ_ONCE(net_hotdata.sysctl_max_skb_frags))= { tcp_mark_push(tp, skb); goto alloc_skb; @@ -1455,7 +1473,7 @@ static int mptcp_sendmsg_frag(struct sock *sk, struct= sock *ssk, } =20 copy =3D min_t(size_t, copy, info->limit - info->sent); - if (!sk_wmem_schedule(ssk, copy)) { + if (!dfrag->ubuf && !sk_wmem_schedule(ssk, copy)) { tcp_remove_empty_skb(ssk); return -ENOMEM; } @@ -1465,13 +1483,19 @@ static int mptcp_sendmsg_frag(struct sock *sk, stru= ct sock *ssk, } else { get_page(dfrag->page); skb_fill_page_desc(skb, i, dfrag->page, offset, copy); + + if (dfrag->ubuf && !skb_zcopy(skb)) { + skb_zcopy_set(skb, dfrag->ubuf, NULL); + skb_shinfo(skb)->flags |=3D SKBFL_PURE_ZEROCOPY; + } } =20 skb->len +=3D copy; skb->data_len +=3D copy; skb->truesize +=3D copy; sk_wmem_queued_add(ssk, copy); - sk_mem_charge(ssk, copy); + if (!skb_zcopy_pure(skb)) + sk_mem_charge(ssk, copy); WRITE_ONCE(tp->write_seq, tp->write_seq + copy); TCP_SKB_CB(skb)->end_seq +=3D copy; tcp_skb_pcount_set(skb, 0); @@ -1968,22 +1992,79 @@ static void mptcp_rps_record_subflows(const struct = mptcp_sock *msk) } } =20 +static int mptcp_sendmsg_zerocopy_iter(struct sock *sk, struct msghdr *msg, + struct ubuf_info *ubuf, u32 copy_limit, + ssize_t *copied, long *timeo) +{ + struct mptcp_sock *msk =3D mptcp_sk(sk); + struct mptcp_data_frag *dfrag; + struct page *pages[1] =3D {}; + size_t pg_off =3D 0; + ssize_t pg_len; + + pg_len =3D iov_iter_get_pages2(&msg->msg_iter, pages, + copy_limit, 1, &pg_off); + if (pg_len < 0) + return pg_len; + /* pg_len =3D=3D 0 means the iterator is exhausted */ + if (pg_len =3D=3D 0) + return -EAGAIN; + + dfrag =3D kzalloc_obj(*dfrag, GFP_KERNEL_ACCOUNT); + if (!dfrag) { + put_page(pages[0]); + return -ENOMEM; + } + dfrag->data_len =3D pg_len; + dfrag->data_seq =3D msk->write_seq; + dfrag->offset =3D pg_off; + dfrag->page =3D pages[0]; + dfrag->ubuf =3D ubuf; + + /* one ref for the dfrag; released in dfrag_clear */ + net_zcopy_get(ubuf); + + *copied +=3D pg_len; + WRITE_ONCE(msk->write_seq, msk->write_seq + pg_len); + sk_wmem_queued_add(sk, pg_len); + + list_add_tail(&dfrag->list, &msk->rtx_queue); + if (!msk->first_pending) + msk->first_pending =3D dfrag; + + return 0; +} + static int mptcp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len) { struct mptcp_sock *msk =3D mptcp_sk(sk); + struct ubuf_info *ubuf =3D NULL; struct page_frag *pfrag; size_t copied =3D 0; + bool zc =3D false; int ret =3D 0; long timeo; =20 /* silently ignore everything else */ msg->msg_flags &=3D MSG_MORE | MSG_DONTWAIT | MSG_NOSIGNAL | - MSG_FASTOPEN | MSG_EOR; + MSG_FASTOPEN | MSG_EOR | MSG_ZEROCOPY; =20 lock_sock(sk); =20 mptcp_rps_record_subflows(msk); =20 + if (msg->msg_flags & MSG_FASTOPEN || !sock_flag(sk, SOCK_ZEROCOPY)) + msg->msg_flags &=3D ~MSG_ZEROCOPY; + + if ((msg->msg_flags & MSG_ZEROCOPY) && len) { + ubuf =3D msg_zerocopy_realloc(sk, len, NULL, false); + if (!ubuf) { + ret =3D -ENOBUFS; + goto do_error; + } + zc =3D true; + } + if (unlikely(inet_test_bit(DEFER_CONNECT, sk) || msg->msg_flags & MSG_FASTOPEN)) { int copied_syn =3D 0; @@ -2022,6 +2103,15 @@ static int mptcp_sendmsg(struct sock *sk, struct msg= hdr *msg, size_t len) if (!copy_limit) goto wait_for_memory; =20 + if (zc) { + ret =3D mptcp_sendmsg_zerocopy_iter(sk, msg, + ubuf, copy_limit, + &copied, &timeo); + if (ret) + goto do_error; + continue; + } + /* reuse tail pfrag, if possible, or carve a new one from the * page allocator */ @@ -2097,6 +2187,8 @@ static int mptcp_sendmsg(struct sock *sk, struct msgh= dr *msg, size_t len) } =20 out: + if (zc) + net_zcopy_put(ubuf); release_sock(sk); return copied; =20 @@ -2105,6 +2197,10 @@ static int mptcp_sendmsg(struct sock *sk, struct msg= hdr *msg, size_t len) goto out; =20 copied =3D sk_stream_error(sk, msg->msg_flags, ret); + if (zc) { + net_zcopy_put_abort(ubuf, true); + zc =3D false; + } goto out; } =20 diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h index da40c6f3705f..f4e69ea51a94 100644 --- a/net/mptcp/protocol.h +++ b/net/mptcp/protocol.h @@ -268,6 +268,7 @@ struct mptcp_data_frag { u8 eor; /* currently using 1 bit */ u16 already_sent; struct page *page; + struct ubuf_info *ubuf; }; =20 /* Arbitrary compromise between as low as possible to react timely to subf= low --=20 2.53.0 From nobody Sat Jul 25 07:27:12 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8461F336ECF for ; Mon, 13 Jul 2026 03:32:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783913549; cv=none; b=fBcL19V2tO3NnFwf054qx7P70m7KCUSlpOoMxCiI9sLaHcOJZab/sDVW0C8L82Px6ORXWjBfZFo6oolfqGk6m0mSZP1lSIWPJ5j2JFc+gezShP/gnn6sfpisu2MBY6sbvdmlOWbH+TsPUjfmoqTo1Aw1Uoau0HYVD5xPqggPRl8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783913549; c=relaxed/simple; bh=g12QInZZm9uAEB8vH+UVkxjY4g4LWQbgcUBV6Vl8YOw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RcEkBO/J3Ynqf/oOtbTC/2799MlbiiFtkKvcKm4r+EaZOBaz1GAdoLHtJAWxfx4PA0dSnYZFlYnhcI4jwEmiRU6tApjN+1vKdniypFiUrH+FPgEljBVjh1mHxrKckYsuWgRfSPM9VlNHPsEjfNYssstAeVlQH/zkUQEh3UWT9JU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LqjdXI2+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LqjdXI2+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BE731F00A3A; Mon, 13 Jul 2026 03:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783913546; bh=XLxKMUhOcEYVDrUxoiLdhpibnUKceSYQfHKS3MspWTw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LqjdXI2+nB5KyxC0xGhiPviZvqlschBuEAaIQd0oagK5gCFwa4AA+v6lmp1n90Vq5 SG+QFiWtDSHohETJ8VooboQLR5x9d9ruJi495dgnHdeFGl5mFYJrjJ9Jk5stPagrD9 xt9+qoU1gY5rRzsWYkWLH9B9wy+yv1OiKPU6AYABzRraMZueNyEv9hGEe+j76XbTp+ tJWhEf0GnuLxz8tOF5Stc/bBw6RazTrIPO4ilNBD6XdWctj6BgKTp29JQfm9kjZgUy MP2E43CFg/CO/M2gKeXs4H2o1W8arg5XWSpnhSpnPBNnKMyYYM7HN+0wBevz2bzhvs YuuNa7dUQ2fKw== From: Geliang Tang To: mptcp@lists.linux.dev Cc: Geliang Tang Subject: [PATCH mptcp-next v3 3/5] mptcp: handle SO_ZEROCOPY in setsockopt Date: Mon, 13 Jul 2026 11:32:11 +0800 Message-ID: <8d306e449fe38533265122fb09c67fb402a67be0.1783913332.git.tanggeliang@kylinos.cn> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Geliang Tang SO_ZEROCOPY is currently rejected by MPTCP setsockopt with -EOPNOTSUPP, even though the matching MSG_ZEROCOPY path in mptcp_sendmsg() is wired up. As a result MSG_ZEROCOPY silently falls back to a copy on MPTCP sockets because the opt-in flag is never set. Expose SO_ZEROCOPY through the SOL_SOCKET setsockopt dispatcher. The new mptcp_setsockopt_sol_socket_zerocopy() helper flips the flag on whichever socket owns the data path: the msk in non-fallback mode, the subflow TCP socket in fallback mode. The check in mptcp_sendmsg() reads the flag from the same socket, so opt-in is honoured on either path. Signed-off-by: Geliang Tang --- net/mptcp/sockopt.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/net/mptcp/sockopt.c b/net/mptcp/sockopt.c index fcf6feb2a9eb..abcc7d4452b4 100644 --- a/net/mptcp/sockopt.c +++ b/net/mptcp/sockopt.c @@ -175,6 +175,19 @@ static int mptcp_setsockopt_sol_socket_tstamp(struct m= ptcp_sock *msk, int optnam return 0; } =20 +static int mptcp_setsockopt_sol_socket_zerocopy(struct mptcp_sock *msk, in= t val) +{ + struct sock *sk =3D (struct sock *)msk; + + if (val !=3D 0 && val !=3D 1) + return -EINVAL; + + lock_sock(sk); + sock_valbool_flag(sk, SOCK_ZEROCOPY, val); + release_sock(sk); + return 0; +} + static int mptcp_setsockopt_sol_socket_int(struct mptcp_sock *msk, int opt= name, sockptr_t optval, unsigned int optlen) @@ -203,6 +216,8 @@ static int mptcp_setsockopt_sol_socket_int(struct mptcp= _sock *msk, int optname, case SO_TIMESTAMPNS_OLD: case SO_TIMESTAMPNS_NEW: return mptcp_setsockopt_sol_socket_tstamp(msk, optname, val); + case SO_ZEROCOPY: + return mptcp_setsockopt_sol_socket_zerocopy(msk, val); } =20 return -ENOPROTOOPT; @@ -342,6 +357,7 @@ static int mptcp_setsockopt_sol_socket(struct mptcp_soc= k *msk, int optname, case SO_TIMESTAMP_NEW: case SO_TIMESTAMPNS_OLD: case SO_TIMESTAMPNS_NEW: + case SO_ZEROCOPY: return mptcp_setsockopt_sol_socket_int(msk, optname, optval, optlen); case SO_TIMESTAMPING_OLD: @@ -387,7 +403,6 @@ static int mptcp_setsockopt_sol_socket(struct mptcp_soc= k *msk, int optname, * SO_CNX_ADVICE is currently unsupported, could possibly be relevant, * but likely needs careful design * - * SO_ZEROCOPY is currently unsupported, TODO in sndmsg * SO_TXTIME is currently unsupported */ =20 --=20 2.53.0 From nobody Sat Jul 25 07:27:12 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ADFA336EF8 for ; Mon, 13 Jul 2026 03:32:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783913549; cv=none; b=NDu7Pay/Rm3cMf+Ok5Q5DrOVdz+dSb3uMqwh8zkIaFYivBDELiRPoxiqlndU3OCk2prSpyNPIoFdVniIJdX+yz7lVMT/N1PgBZqdXzFqt57N1UMAi2gx0GRTs72D6QfdTb4PoIewAyVUzPE9Et0ABmsPc70Ok3Zcpklzt1JrXp0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783913549; c=relaxed/simple; bh=4Duva9Yr7m3YD4xANgbhMjll3Y3NVXM8exAKoKCT1LA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iGN2S/1eUHrezqSLog63319L1u/L54RQjeEfWTWiOQtJynSOlHHOH8N4rGzXXWs/a3vUbw6UNaZ5pLHmXUcQVVg/TZyKrq3Z5EEFZ6NSu1RDqOFM0eVTKWnOLdTnA/fTmtwEtp72tr2UOyasluyhQUkwONuKVxcLvimTJhGNyHY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=imkTZv7h; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="imkTZv7h" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D96151F000E9; Mon, 13 Jul 2026 03:32:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783913547; bh=2s1KB6ti+ihgUmNauc/eKmN72UCpwvDtY4nIsjO0D2M=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=imkTZv7hrC0Gx4sGlaiHBOx6DbeFSd/jxOi2X8H5Ht0Xtgaw+wUJopg5w2ADz3bLp UgqnE6DJ/gokINCqW0nGEIvTS9MHNkyI4MfzGQ9MLXUaWGhSx//DRc4OsJeTUhaA9k Y1DjXx6ibVDRFgG8JdCBhqSpoan237XTKlWf4mvzTNzoekIL5n+CZkjDg5FAymx35d cOwAOzszxJJL0UxpifVk4KwkO4eZKBowDtIb7kpQfxXIfp6LlADZqf7jZ/Rat+i3Ab LuKphxSUdRwfJHOTFLj2rbbEmx38JTziu70KLng2266OxmNmQlM+2kwWJxtl06YQMH 8fHOhu/hGSLWg== From: Geliang Tang To: mptcp@lists.linux.dev Cc: Geliang Tang Subject: [PATCH mptcp-next v3 4/5] selftests: mptcp: connect: add zerocopy io mode Date: Mon, 13 Jul 2026 11:32:12 +0800 Message-ID: X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Geliang Tang Add a new I/O mode 'zerocopy' to the mptcp_connect selftest, which uses sendmsg() with the MSG_ZEROCOPY flag to transmit data. This enables testing and performance validation of the zero-copy send path for both TCP and MPTCP connections. This mode is useful for benchmarking and for verifying correctness of MSG_ZEROCOPY handling in the MPTCP stack. Signed-off-by: Geliang Tang --- .../selftests/net/mptcp/mptcp_connect.c | 120 +++++++++++++++++- 1 file changed, 119 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.c b/tools/test= ing/selftests/net/mptcp/mptcp_connect.c index ea4cb6c1bd5e..715ccd98ff7d 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_connect.c +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.c @@ -33,6 +33,7 @@ #include #include #include +#include #include =20 extern int optind; @@ -53,6 +54,7 @@ enum cfg_mode { CFG_MODE_MMAP, CFG_MODE_SENDFILE, CFG_MODE_SPLICE, + CFG_MODE_ZEROCOPY, }; =20 enum cfg_peek { @@ -125,7 +127,7 @@ static void die_usage(void) fprintf(stderr, "\t-j -- add additional sleep at connection start and= tear down " "-- for MPJ tests\n"); fprintf(stderr, "\t-l -- listens mode, accepts incoming connection\n"= ); - fprintf(stderr, "\t-m [poll|mmap|sendfile|splice] -- use poll(default)/mm= ap+write/sendfile/splice\n"); + fprintf(stderr, "\t-m [poll|mmap|sendfile|splice|zerocopy] -- use poll(de= fault)/mmap+write/sendfile/splice/zerocopy\n"); fprintf(stderr, "\t-M mark -- set socket packet mark\n"); fprintf(stderr, "\t-o option -- test sockopt