From: Gang Yan <yangang@kylinos.cn>

Hi Paolo,Matt:

The patches have replaced the original backlog_list with an rb-tree based
'backlog_queue', and resolved the existing transmission stall issues by using
the new backlog_queue infrastructure.

Looking forward to your comments and feedback.

Thanks
Gang

Gang Yan (3):
  mptcp: replace backlog_list with backlog_queue
  mptcp: fix the stall problems using backlog_queue
  mptcp: fix the stall problems with data_ready

 net/mptcp/protocol.c | 93 +++++++++++++++++++++++++++++++++++++-------
 net/mptcp/protocol.h |  2 +-
 2 files changed, 81 insertions(+), 14 deletions(-)

-- 
2.43.0

Hi Gang,

After testing, I found that with this set applied, the TLS test still
fails occasionally.

On Tue, 2026-03-17 at 16:36 +0800, Gang Yan wrote:
> From: Gang Yan <yangang@kylinos.cn>
> 
> Hi Paolo,Matt:
> 
> The patches have replaced the original backlog_list with an rb-tree
> based
> 'backlog_queue', and resolved the existing transmission stall issues
> by using
> the new backlog_queue infrastructure.
> 
> Looking forward to your comments and feedback.
> 
> Thanks
> Gang
> 
> Gang Yan (3):
>   mptcp: replace backlog_list with backlog_queue
>   mptcp: fix the stall problems using backlog_queue
>   mptcp: fix the stall problems with data_ready

As we discussed, in patch 3 we should pass "delta" to
mptcp_backlog_spooled(), not "moved". Additionally, it would be better
to extract this logic into a separate helper rather than embedding it
directly in move_skbs_to_msk().

For patch 2, I suggest putting

	sk_rmem_alloc_get(sk) > sk->sk_rcvbuf &&
	!skb_queue_empty(&sk->sk_receive_queue)

into a helper, e.g., mptcp_recvbuf_is_full().

I've changed the status of this set to "Changes Requested".

Thanks,
-Geliang

> 
>  net/mptcp/protocol.c | 93 +++++++++++++++++++++++++++++++++++++-----
> --
>  net/mptcp/protocol.h |  2 +-
>  2 files changed, 81 insertions(+), 14 deletions(-)

Hi Gang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal (except selftest_mptcp_join): Success! ✅
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Unstable: 1 failed test(s): packetdrill_mp_capable 🔴
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/23186215138

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/68246fd6f6f3
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1067816


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)