From nobody Wed Dec 17 07:24:37 2025 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35FE913AF2 for ; Wed, 16 Apr 2025 07:35:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744788932; cv=none; b=hqBabjg5Xr0oumtpXaZNGGY3mhmOFodTQPqI6rJJnUzxTW30oqpg1F82tFep67/rl0Z31by/xmzqDsShOp3p+M10z91RqX935ePFGlIiOzgCTIXp23a78FaVYXDah1KPkmGH0XDJXANdwAWH53DViTIBset8GQmtEBayX8ypVcw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744788932; c=relaxed/simple; bh=bJ3w9T5d01j5OUcWOA7t1Yn36CKIiTEy1rNkGjtJygU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nLmY5vJTbt7Q7PSFx2w0wrIW/d0aLswfchTMDh8PIUCzZxr1XVFGsku5PRoHUXkcnoMJSaPcF/+9m657jGm26Y5x0XMiqca5VwB7TttWhu8lEwBCNFsRuYLqpl0Nq2DY+Nl1KhfoH0to+NrzaXpfju/TnBgFADJUhk7+4hv0wGA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 59d7875a1a9511f0a216b1d71e6e1362-20250416 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CTE_8B, HR_CTT_MISS HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME, HR_SJ_DIGIT_LEN HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED, SA_EXISTED SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS, CIE_BAD CIE_GOOD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO, GTI_C_BU AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU, ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:3d41f172-c4d5-433c-a099-20c3af61f379,IP:10, URL:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:20 X-CID-INFO: VERSION:1.1.45,REQID:3d41f172-c4d5-433c-a099-20c3af61f379,IP:10,UR L:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:20 X-CID-META: VersionHash:6493067,CLOUDID:89388fe6714e5247ac819ef808e710a0,BulkI D:25041615352166EMH78U,BulkQuantity:0,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil ,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 59d7875a1a9511f0a216b1d71e6e1362-20250416 X-User: yangang@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 490486856; Wed, 16 Apr 2025 15:35:20 +0800 From: Gang Yan To: mptcp@lists.linux.dev Cc: Gang Yan , Geliang Tang Subject: [mptcp-next 1/7] selftests: mptcp: add struct params in mptcp_diag Date: Wed, 16 Apr 2025 15:34:56 +0800 Message-Id: <6a4ff59fc2440ed70d359113f72756e895d812ab.1744788247.git.yangang@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch adds a struct named 'params' to save 'target_token' and other future parameters. This structure facilitates future function expansions. Co-developed-by: Geliang Tang Signed-off-by: Geliang Tang Signed-off-by: Gang Yan --- tools/testing/selftests/net/mptcp/mptcp_diag.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_diag.c b/tools/testing= /selftests/net/mptcp/mptcp_diag.c index 37d5015ad08c..ea7cb1128044 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_diag.c +++ b/tools/testing/selftests/net/mptcp/mptcp_diag.c @@ -19,6 +19,10 @@ #define IPPROTO_MPTCP 262 #endif =20 +struct params { + __u32 target_token; +}; + struct mptcp_info { __u8 mptcpi_subflows; __u8 mptcpi_add_addr_signal; @@ -237,7 +241,7 @@ static void get_mptcpinfo(__u32 token) close(fd); } =20 -static void parse_opts(int argc, char **argv, __u32 *target_token) +static void parse_opts(int argc, char **argv, struct params *p) { int c; =20 @@ -250,7 +254,7 @@ static void parse_opts(int argc, char **argv, __u32 *ta= rget_token) die_usage(0); break; case 't': - sscanf(optarg, "%x", target_token); + sscanf(optarg, "%x", &p->target_token); break; default: die_usage(1); @@ -261,10 +265,12 @@ static void parse_opts(int argc, char **argv, __u32 *= target_token) =20 int main(int argc, char *argv[]) { - __u32 target_token; + struct params p =3D { 0 }; + + parse_opts(argc, argv, &p); =20 - parse_opts(argc, argv, &target_token); - get_mptcpinfo(target_token); + if (p.target_token) + get_mptcpinfo(p.target_token); =20 return 0; } --=20 2.25.1 From nobody Wed Dec 17 07:24:37 2025 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8242B227E8C for ; Wed, 16 Apr 2025 07:35:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744788932; cv=none; b=V5mUNN9U4WfJaepuQqZBWaqlYC8/5m9LhIUwqUAB+x9qKLzqbQ8e5GxrHC9pP5vNq5QrgzKqX+W9wPuYe9R/yYhAG2mA2PCWJK+G0h8Hj9rrGdBIsVesR6aOtnInQC0CrV+htwVVSuj9sVOOMLtgbAFG3SRCkM9bbuBExRcOfVI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744788932; c=relaxed/simple; bh=HWFxL02gyAEjllc4b1cFVoH1UM1yfqTRaOIc+AZK8rA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QFXNn2vaRhJrUuJC0K765rTRcokN1JmiMdhpytcQ7JC5/KdrLEbMV9+c4n9joMKi1LVlRL3BDGTwBCqpfLGTeXqOlkT51lgXVWZCCoyy77ia9aBygDiBWlTkOieeyvY8w8greMDMM0Zf7ZD4lmpNwRyIHLMwyX8kZLsG4CnGPsQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 5a4c9af41a9511f0a216b1d71e6e1362-20250416 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CTE_8B, HR_CTT_MISS HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME, HR_SJ_DIGIT_LEN HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED, SA_EXISTED SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS, CIE_BAD CIE_GOOD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO, GTI_C_BU AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU, ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:0caf1360-446a-4202-ab41-2a62c1716af8,IP:10, URL:0,TC:0,Content:-5,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,AC TION:release,TS:15 X-CID-INFO: VERSION:1.1.45,REQID:0caf1360-446a-4202-ab41-2a62c1716af8,IP:10,UR L:0,TC:0,Content:-5,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:15 X-CID-META: VersionHash:6493067,CLOUDID:acd783bcf019d5643cabfd9b1f155f93,BulkI D:250416153524DZ7LI12W,BulkQuantity:0,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil ,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 5a4c9af41a9511f0a216b1d71e6e1362-20250416 X-User: yangang@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 969907493; Wed, 16 Apr 2025 15:35:21 +0800 From: Gang Yan To: mptcp@lists.linux.dev Cc: Gang Yan , Geliang Tang Subject: [mptcp-next 2/7] selftests: mptcp: refactor send_query parameters for code clarity Date: Wed, 16 Apr 2025 15:34:57 +0800 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch use 'inet_diag_req_v2' instead of 'token' as parameters of send_query, and construct the req in 'get_mptcpinfo'. This modification can enhance the enhancing clarity of the code, and prepare for the dump_subflow_info. Co-developed-by: Geliang Tang Signed-off-by: Geliang Tang Signed-off-by: Gang Yan --- .../testing/selftests/net/mptcp/mptcp_diag.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_diag.c b/tools/testing= /selftests/net/mptcp/mptcp_diag.c index ea7cb1128044..8a5b7745c58c 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_diag.c +++ b/tools/testing/selftests/net/mptcp/mptcp_diag.c @@ -62,7 +62,7 @@ static void die_usage(int r) exit(r); } =20 -static void send_query(int fd, __u32 token) +static void send_query(int fd, struct inet_diag_req_v2 *r) { struct sockaddr_nl nladdr =3D { .nl_family =3D AF_NETLINK @@ -76,19 +76,13 @@ static void send_query(int fd, __u32 token) .nlmsg_type =3D SOCK_DIAG_BY_FAMILY, .nlmsg_flags =3D NLM_F_REQUEST }, - .r =3D { - .sdiag_family =3D AF_INET, - /* Real proto is set via INET_DIAG_REQ_PROTOCOL */ - .sdiag_protocol =3D IPPROTO_TCP, - .id.idiag_cookie[0] =3D token, - } + .r =3D *r }; struct rtattr rta_proto; struct iovec iov[6]; int iovlen =3D 1; __u32 proto; =20 - req.r.idiag_ext |=3D (1 << (INET_DIAG_INFO - 1)); proto =3D IPPROTO_MPTCP; rta_proto.rta_type =3D INET_DIAG_REQ_PROTOCOL; rta_proto.rta_len =3D RTA_LENGTH(sizeof(proto)); @@ -229,13 +223,20 @@ static void recv_nlmsg(int fd) =20 static void get_mptcpinfo(__u32 token) { + struct inet_diag_req_v2 r =3D { + .sdiag_family =3D AF_INET, + /* Real proto is set via INET_DIAG_REQ_PROTOCOL */ + .sdiag_protocol =3D IPPROTO_TCP, + .id.idiag_cookie[0] =3D token, + }; int fd; =20 fd =3D socket(AF_NETLINK, SOCK_RAW, NETLINK_SOCK_DIAG); if (fd < 0) die_perror("Netlink socket"); =20 - send_query(fd, token); + r.idiag_ext |=3D (1 << (INET_DIAG_INFO - 1)); + send_query(fd, &r); recv_nlmsg(fd); =20 close(fd); --=20 2.25.1 From nobody Wed Dec 17 07:24:37 2025 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAD4D21CC68 for ; Wed, 16 Apr 2025 07:35:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744788931; cv=none; b=KLZUgvqswjZu2BGRvVGteaFCHcUJuq36zyxSOu6d3gDw2jUERxXaowBf/0aRr78k9eVFiH3It2IDS+pPxMdHepeHJuksGUBBE8/wsqeIfJHzog/2z64VMGP9IOngA7oHk8IFRjBn21Fv30s869jHVYaRz3AXI43mx2asSMZ2eMc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744788931; c=relaxed/simple; bh=BW6NpZnCo+0deIKmd/Q2TPg/qSM7niTHSnwsq72ec+I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LhaO7F/UFxUgilLBEZjMIB3CwcDYOPha8yqiJTUR6ic9gCVs2RlR9hwNj1Aj77QJiSMRD+teFzHNxjBUGsbBzEQR6v9XaSjCreZWrFHgj9pez4T84O67A3b7FT7smgp0QGYvedd88k8ehTfdV6Kxqs10DgJqL7pxm4i2+IFk79s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 5a9dd3061a9511f0a216b1d71e6e1362-20250416 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CTE_8B, HR_CTT_MISS HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME, HR_SJ_DIGIT_LEN HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED, SA_EXISTED SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS, CIE_BAD CIE_GOOD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO, GTI_C_BU AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU, ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:97b30044-44f5-4e93-9f24-40b917075acc,IP:10, URL:0,TC:0,Content:-5,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,AC TION:release,TS:15 X-CID-INFO: VERSION:1.1.45,REQID:97b30044-44f5-4e93-9f24-40b917075acc,IP:10,UR L:0,TC:0,Content:-5,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:15 X-CID-META: VersionHash:6493067,CLOUDID:c33e7508e7e02f4f54bee89bbe387bd8,BulkI D:250416153523YMAXUWZ0,BulkQuantity:0,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil ,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 5a9dd3061a9511f0a216b1d71e6e1362-20250416 X-User: yangang@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1276996382; Wed, 16 Apr 2025 15:35:22 +0800 From: Gang Yan To: mptcp@lists.linux.dev Cc: Gang Yan , Geliang Tang Subject: [mptcp-next 3/7] selftests: mptcp: refine the 'iovlen' handling logic Date: Wed, 16 Apr 2025 15:34:58 +0800 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the original version, the handling logic for the 'iovlen' appeared somewhat redundant. Therefore, 'iovlen++' is used to simpify this portion of the code and improve its readaility. Co-developed-by: Geliang Tang Signed-off-by: Geliang Tang Signed-off-by: Gang Yan --- tools/testing/selftests/net/mptcp/mptcp_diag.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_diag.c b/tools/testing= /selftests/net/mptcp/mptcp_diag.c index 8a5b7745c58c..2bf13bce59a5 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_diag.c +++ b/tools/testing/selftests/net/mptcp/mptcp_diag.c @@ -91,10 +91,9 @@ static void send_query(int fd, struct inet_diag_req_v2 *= r) .iov_base =3D &req, .iov_len =3D sizeof(req) }; - iov[iovlen] =3D (struct iovec){ &rta_proto, sizeof(rta_proto)}; - iov[iovlen + 1] =3D (struct iovec){ &proto, sizeof(proto)}; + iov[iovlen++] =3D (struct iovec){ &rta_proto, sizeof(rta_proto)}; + iov[iovlen++] =3D (struct iovec){ &proto, sizeof(proto)}; req.nlh.nlmsg_len +=3D RTA_LENGTH(sizeof(proto)); - iovlen +=3D 2; struct msghdr msg =3D { .msg_name =3D &nladdr, .msg_namelen =3D sizeof(nladdr), --=20 2.25.1 From nobody Wed Dec 17 07:24:37 2025 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4AE5223321 for ; Wed, 16 Apr 2025 07:35:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744788931; cv=none; b=flfHygNkOX0P7bM53yJCV/0y/BtMkBhHwcotolMW2apD/gM9pwTR8cYRSBIJypRhKUNm7Br0I01IPbg9GETiaTwtHqbLzUXQoZhsn71qx7+U5O5U2/NqpUmrq/OgxCgcY7z9ff5xzYGGyrQ6Gg4rjdUVryOm5sMOexQaKmPzVOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744788931; c=relaxed/simple; bh=szdCIUhh36euvta9ld5fXdLJU53+1uLSY44TeKLyhpc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=qxplAaeqZApTP5lZ+j5rwFlCxpafQuPqcna2yVopmqvG8u0CkinJ281QdD5SEX4r2hQmw71urgjlk+5T4JoEmRBg2DYv/IXMhGsepnTN4DYyd39mqqg/+c91h5JPw7o5OfL+g9NrRCA+StWUhALi9PVENP1h7jIPXzaPFLsZy1k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 5af2eeae1a9511f0a216b1d71e6e1362-20250416 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CTE_8B, HR_CTT_MISS HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME, HR_SJ_DIGIT_LEN HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED, SA_EXISTED SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS, CIE_BAD CIE_GOOD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO, GTI_C_BU AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU, ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:66f53f72-1d02-4547-a380-01b53e43ba3d,IP:10, URL:0,TC:0,Content:-5,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,AC TION:release,TS:15 X-CID-INFO: VERSION:1.1.45,REQID:66f53f72-1d02-4547-a380-01b53e43ba3d,IP:10,UR L:0,TC:0,Content:-5,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:15 X-CID-META: VersionHash:6493067,CLOUDID:e00b5d22f7555ca02cd1addc44314817,BulkI D:250416153524UFUMVPOK,BulkQuantity:0,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil ,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 5af2eeae1a9511f0a216b1d71e6e1362-20250416 X-User: yangang@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 2120939587; Wed, 16 Apr 2025 15:35:22 +0800 From: Gang Yan To: mptcp@lists.linux.dev Cc: Gang Yan , Geliang Tang Subject: [mptcp-next 4/7] selftests: mptcp: refactor NLMSG handling with 'proto' Date: Wed, 16 Apr 2025 15:34:59 +0800 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch introduces the '__u32 proto' variable to the 'send_query' and 'recv_nlmsg' functions for further extending function. In the 'send_query' function, the inclusion of this variable makes the structure clearer and more readable. In the 'recv_nlmsg' function, the '__u32 proto' variable ensures that the 'diag_info' field remains unmodified when processing IPPROTO_TCP data, thereby preventing unintended transformation into 'mptcp_info' format. Co-developed-by: Geliang Tang Signed-off-by: Geliang Tang Signed-off-by: Gang Yan --- .../testing/selftests/net/mptcp/mptcp_diag.c | 33 ++++++++++--------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_diag.c b/tools/testing= /selftests/net/mptcp/mptcp_diag.c index 2bf13bce59a5..2116b40bc927 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_diag.c +++ b/tools/testing/selftests/net/mptcp/mptcp_diag.c @@ -62,7 +62,7 @@ static void die_usage(int r) exit(r); } =20 -static void send_query(int fd, struct inet_diag_req_v2 *r) +static void send_query(int fd, struct inet_diag_req_v2 *r, __u32 proto) { struct sockaddr_nl nladdr =3D { .nl_family =3D AF_NETLINK @@ -81,19 +81,21 @@ static void send_query(int fd, struct inet_diag_req_v2 = *r) struct rtattr rta_proto; struct iovec iov[6]; int iovlen =3D 1; - __u32 proto; - - proto =3D IPPROTO_MPTCP; - rta_proto.rta_type =3D INET_DIAG_REQ_PROTOCOL; - rta_proto.rta_len =3D RTA_LENGTH(sizeof(proto)); =20 iov[0] =3D (struct iovec) { .iov_base =3D &req, .iov_len =3D sizeof(req) }; - iov[iovlen++] =3D (struct iovec){ &rta_proto, sizeof(rta_proto)}; - iov[iovlen++] =3D (struct iovec){ &proto, sizeof(proto)}; - req.nlh.nlmsg_len +=3D RTA_LENGTH(sizeof(proto)); + + if (proto =3D=3D IPPROTO_MPTCP) { + rta_proto.rta_type =3D INET_DIAG_REQ_PROTOCOL; + rta_proto.rta_len =3D RTA_LENGTH(sizeof(proto)); + + iov[iovlen++] =3D (struct iovec){ &rta_proto, sizeof(rta_proto)}; + iov[iovlen++] =3D (struct iovec){ &proto, sizeof(proto)}; + req.nlh.nlmsg_len +=3D RTA_LENGTH(sizeof(proto)); + } + struct msghdr msg =3D { .msg_name =3D &nladdr, .msg_namelen =3D sizeof(nladdr), @@ -157,7 +159,7 @@ static void print_info_msg(struct mptcp_info *info) printf("bytes_acked: %llu\n", info->mptcpi_bytes_acked); } =20 -static void parse_nlmsg(struct nlmsghdr *nlh) +static void parse_nlmsg(struct nlmsghdr *nlh, __u32 proto) { struct inet_diag_msg *r =3D NLMSG_DATA(nlh); struct rtattr *tb[INET_DIAG_MAX + 1]; @@ -166,7 +168,7 @@ static void parse_nlmsg(struct nlmsghdr *nlh) nlh->nlmsg_len - NLMSG_LENGTH(sizeof(*r)), NLA_F_NESTED); =20 - if (tb[INET_DIAG_INFO]) { + if (proto =3D=3D IPPROTO_MPTCP && tb[INET_DIAG_INFO]) { int len =3D RTA_PAYLOAD(tb[INET_DIAG_INFO]); struct mptcp_info *info; =20 @@ -182,7 +184,7 @@ static void parse_nlmsg(struct nlmsghdr *nlh) } } =20 -static void recv_nlmsg(int fd) +static void recv_nlmsg(int fd, __u32 proto) { char rcv_buff[8192]; struct nlmsghdr *nlh =3D (struct nlmsghdr *)rcv_buff; @@ -215,7 +217,7 @@ static void recv_nlmsg(int fd) -(err->error), strerror(-(err->error))); break; } - parse_nlmsg(nlh); + parse_nlmsg(nlh, proto); nlh =3D NLMSG_NEXT(nlh, len); } } @@ -228,6 +230,7 @@ static void get_mptcpinfo(__u32 token) .sdiag_protocol =3D IPPROTO_TCP, .id.idiag_cookie[0] =3D token, }; + __u32 proto =3D IPPROTO_MPTCP; int fd; =20 fd =3D socket(AF_NETLINK, SOCK_RAW, NETLINK_SOCK_DIAG); @@ -235,8 +238,8 @@ static void get_mptcpinfo(__u32 token) die_perror("Netlink socket"); =20 r.idiag_ext |=3D (1 << (INET_DIAG_INFO - 1)); - send_query(fd, &r); - recv_nlmsg(fd); + send_query(fd, &r, proto); + recv_nlmsg(fd, proto); =20 close(fd); } --=20 2.25.1 From nobody Wed Dec 17 07:24:37 2025 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36037161310 for ; Wed, 16 Apr 2025 07:35:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744788931; cv=none; b=gr1EQFgy+XIcB9g5EjCuTNcaT6aDesGOtaLvaIPNFziV6WGE/P/QRiksh0Aa5J6Khq+ylwxPUf6Qha8RO35Q7QroV2Uau11+WaHx6mdWlrvWlUXiOTSYdvyKkU9lGi/QtAuIlsu1mk4/uXr9/AGqunT4VMKG93lAM94p1UvRL8w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744788931; c=relaxed/simple; bh=FTPDU2WjmnHKfWmgRWmpcMI2cB1K03US9BQl12M6GRE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DxeI01aA8e2bs6aY7fQhZVuzGdsRSnWoKEBTBS8A0DqOyO73sg2xO+L2DKNg/Ah+1mFGbnZBJqxW4812CipEWQq5/UKj6nKNpXWMYWyVmDmxCSJit2CRH5Tfj+gbqj8paB2eE7s9fzl7EJ3X9Q0be7WSw6FpWOnFvLFnz3Key4M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 5b694e5a1a9511f0a216b1d71e6e1362-20250416 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CTE_8B, HR_CTT_MISS HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME, HR_SJ_DIGIT_LEN HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED, SA_EXISTED SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS, CIE_BAD CIE_GOOD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO, GTI_C_BU AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU, ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:d223c18a-4d13-49db-9247-03f1b51baf13,IP:10, URL:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:20 X-CID-INFO: VERSION:1.1.45,REQID:d223c18a-4d13-49db-9247-03f1b51baf13,IP:10,UR L:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:20 X-CID-META: VersionHash:6493067,CLOUDID:e42b566278685d825a3fd508fb64c3bd,BulkI D:250416153524Q2NAITM6,BulkQuantity:0,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil ,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-UUID: 5b694e5a1a9511f0a216b1d71e6e1362-20250416 X-User: yangang@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1391373566; Wed, 16 Apr 2025 15:35:23 +0800 From: Gang Yan To: mptcp@lists.linux.dev Cc: Gang Yan , Geliang Tang Subject: [mptcp-next 5/7] selftests: mptcp: add a helper to get subflow_info Date: Wed, 16 Apr 2025 15:35:00 +0800 Message-Id: <4147cca0b271a635059089415cf51a6072389c1c.1744788247.git.yangang@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch adds 'get_subflow_info' in 'mptcp_diag', which can check whether a TCP connection is an MPTCP subflow based on the "INET_ULP_INFO_MPTCP" with tcp_diag method. Co-developed-by: Geliang Tang Signed-off-by: Geliang Tang Signed-off-by: Gang Yan --- .../testing/selftests/net/mptcp/mptcp_diag.c | 68 ++++++++++++++++++- 1 file changed, 66 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/mptcp_diag.c b/tools/testing= /selftests/net/mptcp/mptcp_diag.c index 2116b40bc927..03c92940e461 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_diag.c +++ b/tools/testing/selftests/net/mptcp/mptcp_diag.c @@ -8,6 +8,7 @@ #include #include #include +#include =20 #include #include @@ -19,8 +20,13 @@ #define IPPROTO_MPTCP 262 #endif =20 +#define parse_rtattr_nested(tb, max, rta) \ + (parse_rtattr_flags((tb), (max), RTA_DATA(rta), RTA_PAYLOAD(rta), \ + NLA_F_NESTED)) + struct params { __u32 target_token; + char subflow_addr[1024]; }; =20 struct mptcp_info { @@ -58,7 +64,9 @@ static void die_perror(const char *msg) =20 static void die_usage(int r) { - fprintf(stderr, "Usage: mptcp_diag -t\n"); + fprintf(stderr, "Usage:\n" + "mptcp_diag -t \n" + "mptcp_diag -s \" \"\n"); exit(r); } =20 @@ -182,6 +190,21 @@ static void parse_nlmsg(struct nlmsghdr *nlh, __u32 pr= oto) } print_info_msg(info); } + if (proto =3D=3D IPPROTO_TCP && tb[INET_DIAG_ULP_INFO]) { + struct rtattr *ulpinfo[INET_ULP_INFO_MAX + 1] =3D { 0 }; + + parse_rtattr_nested(ulpinfo, INET_ULP_INFO_MAX, + tb[INET_DIAG_ULP_INFO]); + + if (ulpinfo[INET_ULP_INFO_MPTCP]) { + struct rtattr *sfinfo[MPTCP_SUBFLOW_ATTR_MAX + 1] =3D { 0 }; + + parse_rtattr_nested(sfinfo, MPTCP_SUBFLOW_ATTR_MAX, + ulpinfo[INET_ULP_INFO_MPTCP]); + } else { + printf("It's a normal TCP!\n"); + } + } } =20 static void recv_nlmsg(int fd, __u32 proto) @@ -244,6 +267,41 @@ static void get_mptcpinfo(__u32 token) close(fd); } =20 +static void get_subflow_info(char *subflow_addr) +{ + struct inet_diag_req_v2 r =3D { + .sdiag_family =3D AF_INET, + .sdiag_protocol =3D IPPROTO_TCP, + }; + int sport, dport; + char saddr[64]; // Take ipv6 into consideration + char daddr[64]; + int ret; + int fd; + + ret =3D sscanf(subflow_addr, "%s %d %s %d", saddr, &sport, daddr, &dport); + if (ret !=3D 4) + die_perror("IP PORT Pairs has style problems!"); + + printf("%s:%d -> %s:%d\n", saddr, sport, daddr, dport); + + fd =3D socket(AF_NETLINK, SOCK_RAW, NETLINK_SOCK_DIAG); + if (fd < 0) + die_perror("Netlink socket"); + + r.id.idiag_cookie[0] =3D INET_DIAG_NOCOOKIE; + r.id.idiag_cookie[1] =3D INET_DIAG_NOCOOKIE; + r.id.idiag_sport =3D htons(sport); + r.id.idiag_dport =3D htons(dport); + r.id.idiag_if =3D 0; + + inet_pton(AF_INET, saddr, &r.id.idiag_src); + inet_pton(AF_INET, daddr, &r.id.idiag_dst); + r.idiag_ext |=3D (1 << (INET_DIAG_INFO - 1)); + send_query(fd, &r, IPPROTO_TCP); + recv_nlmsg(fd, IPPROTO_TCP); +} + static void parse_opts(int argc, char **argv, struct params *p) { int c; @@ -251,7 +309,7 @@ static void parse_opts(int argc, char **argv, struct pa= rams *p) if (argc < 2) die_usage(1); =20 - while ((c =3D getopt(argc, argv, "ht:")) !=3D -1) { + while ((c =3D getopt(argc, argv, "ht:s:")) !=3D -1) { switch (c) { case 'h': die_usage(0); @@ -259,6 +317,9 @@ static void parse_opts(int argc, char **argv, struct pa= rams *p) case 't': sscanf(optarg, "%x", &p->target_token); break; + case 's': + snprintf(p->subflow_addr, strlen(optarg) + 1, "%s", optarg); + break; default: die_usage(1); break; @@ -275,6 +336,9 @@ int main(int argc, char *argv[]) if (p.target_token) get_mptcpinfo(p.target_token); =20 + if (strlen(p.subflow_addr) !=3D 0) + get_subflow_info(p.subflow_addr); + return 0; } =20 --=20 2.25.1 From nobody Wed Dec 17 07:24:37 2025 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DABB2185BD for ; Wed, 16 Apr 2025 07:35:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744788933; cv=none; b=RrexPqLJ5KpCPA4b+M0n5s2tFB1iZxku5xrNNuddx3LG/2sIyRxiwpeI2FIhAu5BL25ADrcQwvdBF5WvVLkAJouVZD/sGUR0Bn4Ht6+Ldg9EewDwKZjw3DfQdi55FpStwJKQkmRXlGGeOFiS552qHuOFkhfV2SdgfyFwWb7gIVo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744788933; c=relaxed/simple; bh=7Hvt2RlIgarhgbmejPVKxvIMrRJMr/baQN9rxySVxfc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BOysmuJ+bqXB9B1BNXfYaPaFPga4MQb4XfgdByhHlK6tGoKhGaese6MdgjxPdoTRKs9RFp6sjPaxlvaxQ2hpZW9XFclT+GQ7+BghQQh8KYF0qhM1BB8V+Te6imnYRCX5ZNk68I60vJRbkFP9YN4UQ6BVu6vmAYJwoFEjfDBos+o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 5bc1460a1a9511f0a216b1d71e6e1362-20250416 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CTE_8B, HR_CTT_MISS HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME, HR_SJ_DIGIT_LEN HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED, SA_EXISTED SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS, CIE_BAD CIE_GOOD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO, GTI_C_BU AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU, ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:d840b464-3ac3-4537-87a9-6ec8fbac1f9b,IP:10, URL:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:20 X-CID-INFO: VERSION:1.1.45,REQID:d840b464-3ac3-4537-87a9-6ec8fbac1f9b,IP:10,UR L:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:20 X-CID-META: VersionHash:6493067,CLOUDID:2a0088b8ae9530806dc6c4e90d8f5e5d,BulkI D:2504161535279HTSHQT2,BulkQuantity:0,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil ,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI,TF_CID_SPAM_SNR X-UUID: 5bc1460a1a9511f0a216b1d71e6e1362-20250416 X-User: yangang@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1118033047; Wed, 16 Apr 2025 15:35:24 +0800 From: Gang Yan To: mptcp@lists.linux.dev Cc: Gang Yan , Geliang Tang Subject: [mptcp-next 6/7] selftests: mptcp: add a helper to print subflow_info Date: Wed, 16 Apr 2025 15:35:01 +0800 Message-Id: <47df0cf54a81cea8e6d1f0af8478c30dd16483d1.1744788247.git.yangang@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch adds 'print_subflow_info' in 'mptcp_diag', which can print the subflow_filed of an MPTCP subflow. This function is for further checking the 'subflow_info' through inet_diag method. Co-developed-by: Geliang Tang Signed-off-by: Geliang Tang Signed-off-by: Gang Yan --- .../testing/selftests/net/mptcp/mptcp_diag.c | 90 +++++++++++++++++++ 1 file changed, 90 insertions(+) diff --git a/tools/testing/selftests/net/mptcp/mptcp_diag.c b/tools/testing= /selftests/net/mptcp/mptcp_diag.c index 03c92940e461..25495c7e1c74 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_diag.c +++ b/tools/testing/selftests/net/mptcp/mptcp_diag.c @@ -56,6 +56,36 @@ struct mptcp_info { __u32 mptcpi_last_ack_recv; }; =20 +enum { + MPTCP_SUBFLOW_ATTR_UNSPEC, + MPTCP_SUBFLOW_ATTR_TOKEN_REM, + MPTCP_SUBFLOW_ATTR_TOKEN_LOC, + MPTCP_SUBFLOW_ATTR_RELWRITE_SEQ, + MPTCP_SUBFLOW_ATTR_MAP_SEQ, + MPTCP_SUBFLOW_ATTR_MAP_SFSEQ, + MPTCP_SUBFLOW_ATTR_SSN_OFFSET, + MPTCP_SUBFLOW_ATTR_MAP_DATALEN, + MPTCP_SUBFLOW_ATTR_FLAGS, + MPTCP_SUBFLOW_ATTR_ID_REM, + MPTCP_SUBFLOW_ATTR_ID_LOC, + MPTCP_SUBFLOW_ATTR_PAD, + + __MPTCP_SUBFLOW_ATTR_MAX +}; +#define MPTCP_SUBFLOW_ATTR_MAX (__MPTCP_SUBFLOW_ATTR_MAX - 1) + +#define MPTCP_SUBFLOW_FLAG_MCAP_REM _BITUL(0) +#define MPTCP_SUBFLOW_FLAG_MCAP_LOC _BITUL(1) +#define MPTCP_SUBFLOW_FLAG_JOIN_REM _BITUL(2) +#define MPTCP_SUBFLOW_FLAG_JOIN_LOC _BITUL(3) +#define MPTCP_SUBFLOW_FLAG_BKUP_REM _BITUL(4) +#define MPTCP_SUBFLOW_FLAG_BKUP_LOC _BITUL(5) +#define MPTCP_SUBFLOW_FLAG_FULLY_ESTABLISHED _BITUL(6) +#define MPTCP_SUBFLOW_FLAG_CONNECTED _BITUL(7) +#define MPTCP_SUBFLOW_FLAG_MAPVALID _BITUL(8) + +#define rta_getattr(type, value) (*(type *)RTA_DATA(value)) + static void die_perror(const char *msg) { perror(msg); @@ -167,6 +197,65 @@ static void print_info_msg(struct mptcp_info *info) printf("bytes_acked: %llu\n", info->mptcpi_bytes_acked); } =20 +/* + * 'print_subflow_info' is from 'mptcp_subflow_info' + * which is a function in 'misc/ss.c' of iproute2. + */ +static void print_subflow_info(struct rtattr *tb[]) +{ + u_int32_t flags =3D 0; + + printf("It's a mptcp subflow, the subflow info:\n"); + if (tb[MPTCP_SUBFLOW_ATTR_FLAGS]) { + char caps[32 + 1] =3D { 0 }, *cap =3D &caps[0]; + + flags =3D rta_getattr(__u32, tb[MPTCP_SUBFLOW_ATTR_FLAGS]); + + if (flags & MPTCP_SUBFLOW_FLAG_MCAP_REM) + *cap++ =3D 'M'; + if (flags & MPTCP_SUBFLOW_FLAG_MCAP_LOC) + *cap++ =3D 'm'; + if (flags & MPTCP_SUBFLOW_FLAG_JOIN_REM) + *cap++ =3D 'J'; + if (flags & MPTCP_SUBFLOW_FLAG_JOIN_LOC) + *cap++ =3D 'j'; + if (flags & MPTCP_SUBFLOW_FLAG_BKUP_REM) + *cap++ =3D 'B'; + if (flags & MPTCP_SUBFLOW_FLAG_BKUP_LOC) + *cap++ =3D 'b'; + if (flags & MPTCP_SUBFLOW_FLAG_FULLY_ESTABLISHED) + *cap++ =3D 'e'; + if (flags & MPTCP_SUBFLOW_FLAG_CONNECTED) + *cap++ =3D 'c'; + if (flags & MPTCP_SUBFLOW_FLAG_MAPVALID) + *cap++ =3D 'v'; + + if (flags) + printf(" flags:%s", caps); + } + if (tb[MPTCP_SUBFLOW_ATTR_TOKEN_REM] && + tb[MPTCP_SUBFLOW_ATTR_TOKEN_LOC] && + tb[MPTCP_SUBFLOW_ATTR_ID_REM] && + tb[MPTCP_SUBFLOW_ATTR_ID_LOC]) + printf(" token:%04x(id:%u)/%04x(id:%u)", + rta_getattr(__u32, tb[MPTCP_SUBFLOW_ATTR_TOKEN_REM]), + rta_getattr(__u8, tb[MPTCP_SUBFLOW_ATTR_ID_REM]), + rta_getattr(__u32, tb[MPTCP_SUBFLOW_ATTR_TOKEN_LOC]), + rta_getattr(__u8, tb[MPTCP_SUBFLOW_ATTR_ID_LOC])); + if (tb[MPTCP_SUBFLOW_ATTR_MAP_SEQ]) + printf(" seq:%llu", + rta_getattr(__u64, tb[MPTCP_SUBFLOW_ATTR_MAP_SEQ])); + if (tb[MPTCP_SUBFLOW_ATTR_MAP_SFSEQ]) + printf(" sfseq:%u", + rta_getattr(__u32, tb[MPTCP_SUBFLOW_ATTR_MAP_SFSEQ])); + if (tb[MPTCP_SUBFLOW_ATTR_SSN_OFFSET]) + printf(" ssnoff:%u", + rta_getattr(__u32, tb[MPTCP_SUBFLOW_ATTR_SSN_OFFSET])); + if (tb[MPTCP_SUBFLOW_ATTR_MAP_DATALEN]) + printf(" maplen:%u", + rta_getattr(__u32, tb[MPTCP_SUBFLOW_ATTR_MAP_DATALEN])); +} + static void parse_nlmsg(struct nlmsghdr *nlh, __u32 proto) { struct inet_diag_msg *r =3D NLMSG_DATA(nlh); @@ -201,6 +290,7 @@ static void parse_nlmsg(struct nlmsghdr *nlh, __u32 pro= to) =20 parse_rtattr_nested(sfinfo, MPTCP_SUBFLOW_ATTR_MAX, ulpinfo[INET_ULP_INFO_MPTCP]); + print_subflow_info(sfinfo); } else { printf("It's a normal TCP!\n"); } --=20 2.25.1 From nobody Wed Dec 17 07:24:37 2025 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C99413AF2 for ; Wed, 16 Apr 2025 07:35:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744788934; cv=none; b=ld32ILngsD7vouHTbbveANpUForiopEkgSJ+eP/PG0l7LMWNj2Zv1V8gcHqv/RXSnt7ZDCDhpQDdTUeMfnD97P51qYsSjnJI4XYR+R3ZzeXKq2bregs6s/9jsrhWVbL53qh6LpWeK44LP782oS4M4o6F90955nkephoq5i7WqKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744788934; c=relaxed/simple; bh=y25mIN42cxf2iz8vIUfuIIiD3UCSrJgmCW16h4TnS5I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rPYfe419Ve8EfNZrJYmZVCF1PFWqBqLvKRCQQ+Sd7YlwWQg5Y5ex38CeJsPx1NQ/qu/f+hj/DUproyY2e8Ib2Hv0npQ7E8cukAfY/9RWhXemEyT3DEUt0JQwNqpo7qPt3TpjZLg03Swuar2+/u4Z1od8jit9Mueu7rc+xDbVPL4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 5c27649e1a9511f0a216b1d71e6e1362-20250416 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CTE_8B, HR_CTT_MISS HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME, HR_SJ_DIGIT_LEN HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_TRUSTED, SA_EXISTED SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS, CIE_BAD CIE_GOOD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO, GTI_C_BU AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU, ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:bd45a7c8-31f5-4484-a5ea-d448beea4d2a,IP:10, URL:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:20 X-CID-INFO: VERSION:1.1.45,REQID:bd45a7c8-31f5-4484-a5ea-d448beea4d2a,IP:10,UR L:0,TC:0,Content:0,EDM:25,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:20 X-CID-META: VersionHash:6493067,CLOUDID:66970f387c3205f98d033d6618f706ef,BulkI D:2504161535279QFJQ3KQ,BulkQuantity:0,Recheck:0,SF:17|19|24|44|66|78|81|82 |102,TC:nil,Content:0|50,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil ,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_FSI,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD X-UUID: 5c27649e1a9511f0a216b1d71e6e1362-20250416 X-User: yangang@kylinos.cn Received: from localhost.localdomain [(223.70.159.239)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 700928771; Wed, 16 Apr 2025 15:35:24 +0800 From: Gang Yan To: mptcp@lists.linux.dev Cc: Gang Yan , Geliang Tang Subject: [mptcp-next 7/7] selftests: mptcp: add chk_sublfow in diag.sh Date: Wed, 16 Apr 2025 15:35:02 +0800 Message-Id: <8801f99ac66349d26d91cc396c447db2f37dde85.1744788247.git.yangang@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch aims to add chk_dump_subflow in diag.sh. The subflow's info can be obtained through "ss -tin", then use the 'mptcp_diag' to verify the token in subflow_info. Co-developed-by: Geliang Tang Signed-off-by: Geliang Tang Signed-off-by: Gang Yan --- tools/testing/selftests/net/mptcp/diag.sh | 55 +++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/tools/testing/selftests/net/mptcp/diag.sh b/tools/testing/self= tests/net/mptcp/diag.sh index e7a75341f0f3..20de007e44cd 100755 --- a/tools/testing/selftests/net/mptcp/diag.sh +++ b/tools/testing/selftests/net/mptcp/diag.sh @@ -225,6 +225,60 @@ chk_dump_one() fi } =20 +get_endpoint_addr() +{ + echo $1 | cut -d ":" -f 1 +} + +get_endpoint_port() +{ + echo $1 | cut -d ":" -f 2 +} + +chk_dump_subflow() +{ + local inet_diag_token + local subflow_line + local remote_addr + local remote_port + local local_addr + local local_port + local ss_token + local msg + + subflow_line=3D$(ss -tnN $ns | \ + grep -m1 -Eo '[0-9.]+:[0-9].+ +[0-9.]+:[0-9.]+') + + if [ -n "$subflow_line" ]; then + read -r local_endpoint remote_endpoint <<< $subflow_line + + local_addr=3D$(get_endpoint_addr $local_endpoint) + local_port=3D$(get_endpoint_port $local_endpoint) + + remote_addr=3D$(get_endpoint_addr $remote_endpoint) + remote_port=3D$(get_endpoint_port $remote_endpoint) + fi + + ss_token=3D$(ss -tniN $ns | \ + grep -m1 -Eo 'token:[^ ]+') + + inet_diag_token=3D$(ip netns exec $ns ./mptcp_diag -s \ + "$local_addr $local_port $remote_addr $remote_port" | \ + grep -Eo 'token:[^ ]+') + + msg=3D"....chk dump_subflow" + + mptcp_lib_print_title "$msg" + if [[ $ss_token =3D=3D $inet_diag_token ]]; then + mptcp_lib_pr_ok + mptcp_lib_result_pass "${msg}" + else + mptcp_lib_pr_fail "expected $ss_token but $inet_diag_token" + mptcp_lib_result_fail "${msg}" + ret=3D${KSFT_FAIL} + fi +} + msk_info_get_value() { local port=3D"${1}" @@ -316,6 +370,7 @@ chk_msk_fallback_nr 0 "....chk no fallback" chk_msk_inuse 2 chk_msk_cestab 2 chk_dump_one +chk_dump_subflow flush_pids =20 chk_msk_inuse 0 "2->0" --=20 2.25.1