[PATCH mptcp-net v2 0/2] fixes for userspace pm

Geliang Tang posted 2 patches 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1730864444.git.tanggeliang@kylinos.cn
net/mptcp/pm_userspace.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
[PATCH mptcp-net v2 0/2] fixes for userspace pm
Posted by Geliang Tang 1 month ago
From: Geliang Tang <tanggeliang@kylinos.cn>

v2:
 - move "add lookup_addr for userspace pm" out of this set.

Two fixes for userspace pm extract from "BPF path manager" series.

Geliang Tang (2):
  mptcp: update local address flags when setting it
  mptcp: hold pm lock when deleting entry

 net/mptcp/pm_userspace.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

-- 
2.45.2
Re: [PATCH mptcp-net v2 0/2] fixes for userspace pm
Posted by Matthieu Baerts 1 month ago
Hi Geliang,

On 06/11/2024 04:43, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v2:
>  - move "add lookup_addr for userspace pm" out of this set.
> 
> Two fixes for userspace pm extract from "BPF path manager" series.

Thank you for the patches!

Now in our tree:

New patches for t/upstream-net and t/upstream:
- 4cc0bb30ea08: mptcp: update local address flags when setting it
- f084b1c81ee0: mptcp: hold pm lock when deleting entry
- Results: a54ff4f9af98..36fd4e465722 (export-net)
- Results: 370ec37a4049..ca26062fcd85 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/1243f63870234a0da9483ac30bf8e5ac56f5363e/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/d632a6992fcb583953f094dc46a417cf33e61303/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.
Re: [PATCH mptcp-net v2 0/2] fixes for userspace pm
Posted by Matthieu Baerts 1 month ago
Hi Geliang,

On 06/11/2024 04:43, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v2:
>  - move "add lookup_addr for userspace pm" out of this set.

Thank you for the new version, that will be easier to backport!

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.
Re: [PATCH mptcp-net v2 0/2] fixes for userspace pm
Posted by MPTCP CI 1 month ago
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Unstable: 1 failed test(s): packetdrill_regressions 🔴
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/11696918672

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/63b85be8ec5d
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=906742


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)