[PATCH mptcp-next 0/2] update PM event CLOSED handlers

Geliang Tang posted 2 patches 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/multipath-tcp/mptcp_net-next tags/patchew/cover.1725853370.git.tanggeliang@kylinos.cn
net/mptcp/pm.c       | 10 ++++++++++
net/mptcp/protocol.c |  8 +++-----
net/mptcp/protocol.h |  1 +
3 files changed, 14 insertions(+), 5 deletions(-)
[PATCH mptcp-next 0/2] update PM event CLOSED handlers
Posted by Geliang Tang 1 month ago
From: Geliang Tang <tanggeliang@kylinos.cn>

Update two MPTCP PM event handlers: mptcp_pm_connection_closed and
mptcp_pm_subflow_closed.

Geliang Tang (2):
  mptcp: implement mptcp_pm_connection_closed
  mptcp: add back mptcp_pm_subflow_closed

 net/mptcp/pm.c       | 10 ++++++++++
 net/mptcp/protocol.c |  8 +++-----
 net/mptcp/protocol.h |  1 +
 3 files changed, 14 insertions(+), 5 deletions(-)

-- 
2.43.0
Re: [PATCH mptcp-next 0/2] update PM event CLOSED handlers
Posted by Matthieu Baerts 1 month ago
Hi Geliang,

On 09/09/2024 05:45, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> Update two MPTCP PM event handlers: mptcp_pm_connection_closed and
> mptcp_pm_subflow_closed.
> 
> Geliang Tang (2):
>   mptcp: implement mptcp_pm_connection_closed

As mentioned in the individual reviews, I only applied the first patch:

New patches for t/upstream:
- 272ee90e0bd8: mptcp: implement mptcp_pm_connection_closed
- Results: 42ffd3cd6ef4..2e425b685ff0 (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/3073eb594e0b71e81f2e6db6b883a9baca2c9d86/checks

>   mptcp: add back mptcp_pm_subflow_closed
Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.
Re: [PATCH mptcp-next 0/2] update PM event CLOSED handlers
Posted by MPTCP CI 1 month ago
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/10766245271

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/81049f6b01c7
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=888215


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)